From cherry@spica.trombik.org  Wed Aug 27 12:37:07 2008
Return-Path: <cherry@spica.trombik.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6F82F1065681
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 27 Aug 2008 12:37:07 +0000 (UTC)
	(envelope-from cherry@spica.trombik.org)
Received: from spica.trombik.org (spica.trombik.org [211.19.48.12])
	by mx1.freebsd.org (Postfix) with ESMTP id 0DCFB8FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 27 Aug 2008 12:37:06 +0000 (UTC)
	(envelope-from cherry@spica.trombik.org)
Received: by spica.trombik.org (Postfix, from userid 999)
	id 325F41CD2F; Wed, 27 Aug 2008 21:37:03 +0900 (JST)
Message-Id: <20080827123703.325F41CD2F@spica.trombik.org>
Date: Wed, 27 Aug 2008 21:37:03 +0900 (JST)
From: Tomoyuki Sakurai <cherry@trombik.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] dns/dns_mre: "Socket is already connected" error
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         126886
>Category:       ports
>Synopsis:       [MAINTAINER] dns/dns_mre: "Socket is already connected" error
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 27 12:40:03 UTC 2008
>Closed-Date:    Fri Aug 29 15:08:11 UTC 2008
>Last-Modified:  Fri Aug 29 15:10:03 UTC 2008
>Originator:     Tomoyuki Sakurai
>Release:        FreeBSD 7.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD spica.trombik.org 7.0-STABLE FreeBSD 7.0-STABLE #5: Thu Jul 10 22:29:26 JST 2008
>Description:

- do not connect before sendto()
  fixes "Socket is already connected" error

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- dns_mre-1.0_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/dns/dns_mre/Makefile /usr/home/cherry/svk/ports/dns/dns_mre/Makefile
--- /usr/ports/dns/dns_mre/Makefile	2008-08-08 06:28:14.000000000 +0900
+++ /usr/home/cherry/svk/ports/dns/dns_mre/Makefile	2008-08-27 21:26:57.000000000 +0900
@@ -7,6 +7,7 @@
 
 PORTNAME=	dns_mre
 PORTVERSION=	1.0
+PORTREVISION=	1
 CATEGORIES=	dns security
 MASTER_SITES=	http://www.securebits.org/tools/
 DISTNAME=	${PORTNAME}-v${PORTVERSION}
diff -ruN --exclude=CVS /usr/ports/dns/dns_mre/files/patch-dns_mre.c /usr/home/cherry/svk/ports/dns/dns_mre/files/patch-dns_mre.c
--- /usr/ports/dns/dns_mre/files/patch-dns_mre.c	2008-08-08 06:28:14.000000000 +0900
+++ /usr/home/cherry/svk/ports/dns/dns_mre/files/patch-dns_mre.c	2008-08-27 21:26:57.000000000 +0900
@@ -1,5 +1,5 @@
 --- dns_mre.c.orig	2008-08-02 01:23:19.000000000 +0900
-+++ dns_mre.c	2008-08-02 20:37:50.000000000 +0900
++++ dns_mre.c	2008-08-27 21:20:44.000000000 +0900
 @@ -160,7 +160,6 @@
  	u_int8_t *	udp_pointer = NULL;
  	u_int8_t *	dns_pointer = NULL;
@@ -17,7 +17,21 @@
  	int			i;
  
  	if( !answer_flag )
-@@ -797,6 +796,7 @@
+@@ -720,13 +719,6 @@
+ 		exit(1);
+ 	}
+ 
+-	/* Connect to the DNS Server */
+-	if(  connect(sockfd, (struct sockaddr *) &q_d_addr, sizeof( q_d_addr )) == -1 )
+-	{
+-		perror("connect()");
+-		exit(1);
+-	}
+-
+ 	/* Send the DNS Query */
+ 	if( (numbytes = sendto(sockfd, (char *) payload, payload_size, 0,
+ 		(struct sockaddr *)&q_d_addr, sizeof( q_d_addr ))) == -1 )
+@@ -797,6 +789,7 @@
  		"    -x <no_txids>		Number of static Transaction IDs to use (optional; default 15)\n"
  		"    -v					Verbosity\n"
  		, cmd);
--- dns_mre-1.0_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Wed Aug 27 13:09:47 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126886 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Fri Aug 29 15:08:09 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126886 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/126886: commit references a PR
Date: Fri, 29 Aug 2008 15:08:13 +0000 (UTC)

 miwi        2008-08-29 15:08:04 UTC
 
   FreeBSD ports repository
 
   Modified files:
     dns/dns_mre          Makefile 
     dns/dns_mre/files    patch-dns_mre.c 
   Log:
   - do not connect before sendto()
     fixes "Socket is already connected" error
   - Bump PORTREVISION
   
   PR:             126886
   Submitted by:   maintainer
   
   Revision  Changes    Path
   1.2       +1 -0      ports/dns/dns_mre/Makefile
   1.2       +16 -2     ports/dns/dns_mre/files/patch-dns_mre.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
