From lapo@mail.lapo.it  Wed Aug 27 07:27:32 2008
Return-Path: <lapo@mail.lapo.it>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 106961065672
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 27 Aug 2008 07:27:32 +0000 (UTC)
	(envelope-from lapo@mail.lapo.it)
Received: from mail.lapo.it (motoko.lapo.it [88.198.0.105])
	by mx1.freebsd.org (Postfix) with ESMTP id 41EBB8FC1D
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 27 Aug 2008 07:27:30 +0000 (UTC)
	(envelope-from lapo@mail.lapo.it)
Received: (qmail 98724 invoked by uid 1001); 27 Aug 2008 07:27:29 -0000
Message-Id: <20080827072729.98723.qmail@mail.lapo.it>
Date: 27 Aug 2008 07:27:29 -0000
From: Lapo Luchini <lapo@lapo.it>
Reply-To: Lapo Luchini <lapo@lapo.it>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Lapo Luchini <lapo@lapo.it>, Andrew Pantyukhin <infofarmer@FreeBSD.org>
Subject: Makefile.xpi's xpi-gen gets the wrong id sometimes
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         126876
>Category:       ports
>Synopsis:       www/xpi-adblock - Makefile.xpi's xpi-gen gets the wrong id sometimes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 27 07:30:01 UTC 2008
>Closed-Date:    Wed Sep 08 00:45:16 UTC 2010
>Last-Modified:  Wed Sep  8 00:50:05 UTC 2010
>Originator:     Lapo Luchini
>Release:        FreeBSD 6.3-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD motoko.lapo.it 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #8: Thu Dec 13 09:33:49 CET 2007 root@motoko.lapo.it:/usr/obj/usr/src/sys/MOTOKO amd64

>Description:

ports/www/xpi-adblock/Makefile.xpi's xpi-gen target gets the first id 
from install.rdf, which is not always the correct one.

>How-To-Repeat:

cd /usr/ports/www/xpi-stumbleupon
make xpi-gen

produces:       {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
should produce: {AE93811A-5C9A-4d34-8462-F7B864FC4696}

>Fix:

The grep at line 195 can't solve the problem by itself, because the tag 
may be split over multiple line, so it's necessary to use sed or awk to 
choose the correct id.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->infofarmer 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Aug 27 07:41:18 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126876 
Responsible-Changed-From-To: infofarmer->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Sep 7 00:23:02 UTC 2008 
Responsible-Changed-Why:  
Maintainer was reset. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126876 
Responsible-Changed-From-To: freebsd-ports-bugs->chinsan 
Responsible-Changed-By: chinsan 
Responsible-Changed-When: Sun Sep 7 06:41:37 UTC 2008 
Responsible-Changed-Why:  
I'll take this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126876 
Responsible-Changed-From-To: chinsan->miwi 
Responsible-Changed-By: chinsan 
Responsible-Changed-When: Sun Jan 4 18:32:30 UTC 2009 
Responsible-Changed-Why:  
Pass to new maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126876 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Sun Jan 4 18:37:16 UTC 2009 
State-Changed-Why:  
fixed in my local tree. a headup for testing will be come to the end of 
next week. Thanks for your report. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126876 

From: Lapo Luchini <lapo@lapo.it>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/126876: www/xpi-adblock - Makefile.xpi's xpi-gen gets the
 wrong id sometimes
Date: Mon, 21 Jun 2010 12:32:34 +0200

 I can still reproduce this:
 
 % cd /usr/ports/www/xpi-stumbleupon
 % sudo make xpi-gen | fgrep ID
 XPI_ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}
 % cd ../xpi-searchstatus
 % sudo make xpi-gen | fgrep ID
 XPI_ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}
 
 The ID that is found seems to be the one referring to Firefox versions
 that are compatible with the plugin, not the version of the plugin.

From: Lapo Luchini <lapo@lapo.it>
To: bug-followup@FreeBSD.org, Martin Wilke <miwi@FreeBSD.org>
Cc:  
Subject: Re: ports/126876: www/xpi-adblock - Makefile.xpi's xpi-gen gets the
 wrong id sometimes
Date: Mon, 21 Jun 2010 13:12:45 +0200

 This is a multi-part message in MIME format.
 --------------040806030206010503020501
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 7bit
 
 The attached patch fixed the problem for my XPI ports.
 
 --------------040806030206010503020501
 Content-Type: text/plain;
  name="xpi-gen.patch"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="xpi-gen.patch"
 
 LS0tIC91c3IvcG9ydHMvd3d3L3hwaS1hZGJsb2NrL01ha2VmaWxlLnhwaQkyMDA5LTEyLTE0
 IDE1OjM5OjEyLjAwMDAwMDAwMCArMDEwMAorKysgL3Vzci9ob21lL2xhcG8vcG9ydHMveHBp
 LWFkYmxvY2svTWFrZWZpbGUueHBpCTIwMTAtMDYtMjEgMTM6MDg6MTYuMDAwMDAwMDAwICsw
 MjAwCkBAIC0xOTEsOCArMTkxLDkgQEAKICMgTWFpbnRhaW5lciBzZWN0aW9uCiB4cGktZ2Vu
 OglleHRyYWN0CiAJQCR7RUNIT19DTUR9IC1uICdYUElfSUQ9JwotCUAke0dSRVB9IC1FbTEg
 J2VtOmlkfDxpZD4nICR7V1JLU1JDfS9pbnN0YWxsLnJkZiB8ICR7Q1VUfSAtZjItIC1kXD4g
 fCBcCi0JJHtDVVR9IC1mMSAtZFw8IHwgJHtDVVR9IC1mMiAtZFwiCisJQCR7U0VEfSAtbiAn
 LzxSREY6RGVzY3JpcHRpb24gUkRGOmFib3V0PSJ1cm46bW96aWxsYTppbnN0YWxsLW1hbmlm
 ZXN0Ii8sLz4vcCcgJHtXUktTUkN9L2luc3RhbGwucmRmIHwgXAorCQkke0dSRVB9IC1FbTEg
 J2VtOmlkfDxpZD4nIHwgJHtDVVR9IC1mMi0gLWRcPiB8IFwKKwkJJHtDVVR9IC1mMSAtZFw8
 IHwgJHtDVVR9IC1mMiAtZFwiCiAJQCR7RUNIT19DTUR9IC1uICdYUElfRklMRVM9JwogCUBj
 ZCAke1dSS1NSQ30gJiYgJHtGSU5EfSAtcyAuIC1ub3QgLXR5cGUgZCB8IGN1dCAtZjItIC1k
 LyB8ICR7VFJ9ICdcbicgJyAnCiAJQGlmIFsgLWQgJHtGSUxFU0RJUn0gLWEgLWYgJHtGSUxF
 U0RJUn0vY2hyb21lLm1hbmlmZXN0IF0gOyBcCg==
 --------------040806030206010503020501--

From: Lapo Luchini <lapo@lapo.it>
To: bug-followup@FreeBSD.org, Martin Wilke <miwi@FreeBSD.org>
Cc:  
Subject: Re: ports/126876: www/xpi-adblock - Makefile.xpi's xpi-gen gets the
 wrong id sometimes
Date: Thu, 26 Aug 2010 15:24:16 +0200

 This is a multi-part message in MIME format.
 --------------040203070905000604060104
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 7bit
 
 Some extensions use a different XML namespace, the attached patch
 accounts for that.
 
 --------------040203070905000604060104
 Content-Type: text/plain;
  name="xpi-gen2.patch"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="xpi-gen2.patch"
 
 LS0tIC91c3IvcG9ydHMvd3d3L3hwaS1hZGJsb2NrL01ha2VmaWxlLnhwaQkyMDA5LTEyLTE0
 IDE1OjM5OjEyLjAwMDAwMDAwMCArMDEwMAorKysgL3Vzci9ob21lL2xhcG8vcG9ydHMveHBp
 LWFkYmxvY2svTWFrZWZpbGUueHBpCTIwMTAtMDgtMjYgMTU6MjE6MzQuMDAwMDAwMDAwICsw
 MjAwCkBAIC0xOTEsOCArMTkxLDkgQEAKICMgTWFpbnRhaW5lciBzZWN0aW9uCiB4cGktZ2Vu
 OglleHRyYWN0CiAJQCR7RUNIT19DTUR9IC1uICdYUElfSUQ9JwotCUAke0dSRVB9IC1FbTEg
 J2VtOmlkfDxpZD4nICR7V1JLU1JDfS9pbnN0YWxsLnJkZiB8ICR7Q1VUfSAtZjItIC1kXD4g
 fCBcCi0JJHtDVVR9IC1mMSAtZFw8IHwgJHtDVVR9IC1mMiAtZFwiCisJQCR7U0VEfSAtRW4g
 Jy88KFJERjopP0Rlc2NyaXB0aW9uIChSREY6KT9hYm91dD0idXJuOm1vemlsbGE6aW5zdGFs
 bC1tYW5pZmVzdCIvLC8+L3AnICR7V1JLU1JDfS9pbnN0YWxsLnJkZiB8IFwKKwkJJHtHUkVQ
 fSAtRW0xICdlbTppZHw8aWQ+JyB8ICR7Q1VUfSAtZjItIC1kXD4gfCBcCisJCSR7Q1VUfSAt
 ZjEgLWRcPCB8ICR7Q1VUfSAtZjIgLWRcIgogCUAke0VDSE9fQ01EfSAtbiAnWFBJX0ZJTEVT
 PScKIAlAY2QgJHtXUktTUkN9ICYmICR7RklORH0gLXMgLiAtbm90IC10eXBlIGQgfCBjdXQg
 LWYyLSAtZC8gfCAke1RSfSAnXG4nICcgJwogCUBpZiBbIC1kICR7RklMRVNESVJ9IC1hIC1m
 ICR7RklMRVNESVJ9L2Nocm9tZS5tYW5pZmVzdCBdIDsgXAo=
 --------------040203070905000604060104--
State-Changed-From-To: closed->open 
State-Changed-By: pgollucci 
State-Changed-When: Tue Sep 7 17:35:16 UTC 2010 
State-Changed-Why:  
re-open, was never actually committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126876 
Responsible-Changed-From-To: miwi->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Tue Sep 7 17:43:56 UTC 2010 
Responsible-Changed-Why:  
I will take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126876 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Wed Sep 8 00:45:15 UTC 2010 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126876 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/126876: commit references a PR
Date: Wed,  8 Sep 2010 00:44:57 +0000 (UTC)

 pgollucci    2010-09-08 00:44:49 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/xpi-adblock      Makefile.xpi 
   Log:
   - Fix XPI_ID generation when the tag might spam multiple lines [1]
   - Do not install meta data (META-INF) since its not needed
     allow for xpi-post-extract to still work in xpi-* ports [2]
   
   PR:             ports/126876 [1], ports/150327 [2]
   Submitted by:   Lapo Luchini <lapo@lapo.it> [1], [2] tweaked by me
   Approved by:    maintainer timeout (miwi; ~1 yr) [1] [2]
   Tested by:      P6 TB Run, RideCharge TB Run
   
   Revision  Changes    Path
   1.24      +11 -3     ports/www/xpi-adblock/Makefile.xpi
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
