From wxs@atarininja.org  Wed Aug 27 01:34:13 2008
Return-Path: <wxs@atarininja.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 30B49106568B
	for <bug-followup@FreeBSD.org>; Wed, 27 Aug 2008 01:34:13 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.60.158])
	by mx1.freebsd.org (Postfix) with ESMTP id E8A658FC16
	for <bug-followup@FreeBSD.org>; Wed, 27 Aug 2008 01:34:12 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: by syn.atarininja.org (Postfix, from userid 1001)
	id 0E5B15C17; Tue, 26 Aug 2008 21:35:47 -0400 (EDT)
Message-Id: <20080827013547.GE74386@atarininja.org>
Date: Tue, 26 Aug 2008 21:35:47 -0400
From: Wesley Shields <wxs@FreeBSD.org>
To: Julien SAFAR <jsasys@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: New port: www/vulture - A HTTP reverse proxy for your web
	applications

>Number:         126868
>Category:       ports
>Synopsis:       Re: New port: www/vulture - A HTTP reverse proxy for your web applications
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 27 01:40:00 UTC 2008
>Closed-Date:    Wed Aug 27 04:47:08 UTC 2008
>Last-Modified:  Wed Aug 27 04:47:08 UTC 2008
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 Julien,
 
 I've noticed a couple of things about this port that I think should be
 fixed before I feel comfortable committing it.
 
 The rc script that is installed should be compliant with the rc system
 in FreeBSD.  Please see this URL for more information:
 
 http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html
 
 2. The instructions in pkg-message leave me a bit uneasy.  Shouldn't the
 installation of any necessary dependencies be handled by the ports
 system, and not require the user to install arbitrary perl modules from
 the vulture directory.  If they are arbitrarily installed they will not
 be registered in the pkgdb and this is bad form.
 
 3. It assumes the PREFIX is /usr/local which is not always the case.
 This assumption is made in files/pkg-message.in, files/patch-If.php,
 files/patch-Rhandler, files/patch-THandler, files/patch-config.php,
 files/patch-httpd, files/patch-phpmvc-config, files/patch-sqlitedump and
 files/patch-vulture-init.  This can be fixed by doing some substitution
 with %%PREFIX%%.
 
 4. If you install a proper rc script you can likely remove the
 dependency on sysutils/pidof, since AFAIK it is only used in the
 incorrect rc script.
 
 I would be happy to work with you on any questions you may have on how
 to fix the problems I've listed.
 
 -- WXS
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Wed Aug 27 04:46:26 UTC 2008 
State-Changed-Why:  
Misfiled followup to ports/125783; content migrated. 


Responsible-Changed-From-To: gnats-admin->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Aug 27 04:46:26 UTC 2008 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=126868 
>Unformatted:
