From nobody@FreeBSD.org  Fri Aug 22 18:10:29 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 618C01065722
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Aug 2008 18:10:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 526BB8FC21
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Aug 2008 18:10:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m7MIASUb088580
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Aug 2008 18:10:28 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m7MIASnn088579;
	Fri, 22 Aug 2008 18:10:28 GMT
	(envelope-from nobody)
Message-Id: <200808221810.m7MIASnn088579@www.freebsd.org>
Date: Fri, 22 Aug 2008 18:10:28 GMT
From: Alexey Shuvaev <shuvaev@physik.uni-wuerzburg.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH]: cad/brlcad on CURRENT
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: erik@smluc.org

>Number:         126746
>Category:       ports
>Synopsis:       [PATCH]: cad/brlcad on CURRENT
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 22 18:20:01 UTC 2008
>Closed-Date:    Wed Sep 03 22:18:06 UTC 2008
>Last-Modified:  Wed Sep 03 22:18:06 UTC 2008
>Originator:     Alexey Shuvaev
>Release:        8.0-CURRENT
>Organization:
University of Wuerzburg
>Environment:
FreeBSD wep4017.physik.uni-wuerzburg.de 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Wed Aug 20 17:15:25 CEST 2008 root@wep4017.physik.uni-wuerzburg.de:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
After recent commit of MPSAFE TTY layer cad/brlcad builds
and runs successfully on CURRENT.

However, it is marked as BROKEN= does not compile.
The relevant PR, when it was marked BROKEN is
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124733
The reason for this was not the changes in TTY layer (namely, in termios.h),
but rather some white space problem on tinderbox. From brlcad-7.12.4.log:

[snip]
configure: configuring in misc/enigma
[snip]
configure: loading cache ../../config.cache.freebsd8.0.regis.goodking.ca
configure: error: `CFLAGS' has changed since the previous run:
configure:   former value:  -O2 -pipe  -fno-strict-aliasing
configure:   current value: -O2 -pipe -fno-strict-aliasing
configure: error: changes in the environment can compromise the build
configure: error: run `make distclean' and/or `rm
+../../config.cache.freebsd8.0.regis.goodking.ca' and start over
configure: error: /bin/sh './configure' failed for misc/enigma
[snip]


From: Pedro Giffuni <pfgshield-freebsd@yahoo.com>
Date: Fri, 22 Aug 2008 08:01:18 -0700 (PDT)
To: Alexey Shuvaev <shuvaev@physik.uni-wuerzburg.de>
Cc: freebsd-ports@freebsd.org
Subject: Re: unBREAK cad/brlcad on CURRENT.

Hi;

This was fixed long ago .. it was a bug in bsd.port.mk, not in the port.


>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- brlcad/Makefile.orig	2008-07-16 15:21:09.000000000 +0200
+++ brlcad/Makefile	2008-08-22 20:06:07.000000000 +0200
@@ -113,10 +113,6 @@
 
 .include <bsd.port.pre.mk>
 
-.if ${OSVERSION} >= 800032
-BROKEN=		does not compile
-.endif
-
 EXTRA_LIBS=	${PTHREAD_LIBS}
 
 .ifdef WITH_OPTIMIZATION


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Aug 22 18:20:13 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126746 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: erik@smluc.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/126746: [PATCH]: cad/brlcad on CURRENT
Date: Fri, 22 Aug 2008 18:20:11 UT

 Maintainer of cad/brlcad,
 
 Please note that PR ports/126746 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126746
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/126746: commit references a PR
Date: Wed,  3 Sep 2008 21:39:34 +0000 (UTC)

 lippe       2008-09-03 21:39:25 UTC
 
   FreeBSD ports repository
 
   Modified files:
     cad/brlcad           Makefile 
   Log:
   - After recent commit of MPSAFE TTY layer brlcad builds and runs successfully on CURRENT, then unbreak it.
   
   PR:             ports/126746
   Reported by:    Alexey Shuvaev <shuvaev@physik.uni-wuerzburg.de>
   
   Revision  Changes    Path
   1.35      +0 -4      ports/cad/brlcad/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: lippe 
State-Changed-When: Wed Sep 3 22:18:05 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126746 
>Unformatted:
