From nobody@FreeBSD.org  Fri Aug 22 04:56:06 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A98351065688
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Aug 2008 04:56:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 966B78FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Aug 2008 04:56:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m7M4u5g4053440
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Aug 2008 04:56:05 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m7M4u54m053439;
	Fri, 22 Aug 2008 04:56:05 GMT
	(envelope-from nobody)
Message-Id: <200808220456.m7M4u54m053439@www.freebsd.org>
Date: Fri, 22 Aug 2008 04:56:05 GMT
From: "Joseph S. Atkinson" <jsa@dmz.wickedmachine.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Unnessary dependancy: net/openslp for multimedia/vlc
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         126728
>Category:       ports
>Synopsis:       Unnessary dependancy: net/openslp for multimedia/vlc
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marcus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 22 05:00:12 UTC 2008
>Closed-Date:    Wed Oct 22 00:51:04 UTC 2008
>Last-Modified:  Wed Oct 22 01:00:02 UTC 2008
>Originator:     Joseph S. Atkinson
>Release:        8.0-CURRENT
>Organization:
>Environment:
>Description:
Remove dependency (and usage of) net/openslp from multimedia/vlc. Support for OpenSLP was added to VLC in 2003. Was set for FreeBSD's build via KNOB (defaulted on) by ahze@ almost 4 years ago. When VLC moved to OPTIONS, it was left out of the list, but still defaulted on do to the ".if !defined(WITHOUT_SLP)" stanza being left in.

VLC expunged support for OpenSLP in 2005.

Also, offer to take maintainership at least until VLC moves to Qt. funman@videolan.org has indicated via irc that he no longer uses FreeBSD or works with VLC and was actively seeking a new maintainer.
>How-To-Repeat:
cd /usr/ports/multimedia/vlc && make install
>Fix:
Remove the lingering references to OpenSLP.

Patch attached with submission follows:

Credit "Joseph S. Atkinson <jsa@wickedmachine.net>" if commited please

--- Makefile.orig	2008-08-22 00:20:41.000000000 -0400
+++ Makefile	2008-08-22 00:38:14.000000000 -0400
@@ -10,6 +10,7 @@
 
 PORTNAME=	vlc
 DISTVERSION=	0.8.6i
+PORTREVISION=	1
 PORTEPOCH=	2
 CATEGORIES=	multimedia audio ipv6 net www
 MASTER_SITES=	http://download.videolan.org/pub/videolan/vlc/${DISTVERSION}/ \
@@ -454,12 +455,6 @@
 CONFIGURE_ARGS+=--disable-gnutls
 .endif
 
-.if !defined(WITHOUT_SLP)
-LIB_DEPENDS+=	slp.1:${PORTSDIR}/net/openslp
-.else
-CONFIGURE_ARGS+=--disable-slp
-.endif
-
 .if !defined(WITHOUT_SPEEX)
 LIB_DEPENDS+=	speex.1:${PORTSDIR}/audio/speex
 CONFIGURE_ARGS+=--enable-speex
--- Makefile.inc.orig	2008-08-22 00:21:43.000000000 -0400
+++ Makefile.inc	2008-08-22 00:22:06.000000000 -0400
@@ -187,10 +187,6 @@
 # WITH_SSL=yes
 #  Enable TLS/SSL Support for web (httpd) interface
 #
-# WITHOUT_SLP=yes
-#  Disable SLP service discovery support
-#  * recommended if you want to stream media
-#
 # WITH_OPTIMIZED_CFLAGS=yes
 #  Compile with -O2 -ffast-math -fomit-frame-pointer
 #


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->marcus 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Aug 22 05:00:25 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126728 

From: =?utf-8?B?UmFmYcOrbCBDYXJyw6k=?= <funman@videolan.org>
To: bug-followup@FreeBSD.org, jsa@dmz.wickedmachine.net
Cc: marcus@FreeBSD.org
Subject: Re: ports/126728: Unnessary dependancy: net/openslp for
	multimedia/vlc
Date: Fri, 22 Aug 2008 19:10:19 +0200

 > Remove dependency (and usage of) net/openslp from multimedia/vlc.
 
 Acknowledged.
 
 > Also, offer to take maintainership at least until VLC moves to Qt.
 > funman@videolan.org has indicated via irc that he no longer uses FreeBSD
 > or works with VLC and was actively seeking a new maintainer.
 
 Acknowledged.
 
 By the way VLC (stable) will likely move to Qt in 2 days, release
 tarballs would follow shortly, but I doubt that would make any
 difference in the maintainer's job, multimedia/vlc-devel should be
 renamed to multimedia/vlc "out-of-the-box".
 
 -- 
 Rafaël Carré
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Wed Oct 22 00:50:54 UTC 2008 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126728 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/126728: commit references a PR
Date: Wed, 22 Oct 2008 00:51:01 +0000 (UTC)

 marcus      2008-10-22 00:50:48 UTC
 
   FreeBSD ports repository
 
   Modified files:
     multimedia/vlc       Makefile Makefile.inc 
   Log:
   * Remove the no longer used SLP support
   * Assign maintainership to PR submitter
   
   PR:             126728
   Submitted by:   "Joseph S. Atkinson" <jsa@dmz.wickedmachine.net>
   Approved by:    funman@videolan.org (previous maintainer)
   
   Revision  Changes    Path
   1.176     +2 -7      ports/multimedia/vlc/Makefile
   1.18      +1 -5      ports/multimedia/vlc/Makefile.inc
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
