From nobody@FreeBSD.org  Mon Aug 18 15:35:39 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CAA7E1065671
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Aug 2008 15:35:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id B86828FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Aug 2008 15:35:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m7IFZdCN028030
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Aug 2008 15:35:39 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m7IFZd90028029;
	Mon, 18 Aug 2008 15:35:39 GMT
	(envelope-from nobody)
Message-Id: <200808181535.m7IFZd90028029@www.freebsd.org>
Date: Mon, 18 Aug 2008 15:35:39 GMT
From: Oleg Gawriloff <barzog@telecom.by>
To: freebsd-gnats-submit@FreeBSD.org
Subject: hearbeat incorrect detect interfaces during IPaddr stop
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: scott-ports@tummy.com

>Number:         126628
>Category:       ports
>Synopsis:       sysutils/heartbeat incorrect detect interfaces during IPaddr stop
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    stefan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 18 15:40:02 UTC 2008
>Closed-Date:    Thu Oct 16 18:08:11 UTC 2008
>Last-Modified:  Thu Oct 16 18:10:00 UTC 2008
>Originator:     Oleg Gawriloff
>Release:        7.0
>Organization:
Atlant Telecom
>Environment:
FreeBSD albatros2.telecom.by 7.0-STABLE FreeBSD 7.0-STABLE #1: Fri Jun 13 16:26:45 EEST 2008     root@albatros2.telecom.by:/usr/obj/usr/src/sys/ALBATROS2  amd64

>Description:
We have following ifconfig:
[root@albatros2 ~]# ifconfig
bge0: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=9b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM>
        ether 00:1e:0b:5a:d4:16
        media: Ethernet autoselect (none)
        status: no carrier
bge1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=9b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM>
        ether 00:1e:0b:5a:d4:17
        media: Ethernet 100baseTX <full-duplex>
        status: active
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> metric 0 mtu 16384
        inet 127.0.0.1 netmask 0xff000000
pfsync0: flags=0<> metric 0 mtu 1460
        syncpeer: 224.0.0.240 maxupd: 128
pflog0: flags=141<UP,RUNNING,PROMISC> metric 0 mtu 33160
vlan0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=3<RXCSUM,TXCSUM>
        ether 00:1e:0b:5a:d4:17
        inet 172.16.2.242 netmask 0xffffff00 broadcast 172.16.2.255
        inet 172.16.2.2 netmask 0xffffffff broadcast 172.16.2.2
        media: Ethernet 100baseTX <full-duplex>
        status: active
        vlan: 106 parent interface: bge1
vlan1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=3<RXCSUM,TXCSUM>
        ether 00:1e:0b:5a:d4:17
        inet 213.184.225.47 netmask 0xffffffff broadcast 213.184.225.47
        media: Ethernet 100baseTX <full-duplex>
        status: active
        vlan: 208 parent interface: bge1
When heartbeat trying to stop IPaddr resource on vlan0 it detects following:
[root@albatros2 ~]# /usr/local/etc/ha.d/resource.d/IPaddr 172.16.2.2/24/vlan0 stop
2008/08/18_18:31:15 info: /sbin/route -n delete -host 172.16.2.2
delete host 172.16.2.2
2008/08/18_18:31:15 info: /sbin/ifconfig pflog0 vlan0 inet 172.16.2.2 -alias
ifconfig: vlan0: bad value
2008/08/18_18:31:15 WARN: IP Address 172.16.2.2 NOT released

So in turn causes system reload.

>How-To-Repeat:

>Fix:
New detection routine getted from heartbeat 2.1.3 follows


Patch attached with submission follows:

--- /home/barzog/IPaddr 2008-08-18 18:32:34.000000000 +0300
+++ /usr/local/etc/ha.d/resource.d/IPaddr       2008-08-18 18:33:21.000000000 +0300
@@ -105,7 +105,7 @@

     case $SYSTYPE in
       *BSD)
-               $IFCONFIG | grep "$ipaddr" -B4 | grep "UP," | cut -d ":" -f 1
+               $IFCONFIG | grep "$ipaddr " -B20 | grep "UP," | tail -n 1 | cut -d ":" -f 1
                return 0;;
       *)
                : "comparing $ipaddr to $addr (from ifconfig)"


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Aug 18 21:41:56 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126628 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: scott-ports@tummy.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/126628: sysutils/heartbeat incorrect detect interfaces during IPaddr stop
Date: Mon, 18 Aug 2008 21:41:53 UT

 Maintainer of sysutils/heartbeat,
 
 Please note that PR ports/126628 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126628
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Scott Kleihege <scott-ports@tummy.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/126628: sysutils/heartbeat incorrect detect interfaces
	during IPaddr stop
Date: Thu, 21 Aug 2008 18:25:19 -0600

 On Mon, Aug 18, 2008 at 09:41:53PM +0000, Edwin Groothuis wrote:
 >Maintainer of sysutils/heartbeat,
 >
 >Please note that PR ports/126628 has just been submitted.
 >
 >If it contains a patch for an upgrade, an enhancement or a bug fix
 >you agree on, reply to this email stating that you approve the patch
 >and a committer will take care of it.
 >
 >The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126628
 
 
 I accept the changes, and encourage Oleg to submit the patch upstream.
 Information about contacting the development mailing list is available at
 
    http://linux-ha.org/ContactUs
 
 
 -- 
 Regards,                    tummy.com, ltd
 Scott Kleihege              Linux Consulting since 1995
                             http://www.tummy.com/
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Fri Aug 22 04:22:51 UTC 2008 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126628 

From: Oleg Gawriloff <barzog@telecom.by>
To: bug-followup@FreeBSD.org, barzog@telecom.by
Cc:  
Subject: Re: ports/126628: sysutils/heartbeat incorrect detect interfaces
 during IPaddr stop
Date: Thu, 04 Sep 2008 16:48:22 +0300

 This is a cryptographically signed message in MIME format.
 
 --------------ms080504000803070109060204
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 7bit
 
 It seems that neither this patch or similar patch in 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/121050 is not included 
 in source tree.
 I've tried to contact with developers. This heartbeat version (1.2.5) is 
 rather outdated (2 years old) and is not longer maintained. They have 
 new stable 2.x branch. Port replacement is available in 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/121050, may be we 
 should drop old port in favor of heartbeat2?
 
 --------------ms080504000803070109060204
 Content-Type: application/x-pkcs7-signature; name="smime.p7s"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="smime.p7s"
 Content-Description: S/MIME Cryptographic Signature
 
 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIHtDCC
 A9YwggM/oAMCAQICAgJSMA0GCSqGSIb3DQEBBAUAMIGYMQswCQYDVQQGEwJCWTEQMA4GA1UE
 CBMHQmVsYXJ1czEOMAwGA1UEBxMFTWluc2sxFzAVBgNVBAoTDkF0bGFudC1UZWxlY29tMRcw
 FQYDVQQLEw5BdGxhbnQtVGVsZWNvbTETMBEGA1UEAxMKdGVsZWNvbS5ieTEgMB4GCSqGSIb3
 DQEJARYRYmFyem9nQHRlbGVjb20uYnkwHhcNMDgwNzMwMTIxMjQzWhcNMDkwNzMwMTIxMjQz
 WjCBnzELMAkGA1UEBhMCQlkxEDAOBgNVBAgTB0JlbGFydXMxDjAMBgNVBAcTBU1pbnNrMRcw
 FQYDVQQKEw5BdGxhbnQtVGVsZWNvbTEXMBUGA1UECxMOQXRsYW50LVRlbGVjb20xGjAYBgNV
 BAMUEWJhcnpvZ0B0ZWxlY29tLmJ5MSAwHgYJKoZIhvcNAQkBFhFiYXJ6b2dAdGVsZWNvbS5i
 eTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAuFEB0E3OhT/9NkCYZLGgM3PQfiJfTO2b
 kLfqnAneaC1+/U9WY9c5dleB3KpMxAl/Y9HWo3ClaVZ2Z56V3nj0f9KUTd1Up9G5LgGvP8VJ
 s5NLiiRqJ9isPx44yEuHTwEhGl/zotlTD0rRLVHfqof1cqDe3TobsaevJv0uX1MORRUCAwEA
 AaOCASQwggEgMAkGA1UdEwQCMAAwLAYJYIZIAYb4QgENBB8WHU9wZW5TU0wgR2VuZXJhdGVk
 IENlcnRpZmljYXRlMB0GA1UdDgQWBBSGPX6kqHA5V5oSbuhmF4Nzx9GNjjCBxQYDVR0jBIG9
 MIG6gBQ1Q0N4+R+9Wg0AAlfWqtErWCUf9aGBnqSBmzCBmDELMAkGA1UEBhMCQlkxEDAOBgNV
 BAgTB0JlbGFydXMxDjAMBgNVBAcTBU1pbnNrMRcwFQYDVQQKEw5BdGxhbnQtVGVsZWNvbTEX
 MBUGA1UECxMOQXRsYW50LVRlbGVjb20xEzARBgNVBAMTCnRlbGVjb20uYnkxIDAeBgkqhkiG
 9w0BCQEWEWJhcnpvZ0B0ZWxlY29tLmJ5ggEAMA0GCSqGSIb3DQEBBAUAA4GBACyUjVy0C0C7
 6Wt9w5dAfxLtFXLPIn+dxRWK0r6G/F4a7mLmSHy2fDzn/PSNEDLh+KUpNQNfvXwVdY3ftLVS
 L6gkSNNnbgkiXH2MxlvGHFH+NWbLkNE+t16/OUSIh2iRu1paEKZPtA7f6VviSZ10dTsuKszC
 a85hdq+9cP8Ph3EuMIID1jCCAz+gAwIBAgICAlIwDQYJKoZIhvcNAQEEBQAwgZgxCzAJBgNV
 BAYTAkJZMRAwDgYDVQQIEwdCZWxhcnVzMQ4wDAYDVQQHEwVNaW5zazEXMBUGA1UEChMOQXRs
 YW50LVRlbGVjb20xFzAVBgNVBAsTDkF0bGFudC1UZWxlY29tMRMwEQYDVQQDEwp0ZWxlY29t
 LmJ5MSAwHgYJKoZIhvcNAQkBFhFiYXJ6b2dAdGVsZWNvbS5ieTAeFw0wODA3MzAxMjEyNDNa
 Fw0wOTA3MzAxMjEyNDNaMIGfMQswCQYDVQQGEwJCWTEQMA4GA1UECBMHQmVsYXJ1czEOMAwG
 A1UEBxMFTWluc2sxFzAVBgNVBAoTDkF0bGFudC1UZWxlY29tMRcwFQYDVQQLEw5BdGxhbnQt
 VGVsZWNvbTEaMBgGA1UEAxQRYmFyem9nQHRlbGVjb20uYnkxIDAeBgkqhkiG9w0BCQEWEWJh
 cnpvZ0B0ZWxlY29tLmJ5MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC4UQHQTc6FP/02
 QJhksaAzc9B+Il9M7ZuQt+qcCd5oLX79T1Zj1zl2V4HcqkzECX9j0dajcKVpVnZnnpXeePR/
 0pRN3VSn0bkuAa8/xUmzk0uKJGon2Kw/HjjIS4dPASEaX/Oi2VMPStEtUd+qh/VyoN7dOhux
 p68m/S5fUw5FFQIDAQABo4IBJDCCASAwCQYDVR0TBAIwADAsBglghkgBhvhCAQ0EHxYdT3Bl
 blNTTCBHZW5lcmF0ZWQgQ2VydGlmaWNhdGUwHQYDVR0OBBYEFIY9fqSocDlXmhJu6GYXg3PH
 0Y2OMIHFBgNVHSMEgb0wgbqAFDVDQ3j5H71aDQACV9aq0StYJR/1oYGepIGbMIGYMQswCQYD
 VQQGEwJCWTEQMA4GA1UECBMHQmVsYXJ1czEOMAwGA1UEBxMFTWluc2sxFzAVBgNVBAoTDkF0
 bGFudC1UZWxlY29tMRcwFQYDVQQLEw5BdGxhbnQtVGVsZWNvbTETMBEGA1UEAxMKdGVsZWNv
 bS5ieTEgMB4GCSqGSIb3DQEJARYRYmFyem9nQHRlbGVjb20uYnmCAQAwDQYJKoZIhvcNAQEE
 BQADgYEALJSNXLQLQLvpa33Dl0B/Eu0Vcs8if53FFYrSvob8XhruYuZIfLZ8POf89I0QMuH4
 pSk1A1+9fBV1jd+0tVIvqCRI02duCSJcfYzGW8YcUf41ZsuQ0T63Xr85RIiHaJG7WloQpk+0
 Dt/pW+JJnXR1Oy4qzMJrzmF2r71w/w+HcS4xggNjMIIDXwIBATCBnzCBmDELMAkGA1UEBhMC
 QlkxEDAOBgNVBAgTB0JlbGFydXMxDjAMBgNVBAcTBU1pbnNrMRcwFQYDVQQKEw5BdGxhbnQt
 VGVsZWNvbTEXMBUGA1UECxMOQXRsYW50LVRlbGVjb20xEzARBgNVBAMTCnRlbGVjb20uYnkx
 IDAeBgkqhkiG9w0BCQEWEWJhcnpvZ0B0ZWxlY29tLmJ5AgICUjAJBgUrDgMCGgUAoIICGTAY
 BgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0wODA5MDQxMzQ4MjJa
 MCMGCSqGSIb3DQEJBDEWBBRjWdRRMyWejRbOVmAsMtm9QhK6SjBSBgkqhkiG9w0BCQ8xRTBD
 MAoGCCqGSIb3DQMHMA4GCCqGSIb3DQMCAgIAgDANBggqhkiG9w0DAgIBQDAHBgUrDgMCBzAN
 BggqhkiG9w0DAgIBKDCBsAYJKwYBBAGCNxAEMYGiMIGfMIGYMQswCQYDVQQGEwJCWTEQMA4G
 A1UECBMHQmVsYXJ1czEOMAwGA1UEBxMFTWluc2sxFzAVBgNVBAoTDkF0bGFudC1UZWxlY29t
 MRcwFQYDVQQLEw5BdGxhbnQtVGVsZWNvbTETMBEGA1UEAxMKdGVsZWNvbS5ieTEgMB4GCSqG
 SIb3DQEJARYRYmFyem9nQHRlbGVjb20uYnkCAgJSMIGyBgsqhkiG9w0BCRACCzGBoqCBnzCB
 mDELMAkGA1UEBhMCQlkxEDAOBgNVBAgTB0JlbGFydXMxDjAMBgNVBAcTBU1pbnNrMRcwFQYD
 VQQKEw5BdGxhbnQtVGVsZWNvbTEXMBUGA1UECxMOQXRsYW50LVRlbGVjb20xEzARBgNVBAMT
 CnRlbGVjb20uYnkxIDAeBgkqhkiG9w0BCQEWEWJhcnpvZ0B0ZWxlY29tLmJ5AgICUjANBgkq
 hkiG9w0BAQEFAASBgC0K8kM4knKUK9VkWIu/fbnHq4pPBvxfOE3UimV2S0J6s+QEwqI/4Mn/
 MWmhrPr/SuTZv38LviJyil/2oRVOC425U33U+FQ0Q4VZsSPyyGttTXCAf+GH5K1SKUMevoAd
 fBEKP52eLp5gQ1+XLLBO2el+CfB2KEPNvUGrfuH2xE8lAAAAAAAA
 --------------ms080504000803070109060204--
Responsible-Changed-From-To: freebsd-ports-bugs->stefan 
Responsible-Changed-By: stefan 
Responsible-Changed-When: Thu Oct 16 18:04:30 UTC 2008 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126628 
State-Changed-From-To: open->closed 
State-Changed-By: stefan 
State-Changed-When: Thu Oct 16 18:07:41 UTC 2008 
State-Changed-Why:  
Patch committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126628 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/126628: commit references a PR
Date: Thu, 16 Oct 2008 18:07:38 +0000 (UTC)

 stefan      2008-10-16 18:07:22 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/heartbeat   Makefile 
   Added files:
     sysutils/heartbeat/files patch-heartbeat_resource.d_IPaddr.in 
   Log:
   Fix detection of interfaces.
   
   PR:             126628
   Submitted by:   Oleg Gawriloff <barzog@telecom.by>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.15      +1 -1      ports/sysutils/heartbeat/Makefile
   1.1       +11 -0     ports/sysutils/heartbeat/files/patch-heartbeat_resource.d_IPaddr.in (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
