From yds@dppl.com  Tue Jul 29 00:54:35 2008
Return-Path: <yds@dppl.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D4EFD106567D
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 29 Jul 2008 00:54:35 +0000 (UTC)
	(envelope-from yds@dppl.com)
Received: from dppl.com (orion.dppl.biz [216.182.10.231])
	by mx1.freebsd.org (Postfix) with ESMTP id 8EFB38FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 29 Jul 2008 00:54:35 +0000 (UTC)
	(envelope-from yds@dppl.com)
Received: from localhost (localhost [127.0.0.1])
  (uid 1001)
  by dppl.com with local; Mon, 28 Jul 2008 20:54:34 -0400
  id 06432C94.00000000488E6A4A.000027C8
Message-Id: <courier.00000000488E6A4A.000027C8@dppl.com>
Date: Mon, 28 Jul 2008 20:54:34 -0400
From: Yarema <yds@CoolRat.org>
Reply-To: Yarema <yds@CoolRat.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: robin@isometry.net, Geoffroy Desvernay <dgeo@ec-marseille.fr>
Subject: [PATCH] mail/dovecot-managesieve 
X-Send-Pr-Version: 3.113
X-GNATS-Notify: dgeo@ec-marseille.fr

>Number:         126059
>Category:       ports
>Synopsis:       [PATCH] mail/dovecot-managesieve
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 29 01:00:08 UTC 2008
>Closed-Date:    Wed Jul 30 02:20:49 UTC 2008
>Last-Modified:  Wed Jul 30 02:20:49 UTC 2008
>Originator:     Yarema
>Release:        FreeBSD 6.3-STABLE amd64
>Organization:
NYCBUG.org
>Environment:
	FreeBSD 6.3-STABLE amd64
	FreeBSD 7.0-STABLE amd64
>Description:
Fix the text in pkg-descr and pkg-message to be about mail/dovecot-managesieve
and not the port it was copied from.

Fix PORTNAME so no version number is hardcoded and add DISTNAME to fetch the
correct tarball.

Change the COMMENT to be more descriptive.

Change RUN_DEPENDS to reference the installed ports and versions being depended on.

Fix CONFIGURE_ARGS to use ${MAKE} rather than hardcoding "make" and split to
multiple lines for readability.

See http://www.FreeBSD.org/cgi/query-pr.cgi?pr=126054 for corresponding patch to
mail/dovecot adding ManageSieve support which enables mail/dovecot-managesieve
port to work as intended.
>How-To-Repeat:
>Fix:
diff -u -r -N dovecot-managesieve~/Makefile dovecot-managesieve/Makefile
--- dovecot-managesieve~/Makefile	2008-07-19 06:11:14.000000000 -0400
+++ dovecot-managesieve/Makefile	2008-07-28 19:11:25.950630433 -0400
@@ -5,20 +5,26 @@
 # $FreeBSD: ports/mail/dovecot-managesieve/Makefile,v 1.1 2008/07/19 10:11:14 miwi Exp $
 #
 
-PORTNAME=	dovecot-1.1-managesieve
+PORTNAME=	dovecot-managesieve
 PORTVERSION=	0.10.3
 CATEGORIES=	mail
-MASTER_SITES=	http://www.rename-it.nl/dovecot/1.1/
+MASTER_SITES=	http://www.rename-it.nl/dovecot/${DOVECOTVERSION}/
+DISTNAME=	${PORTNAME:C/-/-${DOVECOTVERSION}-/}-${DISTVERSIONPREFIX}${DISTVERSION:C/:(.)/\1/g}${DISTVERSIONSUFFIX}
 
 MAINTAINER=	dgeo@ec-marseille.fr
-COMMENT=	Managesieve package
+COMMENT=	Dovecot ManageSieve Server daemon
 
 BUILD_DEPENDS=	${NONEXISTENT}:${PORTSDIR}/mail/dovecot:build \
 		${NONEXISTENT}:${PORTSDIR}/mail/dovecot-sieve:build
-RUN_DEPENDS=	${LOCALBASE}/lib/dovecot/lda/lib90_cmusieve_plugin.so:${PORTSDIR}/mail/dovecot-sieve
+RUN_DEPENDS=	dovecot>=1.1.*:${PORTSDIR}/mail/dovecot \
+		dovecot-sieve>=1.1.*:${PORTSDIR}/mail/dovecot-sieve
+
+DOVECOTVERSION=	1.1
 
 GNU_CONFIGURE=	yes
 CONFIGURE_TARGET=	--build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
-CONFIGURE_ARGS=	--prefix=${PREFIX} --with-dovecot=`make -C ${PORTSDIR}/mail/dovecot -V WRKSRC` --with-dovecot-sieve=`make -C ${PORTSDIR}/mail/dovecot-sieve -V WRKSRC`
+CONFIGURE_ARGS=	--prefix=${PREFIX} \
+		--with-dovecot=`${MAKE} -C ${PORTSDIR}/mail/dovecot -V WRKSRC` \
+		--with-dovecot-sieve=`${MAKE} -C ${PORTSDIR}/mail/dovecot-sieve -V WRKSRC`
 
 .include <bsd.port.mk>
diff -u -r -N dovecot-managesieve~/distinfo dovecot-managesieve/distinfo
--- dovecot-managesieve~/distinfo	2008-07-19 06:11:14.000000000 -0400
+++ dovecot-managesieve/distinfo	2008-07-28 11:39:22.374073032 -0400
@@ -1,3 +1,3 @@
-SIZE (dovecot-1.1-managesieve-0.10.3.tar.gz) = 395123
 MD5 (dovecot-1.1-managesieve-0.10.3.tar.gz) = 14ad3bdec508bad8bcce35b57681d255
 SHA256 (dovecot-1.1-managesieve-0.10.3.tar.gz) = ac70ee48cdec2d472c14cb93bc9f3339a30763e418a579ddea0b9b18befac5ac
+SIZE (dovecot-1.1-managesieve-0.10.3.tar.gz) = 395123
diff -u -r -N dovecot-managesieve~/pkg-descr dovecot-managesieve/pkg-descr
--- dovecot-managesieve~/pkg-descr	2008-07-19 06:11:14.000000000 -0400
+++ dovecot-managesieve/pkg-descr	2008-04-22 20:56:38.000000000 -0400
@@ -1,9 +1,7 @@
-From the Dovecot wiki on LDA (WWW: http://wiki.dovecot.org/LDA/Sieve)
+Dovecot native ManageSieve implementation
 
-Sieve language support by a plugin for the deliver LDA
+Provides ManageSieve protocol service giving users the ability to
+upload their own Sieve scripts to the server, i.e. without the need
+for shell or FTP access.
 
-    * Mail filtering
-    * Mail forwarding
-    * Vacation auto-reply
-
-WWW:	http://www.dovecot.org
+WWW:	http://Wiki.Dovecot.org/ManageSieve
diff -u -r -N dovecot-managesieve~/pkg-message dovecot-managesieve/pkg-message
--- dovecot-managesieve~/pkg-message	2008-07-19 06:11:14.000000000 -0400
+++ dovecot-managesieve/pkg-message	2008-04-22 20:59:26.000000000 -0400
@@ -1,16 +1,20 @@
----------------------------------------------------------------------
+----------------------------------------------------------------------
  
- This port assumes you are known with Dovecot and have it installed
- and running on the system you have installed this plugin on.
+ This port assumes you are familiar with Dovecot and have it installed
+ and running on the system you have installed this service on.
 
- You can enable the plugin with this directive in your dovecot.conf:
+ You can enable the service with this directive in your dovecot.conf:
 
-     protocol lda {
-  	mail_plugins = cmusieve
+     protocol managesieve {
+	sieve=~/.dovecot.sieve
+	sieve_storage=~/sieve
      }
 
+ And don't forget to add "managesieve" to the "protocols" setting
+ if you use it. 
+
  Further information on configuration can be found at:
  
-  http://wiki.dovecot.org/
+  http://Wiki.Dovecot.org/ManageSieve
 
----------------------------------------------------------------------
+----------------------------------------------------------------------
diff -u -r -N dovecot-managesieve~/pkg-plist dovecot-managesieve/pkg-plist
--- dovecot-managesieve~/pkg-plist	2008-07-19 06:11:14.000000000 -0400
+++ dovecot-managesieve/pkg-plist	2008-04-22 21:32:29.000000000 -0400
@@ -1,4 +1,4 @@
-@comment $ID:$
+@comment $FreeBSD: $
 libexec/dovecot/managesieve
 libexec/dovecot/managesieve-login
 @dirrmtry libexec/dovecot
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Jul 29 01:00:28 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126059 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: dgeo@ec-marseille.fr
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/126059: [PATCH] mail/dovecot-managesieve
Date: Tue, 29 Jul 2008 01:00:24 UT

 Maintainer of mail/dovecot-managesieve,
 
 Please note that PR ports/126059 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126059
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Robin Breathe" <robin@isometry.net>
To: bug-followup@freebsd.org
Cc: Yarema <yds@coolrat.org>, "Geoffroy Desvernay" <dgeo@ec-marseille.fr>
Subject: Re: ports/126059: [PATCH] mail/dovecot-managesieve
Date: Tue, 29 Jul 2008 21:38:19 +0100

 I've just received a message from the maintainer indicating that he
 will be unavailable until August 25th.
 Could we please assume a maintainer timeout, and get this committed
 (with ports/126054), given that the current port is broken?
 
 Regards,
 Robin (maintainer of mail/dovecot)
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: beech 
Responsible-Changed-When: Tue Jul 29 20:49:51 UTC 2008 
Responsible-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=126059 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/126059: commit references a PR
Date: Wed, 30 Jul 2008 02:19:55 +0000 (UTC)

 beech       2008-07-30 02:19:41 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/dovecot-managesieve Makefile distinfo pkg-descr 
                              pkg-message pkg-plist 
   Log:
   - Fix the text in pkg-descr and pkg-message to be about mail/dovecot-managesieve
     and not the port it was copied from.
   - Fix PORTNAME so no version number is hardcoded and add DISTNAME to fetch the
     correct tarball.
   - Change the COMMENT to be more descriptive.
     Change RUN_DEPENDS to reference the installed ports and versions being depended on.
   - Fix CONFIGURE_ARGS to use ${MAKE} rather than hardcoding "make" and split to
     multiple lines for readability.
   
   PR:             ports/126059
   Submitted by:   Yarema <yds@CoolRat.org>
   Approved by:    portmgr, linimon (maintainer on vacation)
   
   Revision  Changes    Path
   1.2       +11 -5     ports/mail/dovecot-managesieve/Makefile
   1.2       +1 -1      ports/mail/dovecot-managesieve/distinfo
   1.2       +5 -7      ports/mail/dovecot-managesieve/pkg-descr
   1.2       +12 -8     ports/mail/dovecot-managesieve/pkg-message
   1.2       +1 -1      ports/mail/dovecot-managesieve/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: beech 
State-Changed-When: Wed Jul 30 02:20:35 UTC 2008 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126059 
>Unformatted:
