From nobody@FreeBSD.org  Mon Jul 28 14:47:15 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B46981065674
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 Jul 2008 14:47:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 995D38FC23
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 Jul 2008 14:47:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m6SElFDC034732
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 Jul 2008 14:47:15 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m6SElFWx034731;
	Mon, 28 Jul 2008 14:47:15 GMT
	(envelope-from nobody)
Message-Id: <200807281447.m6SElFWx034731@www.freebsd.org>
Date: Mon, 28 Jul 2008 14:47:15 GMT
From: "Pedro F. Giffuni" <pfgshield-freebsd@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: graphics/geomview: fix build, label broken on amd64
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         126037
>Category:       ports
>Synopsis:       graphics/geomview: fix build, label broken on amd64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    amdmi3
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 28 14:50:03 UTC 2008
>Closed-Date:    Wed Sep 03 01:45:18 UTC 2008
>Last-Modified:  Wed Sep  3 01:50:00 UTC 2008
>Originator:     Pedro F. Giffuni
>Release:        6.3-Release
>Organization:
>Environment:
%uname -a
FreeBSD kakumen.cable.net.co 6.3-RELEASE FreeBSD 6.3-RELEASE #10: Sat Jan 19 01:13:55 COT 2008     root@kakumen.cable.net.co:/usr/src/sys/amd64/compile/SMP  amd64

>Description:
- Fix a typo on this port that enables it to build again.
- Label NOT_FOR AMD64 since it coredumps.
- Sync the patches with those on CVS.
- No functional change.
>How-To-Repeat:

>Fix:
diff -ruN geomview.orig/Makefile geomview/Makefile
--- geomview.orig/Makefile	2008-07-20 23:21:35.000000000 -0500
+++ geomview/Makefile	2008-07-28 09:39:35.000000000 -0500
@@ -14,8 +14,11 @@
 MAINTAINER=	bms@FreeBSD.org
 COMMENT=	An interactive viewer for 3- and 4-D geometric objects
 
+NOT_FOR_ARCHS=	amd64
+NOT_FOR_ARCHS_REASON=	'Signal 11, Segmentation fault'
+
 USE_MOTIF=	yes
-USE_XORG=	glut
+USE_GL=	glut
 
 USE_AUTOTOOLS=	autoconf:213
 
diff -ruN geomview.orig/files/patch-lisp.c geomview/files/patch-lisp.c
--- geomview.orig/files/patch-lisp.c	2008-07-20 23:21:35.000000000 -0500
+++ geomview/files/patch-lisp.c	2008-07-21 10:48:31.000000000 -0500
@@ -1,5 +1,52 @@
---- src/lib/oogl/lisp/lisp.c.orig	Fri Sep  1 15:38:16 2000
-+++ src/lib/oogl/lisp/lisp.c	Mon Aug 12 17:02:09 2002
+--- src/lib/oogl/lisp/lisp.c	2000/09/01 22:38:16	1.2
++++ src/lib/oogl/lisp/lisp.c	2006/06/26 15:41:16	1.4
+@@ -1205,9 +1205,9 @@
+ 	} else if (argclass == LARRAY) {
+ 	  /* special case for this because it takes 3 args: the base type,
+ 	     the array itself, and a count */
+-	    va_arg(a_list, LType *);
+-	    va_arg(a_list, void *);
+-	    va_arg(a_list, int *);
++	    (void)va_arg(a_list, LType *);
++	    (void)va_arg(a_list, void *);
++	    (void)va_arg(a_list, int *);
+ 
+ 	    ++argspecs;
+ 	    if (LakeMore(lake,c)) {
+@@ -1230,11 +1230,11 @@
+ 	    moreargspecs = 0;
+ 	}
+     } else if(argclass == LLAKE) {
+-	va_arg(a_list, Lake **);
++	(void)va_arg(a_list, Lake **);
+ 	LListAppend(args, LTOOBJ(LLAKE)(&lake));
+     } else {
+       ++argspecs;
+-      va_arg(a_list, void *);
++      (void)va_arg(a_list, void *);
+       if (LakeMore(lake,c)) {
+ 	LObject *arg;
+ 
+@@ -1359,8 +1359,8 @@
+ 	    args = args->cdr;
+ 	    hold = 0;
+ 	  } else {
+-	    va_arg(a_list, void *);
+-	    va_arg(a_list, void *);
++	    (void)va_arg(a_list, void *);
++	    (void)va_arg(a_list, void *);
+ 	  }
+ 	} else if(argtype == LREST) {
+ 	    LList **restp = va_arg(a_list, LList **);
+@@ -1389,7 +1389,7 @@
+ 	args = args->cdr;
+ 	hold = 0;
+       } else
+-	va_arg(a_list, void *);
++	(void)va_arg(a_list, void *);
+     }
+   }
+   if (argsrequired<0) argsrequired = argspecs;
 @@ -2110,7 +2110,7 @@
      va_list *a_list;
      unsigned long *x;
diff -ruN geomview.orig/files/patch-streampool.h geomview/files/patch-streampool.h
--- geomview.orig/files/patch-streampool.h	2008-07-20 23:21:35.000000000 -0500
+++ geomview/files/patch-streampool.h	2008-07-21 10:45:35.000000000 -0500
@@ -1,11 +1,11 @@
---- src/lib/oogl/refcomm/streampool.h.orig	Mon Aug 12 17:15:10 2002
-+++ src/lib/oogl/refcomm/streampool.h	Mon Aug 12 17:15:15 2002
-@@ -29,7 +29,7 @@
- #include "config.h"
- #endif
- 
--#ifdef AIX
-+#if AIX
- # include <sys/select.h>  /* RS-6000 needs this */
- #endif
- 
+--- src/lib/oogl/refcomm/streampool.h	2006/07/14 17:47:21	1.4
++++ src/lib/oogl/refcomm/streampool.h	2006/07/15 19:06:00	1.5
+@@ -116,7 +116,7 @@
+ extern IOBFILE *PoolInputFile(Pool *);
+ extern FILE *PoolOutputFile(Pool *);
+ extern void  PoolDoReread(Pool *);
+-extern void PoolClose(register Pool *p);
++extern void PoolClose(Pool *p);
+ extern int   PoolOType(Pool *, int otype);
+ extern void  PoolSetOType(Pool *, int otype);
+ extern Pool *PoolByName(char *name);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->bms 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jul 28 14:50:14 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126037 
Responsible-Changed-From-To: bms->freebsd-ports-bugs 
Responsible-Changed-By: bms 
Responsible-Changed-When: Mon 1 Sep 2008 13:35:58 UTC 
Responsible-Changed-Why:  
dropped maintainership 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126037 
Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3 
Responsible-Changed-By: amdmi3 
Responsible-Changed-When: Mon Sep 1 14:54:13 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126037 
State-Changed-From-To: open->feedback 
State-Changed-By: amdmi3 
State-Changed-When: Mon Sep 1 21:39:05 UTC 2008 
State-Changed-Why:  
Awaiting submitter's feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126037 

From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: "Pedro F. Giffuni" <pfgshield-freebsd@yahoo.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/126037: graphics/geomview: fix build, label broken on
	amd64
Date: Tue, 2 Sep 2008 01:39:02 +0400

 > Synopsis: graphics/geomview: fix build, label broken on amd64
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=126037
 1) Are patches and NOT_FOR_ARCHS really needed? It builds fine for me
 without patches on 6.3/7.0/8.0 i386/amd64.
 2) Are you interested in maintaining this port?
 
 -- 
 Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
 amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: "Pedro F. Giffuni" <pfgshield-freebsd@yahoo.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/126037: graphics/geomview: fix build, label broken on
	amd64
Date: Tue, 2 Sep 2008 01:47:48 +0400

 > Synopsis: graphics/geomview: fix build, label broken on amd64
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=126037
 Sorry, I've missed PR description. Forget the first question, the
 second is still actual.
 
 -- 
 Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
 amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
State-Changed-From-To: feedback->closed 
State-Changed-By: amdmi3 
State-Changed-When: Wed Sep 3 01:45:17 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126037 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/126037: commit references a PR
Date: Wed,  3 Sep 2008 01:45:24 +0000 (UTC)

 amdmi3      2008-09-03 01:45:10 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/geomview    Makefile 
     graphics/geomview/files patch-lisp.c patch-streampool.h 
   Log:
   - Fix a typo on this port that enables it to build again.
   - Label NOT_FOR AMD64 since it coredumps.
   - Sync the patches with those on CVS.
   - No functional change.
   
   PR:             126037
   Submitted by:   "Pedro F. Giffuni" <pfgshield-freebsd at yahoo dot com>
   
   Revision  Changes    Path
   1.49      +3 -0      ports/graphics/geomview/Makefile
   1.2       +49 -2     ports/graphics/geomview/files/patch-lisp.c
   1.2       +11 -11    ports/graphics/geomview/files/patch-streampool.h
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
