From carpetsmoker@rwxrwxrwx.net  Sat Jul 26 03:43:39 2008
Return-Path: <carpetsmoker@rwxrwxrwx.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BC0C41065671
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Jul 2008 03:43:39 +0000 (UTC)
	(envelope-from carpetsmoker@rwxrwxrwx.net)
Received: from mail.rwxrwxrwx.net (rwxrwxrwx.net [82.93.23.199])
	by mx1.freebsd.org (Postfix) with ESMTP id 26CE28FC16
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Jul 2008 03:43:39 +0000 (UTC)
	(envelope-from carpetsmoker@rwxrwxrwx.net)
Received: from localhost (localhost [127.0.0.1])
	by mail.rwxrwxrwx.net (Postfix) with ESMTP id BCDB26D43D
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Jul 2008 05:47:12 +0200 (CEST)
Received: from mail.rwxrwxrwx.net ([127.0.0.1])
	by localhost (mail.rwxrwxrwx.net [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 9sAfSnuLIR+3 for <FreeBSD-gnats-submit@freebsd.org>;
	Sat, 26 Jul 2008 05:47:06 +0200 (CEST)
Received: from rwxrwxrwx.net (phong [192.168.100.13])
	by mail.rwxrwxrwx.net (Postfix) with ESMTPSA id E01146D409
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Jul 2008 05:47:05 +0200 (CEST)
Message-Id: <20080726034705.E01146D409@mail.rwxrwxrwx.net>
Date: Sat, 26 Jul 2008 05:47:05 +0200 (CEST)
From: Martin Tournoij <carpetsmoker@rwxrwxrwx.net>
Reply-To: Martin Tournoij <carpetsmoker@rwxrwxrwx.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [Patch] audio/mpdscribble Setup script is broken
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         125968
>Category:       ports
>Synopsis:       [Patch] audio/mpdscribble Setup script is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rafan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 26 03:50:01 UTC 2008
>Closed-Date:    Sun Jul 27 02:47:40 UTC 2008
>Last-Modified:  Sun Jul 27 02:50:01 UTC 2008
>Originator:     Martin Tournoij
>Release:        FreeBSD 7.0-STABLE i386
>Organization:
>Environment:
FreeBSD phong.rwxrwxrwx.net 7.0-STABLE FreeBSD 7.0-STABLE #0: Thu Jun 5 22:13:23 CEST 2008 carpetsmoker@phong.rwxrwxrwx.net:/usr/obj/usr/src/sys/PHONG  i386


>Description:
o mpdscribble-setup script is broken, fix it
o Take maintainership

>How-To-Repeat:

>Fix:

--- mpdscribble.diff begins here ---
diff -urN --exclude CVS /ports/audio/mpdscribble/Makefile audio/mpdscribble/Makefile
--- /ports/audio/mpdscribble/Makefile	2008-06-11 17:51:11.000000000 +0200
+++ audio/mpdscribble/Makefile	2008-07-26 05:40:45.000000000 +0200
@@ -7,17 +7,19 @@
 
 PORTNAME=	mpdscribble
 PORTVERSION=	0.2.12
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	audio
-MASTER_SITES=	http://www.frob.nl/projects/scribble/
+MASTER_SITES=	http://www.frob.nl/projects/scribble/ \
+		http://www.carpetsmoker.net/distfiles/ \
+		http://www.xs4all.nl/~tournoij/distfiles/ \
+		http://www.rwxrwxrwx.net/distfiles/
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	Mpd last.fm client
+MAINTAINER=	carpetsmoker@rwxrwxrwx.net
+COMMENT=	Musicpd last.fm client
 
 LIB_DEPENDS=	soup:${PORTSDIR}/devel/libsoup22
 
 GNU_CONFIGURE=	yes
-
 MAN1=		mpdscribble.1
 PLIST_FILES=	bin/mpdscribble bin/mpdscribble-setup
 
diff -urN --exclude CVS /ports/audio/mpdscribble/files/patch-setup.sh audio/mpdscribble/files/patch-setup.sh
--- /ports/audio/mpdscribble/files/patch-setup.sh	2008-06-01 14:34:11.000000000 +0200
+++ audio/mpdscribble/files/patch-setup.sh	2008-07-22 02:31:16.000000000 +0200
@@ -1,15 +1,25 @@
---- setup.sh.orig	2008-06-01 19:53:53.000000000 +0800
-+++ setup.sh	2008-06-01 19:54:16.000000000 +0800
-@@ -26,7 +26,7 @@
+--- setup.sh.orig	2005-04-17 16:53:46.000000000 +0200
++++ setup.sh	2008-07-22 02:30:33.000000000 +0200
+@@ -1,6 +1,6 @@
+ #!/bin/sh
+ 
+-if [ $UID = "0" ]; then 
++if [ $(id -u) -eq 0 ]; then 
+   echo "user root, system-wide installation assumed."
+   echo
+   CONF_DIR=/etc
+@@ -25,8 +25,8 @@
+ echo "log file:            $LOG"
  echo 
  echo "press ctrl-c to cancel if this is not intended."
- echo "continue..."
+-echo "continue..."
 -read -s
-+read
++echo "press enter to continue..."
++read junk
  
  mkdir -p $CONF_DIR
  mkdir -p $CACHE_DIR
-@@ -35,7 +35,7 @@
+@@ -35,17 +35,19 @@
  echo -n "Please enter your audioscrobbler username: "
  read -e USERNAME
  echo -n "and password: "
@@ -18,3 +28,16 @@
  
  echo "username = $USERNAME" > $LOGIN
  chmod 600 $LOGIN
+-MD5=`echo -n $PASSWORD | md5sum | awk '{print $1}'`
++MD5=$(echo -n $PASSWORD | md5 -q)
+ echo "password = $MD5" >> $LOGIN
+ 
+ echo "cache = $CACHE" >> $LOGIN
+ echo "log = $LOG" >> $LOGIN
+ echo "verbose = 2" >> $LOGIN
+ 
++touch $CACHE
++
+ echo ""
+ echo "Thank you."
+ echo "You can try running mpdscribble now."
diff -urN --exclude CVS /ports/audio/mpdscribble/pkg-descr audio/mpdscribble/pkg-descr
--- /ports/audio/mpdscribble/pkg-descr	2006-07-13 10:35:51.000000000 +0200
+++ audio/mpdscribble/pkg-descr	2008-07-22 02:17:10.000000000 +0200
@@ -1,4 +1,4 @@
-mpdscribble is a music player daemon client which
-submits information about tracks being played to audioscrobbler.
+mpdscribble is a music player daemon client which submits information about
+tracks being played to audioscrobbler.
 
 WWW: http://www.frob.nl/scribble.html
--- mpdscribble.diff ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->rafan 
Responsible-Changed-By: rafan 
Responsible-Changed-When: Sat Jul 26 11:51:23 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125968 
State-Changed-From-To: open->closed 
State-Changed-By: rafan 
State-Changed-When: Sun Jul 27 02:47:40 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125968 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/125968: commit references a PR
Date: Sun, 27 Jul 2008 02:47:43 +0000 (UTC)

 rafan       2008-07-27 02:47:34 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/mpdscribble    Makefile pkg-descr 
     audio/mpdscribble/files patch-setup.sh 
   Log:
   - Fix some linux/bash specific commands in mpdscribble-setup
   - Bump PORTREVISION
   - Add couple mirrors from the new maintainer
   - Pass maintainership to submitter
   
   PR:             ports/125968
   Submitted by:   Martin Tournoij <carpetsmoker at rwxrwxrwx.net>
   
   Revision  Changes    Path
   1.10      +7 -5      ports/audio/mpdscribble/Makefile
   1.2       +29 -6     ports/audio/mpdscribble/files/patch-setup.sh
   1.2       +2 -2      ports/audio/mpdscribble/pkg-descr
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
 
