From nobody@FreeBSD.org  Thu Jul 24 02:59:58 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 869A6106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Jul 2008 02:59:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 5DD1D8FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Jul 2008 02:59:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m6O2xwXY070890
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Jul 2008 02:59:58 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m6O2xw1k070889;
	Thu, 24 Jul 2008 02:59:58 GMT
	(envelope-from nobody)
Message-Id: <200807240259.m6O2xw1k070889@www.freebsd.org>
Date: Thu, 24 Jul 2008 02:59:58 GMT
From: "Pedro F. Giffuni" <pfgshield-freebsd@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: science/netcdf: add a WITH_FORTRAN knob
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: sunpoet@sunpoet.net

>Number:         125915
>Category:       ports
>Synopsis:       science/netcdf: add a WITH_FORTRAN knob
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 24 03:00:12 UTC 2008
>Closed-Date:    Thu Aug 07 08:30:14 UTC 2008
>Last-Modified:  Thu Aug  7 08:40:01 UTC 2008
>Originator:     Pedro F. Giffuni
>Release:        6.3-Release
>Organization:
>Environment:
FreeBSD kakumen.cable.net.co 6.3-RELEASE FreeBSD 6.3-RELEASE #10: Sat Jan 19 01:13:55 COT 2008     root@kakumen.cable.net.co:/usr/src/sys/amd64/compile/SMP  amd64

>Description:
- Add experimental WITH_FORTRAN knob and a patch to have it compile.
- It's off by default as it doesn't seem to be required by any port.
- No functional change.
>How-To-Repeat:
- Handle with care: it's not catching gfortran on my system but works fine with f77.
>Fix:
diff -ruN netcdf.orig/Makefile netcdf/Makefile
--- netcdf.orig/Makefile	2008-07-23 21:21:33.000000000 -0500
+++ netcdf/Makefile	2008-07-23 21:27:12.000000000 -0500
@@ -17,7 +17,7 @@
 
 CONFLICTS=	hdf-4.* netcdf-4.*
 
-CONFIGURE_ARGS=	--enable-shared --disable-f77
+CONFIGURE_ARGS=	--enable-shared
 CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS} -I${LOCALBASE}/include -fPIC -DPIC -Df2cFortran"
 
 GNU_CONFIGURE=	yes
@@ -29,6 +29,12 @@
 INFO=		netcdf netcdf-c netcdf-cxx netcdf-f77 netcdf-f90 \
 		netcdf-install netcdf-tutorial
 
+.ifdef WITH_FORTRAN
+USE_FORTRAN=	yes
+.else
+CONFIGURE_ARGS+=--disable-f77
+.endif
+
 post-install:
 	@${STRIP_CMD} ${PREFIX}/bin/ncdump ${PREFIX}/bin/ncgen
 	${LN} -fs libnetcdf.so.4 ${PREFIX}/lib/libnetcdf.so
diff -ruN netcdf.orig/files/patch-fortran+cfortran.h netcdf/files/patch-fortran+cfortran.h
--- netcdf.orig/files/patch-fortran+cfortran.h	1969-12-31 19:00:00.000000000 -0500
+++ netcdf/files/patch-fortran+cfortran.h	2008-07-23 21:49:47.000000000 -0500
@@ -0,0 +1,21 @@
+--- fortran/cfortran.h.orig	2008-07-23 21:47:30.000000000 -0500
++++ fortran/cfortran.h	2008-07-23 21:48:50.000000000 -0500
+@@ -134,7 +134,8 @@
+ /* Split #if into 2 because some HP-UX can't handle long #if */
+ #if !(defined(NAGf90Fortran)||defined(f2cFortran)||defined(hpuxFortran)||defined(apolloFortran)||defined(sunFortran)||defined(IBMR2Fortran)||defined(CRAYFortran)||defined(PATHSCALE_COMPILER)||defined(gFortran))
+ #if !(defined(mipsFortran)||defined(DECFortran)||defined(vmsFortran)||defined(CONVEXFortran)||defined(PowerStationFortran)||defined(AbsoftUNIXFortran)||defined(AbsoftProFortran)||defined(SXFortran))
+-/* If your compiler barfs on ' #error', replace # with the trigraph for #     */
++#define    f2cFortran 
++/* If your compiler barfs on ' #error', replace # with the trigraph for #
+  #error "cfortran.h:  Can't find your environment among:\
+     - MIPS cc and f77 2.0. (e.g. Silicon Graphics, DECstations, ...)     \
+     - IBM AIX XL C and FORTRAN Compiler/6000 Version 01.01.0000.0000     \
+@@ -158,7 +159,7 @@
+     - Absoft Pro Fortran: Use #define AbsoftProFortran \
+     - Portland Group Fortran: Use #define pgiFortran \
+     - PathScale Fortran: Use #define PATHSCALE_COMPILER"
+-/* Compiler must throw us out at this point! */
++   Compiler must throw us out at this point! */
+ #endif
+ #endif
+ 


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jul 24 03:00:24 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125915 
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: beech 
Responsible-Changed-When: Thu Jul 24 03:09:31 UTC 2008 
Responsible-Changed-Why:  
I'll take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125915 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: sunpoet@sunpoet.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/125915: science/netcdf: add a WITH_FORTRAN knob
Date: Thu, 24 Jul 2008 03:00:22 UT

 Maintainer of science/netcdf,
 
 Please note that PR ports/125915 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/125915
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Pedro Giffuni <pfgshield-freebsd@yahoo.com>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: beech@FreeBSD.org, sunpoet@sunpoet.net
Subject: Re: ports/125915: science/netcdf: add a WITH_FORTRAN knob
Date: Wed, 23 Jul 2008 20:30:40 -0700 (PDT)

 --0-1054946411-1216870240=:69305
 Content-Type: text/plain; charset=utf-8
 Content-Transfer-Encoding: quoted-printable
 
 Here;
 
 I found the issue with Fortran detection, enjoy :)=0A=0A=0A      Posta, new=
 s, sport, oroscopo: tutto in una sola pagina. =0ACrea l&#39;home page che p=
 iace a te!=0Awww.yahoo.it/latuapagina
 --0-1054946411-1216870240=:69305
 Content-Type: application/octet-stream; name=patch-netcdf
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="patch-netcdf"
 
 ZGlmZiAtcnVOIG5ldGNkZi5vcmlnL01ha2VmaWxlIG5ldGNkZi9NYWtlZmls
 ZQotLS0gbmV0Y2RmLm9yaWcvTWFrZWZpbGUJMjAwOC0wNy0yMyAyMToyMToz
 My4wMDAwMDAwMDAgLTA1MDAKKysrIG5ldGNkZi9NYWtlZmlsZQkyMDA4LTA3
 LTIzIDIyOjIzOjMxLjAwMDAwMDAwMCAtMDUwMApAQCAtMTcsMTEgKzE3LDEy
 IEBACiAKIENPTkZMSUNUUz0JaGRmLTQuKiBuZXRjZGYtNC4qCiAKLUNPTkZJ
 R1VSRV9BUkdTPQktLWVuYWJsZS1zaGFyZWQgLS1kaXNhYmxlLWY3NworQ09O
 RklHVVJFX0FSR1M9CS0tZW5hYmxlLXNoYXJlZAogQ09ORklHVVJFX0VOVj0J
 Q1BQRkxBR1M9IiR7Q1BQRkxBR1N9IC1JJHtMT0NBTEJBU0V9L2luY2x1ZGUg
 LWZQSUMgLURQSUMgLURmMmNGb3J0cmFuIgogCiBHTlVfQ09ORklHVVJFPQl5
 ZXMKIFVTRV9MRENPTkZJRz0JeWVzCitDT05GSUdVUkVfRU5WKz0JJHtNQUtF
 X0VOVn0KIAogTUFOMT0JCW5jZHVtcC4xIG5jZ2VuLjEKIE1BTjM9CQluZXRj
 ZGYuMwpAQCAtMjksNiArMzAsMTUgQEAKIElORk89CQluZXRjZGYgbmV0Y2Rm
 LWMgbmV0Y2RmLWN4eCBuZXRjZGYtZjc3IG5ldGNkZi1mOTAgXAogCQluZXRj
 ZGYtaW5zdGFsbCBuZXRjZGYtdHV0b3JpYWwKIAorLmlmZGVmIFdJVEhfRk9S
 VFJBTgorVVNFX0ZPUlRSQU49CXllcworTUFOMys9CW5ldGNkZl9mNzcuMyBu
 ZXRjZGZfZjkwLjMKK1BMSVNUX1NVQis9CUZPUlRSQU49IiIKKy5lbHNlCitD
 T05GSUdVUkVfQVJHUys9LS1kaXNhYmxlLWY3NworUExJU1RfU1VCKz0JRk9S
 VFJBTj0iQGNvbW1lbnQgIgorLmVuZGlmCisKIHBvc3QtaW5zdGFsbDoKIAlA
 JHtTVFJJUF9DTUR9ICR7UFJFRklYfS9iaW4vbmNkdW1wICR7UFJFRklYfS9i
 aW4vbmNnZW4KIAkke0xOfSAtZnMgbGlibmV0Y2RmLnNvLjQgJHtQUkVGSVh9
 L2xpYi9saWJuZXRjZGYuc28KZGlmZiAtcnVOIG5ldGNkZi5vcmlnL2ZpbGVz
 L3BhdGNoLWZvcnRyYW4rY2ZvcnRyYW4uaCBuZXRjZGYvZmlsZXMvcGF0Y2gt
 Zm9ydHJhbitjZm9ydHJhbi5oCi0tLSBuZXRjZGYub3JpZy9maWxlcy9wYXRj
 aC1mb3J0cmFuK2Nmb3J0cmFuLmgJMTk2OS0xMi0zMSAxOTowMDowMC4wMDAw
 MDAwMDAgLTA1MDAKKysrIG5ldGNkZi9maWxlcy9wYXRjaC1mb3J0cmFuK2Nm
 b3J0cmFuLmgJMjAwOC0wNy0yMyAyMTo0OTo0Ny4wMDAwMDAwMDAgLTA1MDAK
 QEAgLTAsMCArMSwyMSBAQAorLS0tIGZvcnRyYW4vY2ZvcnRyYW4uaC5vcmln
 CTIwMDgtMDctMjMgMjE6NDc6MzAuMDAwMDAwMDAwIC0wNTAwCisrKysgZm9y
 dHJhbi9jZm9ydHJhbi5oCTIwMDgtMDctMjMgMjE6NDg6NTAuMDAwMDAwMDAw
 IC0wNTAwCitAQCAtMTM0LDcgKzEzNCw4IEBACisgLyogU3BsaXQgI2lmIGlu
 dG8gMiBiZWNhdXNlIHNvbWUgSFAtVVggY2FuJ3QgaGFuZGxlIGxvbmcgI2lm
 ICovCisgI2lmICEoZGVmaW5lZChOQUdmOTBGb3J0cmFuKXx8ZGVmaW5lZChm
 MmNGb3J0cmFuKXx8ZGVmaW5lZChocHV4Rm9ydHJhbil8fGRlZmluZWQoYXBv
 bGxvRm9ydHJhbil8fGRlZmluZWQoc3VuRm9ydHJhbil8fGRlZmluZWQoSUJN
 UjJGb3J0cmFuKXx8ZGVmaW5lZChDUkFZRm9ydHJhbil8fGRlZmluZWQoUEFU
 SFNDQUxFX0NPTVBJTEVSKXx8ZGVmaW5lZChnRm9ydHJhbikpCisgI2lmICEo
 ZGVmaW5lZChtaXBzRm9ydHJhbil8fGRlZmluZWQoREVDRm9ydHJhbil8fGRl
 ZmluZWQodm1zRm9ydHJhbil8fGRlZmluZWQoQ09OVkVYRm9ydHJhbil8fGRl
 ZmluZWQoUG93ZXJTdGF0aW9uRm9ydHJhbil8fGRlZmluZWQoQWJzb2Z0VU5J
 WEZvcnRyYW4pfHxkZWZpbmVkKEFic29mdFByb0ZvcnRyYW4pfHxkZWZpbmVk
 KFNYRm9ydHJhbikpCistLyogSWYgeW91ciBjb21waWxlciBiYXJmcyBvbiAn
 ICNlcnJvcicsIHJlcGxhY2UgIyB3aXRoIHRoZSB0cmlncmFwaCBmb3IgIyAg
 ICAgKi8KKysjZGVmaW5lICAgIGYyY0ZvcnRyYW4gCisrLyogSWYgeW91ciBj
 b21waWxlciBiYXJmcyBvbiAnICNlcnJvcicsIHJlcGxhY2UgIyB3aXRoIHRo
 ZSB0cmlncmFwaCBmb3IgIworICAjZXJyb3IgImNmb3J0cmFuLmg6ICBDYW4n
 dCBmaW5kIHlvdXIgZW52aXJvbm1lbnQgYW1vbmc6XAorICAgICAtIE1JUFMg
 Y2MgYW5kIGY3NyAyLjAuIChlLmcuIFNpbGljb24gR3JhcGhpY3MsIERFQ3N0
 YXRpb25zLCAuLi4pICAgICBcCisgICAgIC0gSUJNIEFJWCBYTCBDIGFuZCBG
 T1JUUkFOIENvbXBpbGVyLzYwMDAgVmVyc2lvbiAwMS4wMS4wMDAwLjAwMDAg
 ICAgIFwKK0BAIC0xNTgsNyArMTU5LDcgQEAKKyAgICAgLSBBYnNvZnQgUHJv
 IEZvcnRyYW46IFVzZSAjZGVmaW5lIEFic29mdFByb0ZvcnRyYW4gXAorICAg
 ICAtIFBvcnRsYW5kIEdyb3VwIEZvcnRyYW46IFVzZSAjZGVmaW5lIHBnaUZv
 cnRyYW4gXAorICAgICAtIFBhdGhTY2FsZSBGb3J0cmFuOiBVc2UgI2RlZmlu
 ZSBQQVRIU0NBTEVfQ09NUElMRVIiCistLyogQ29tcGlsZXIgbXVzdCB0aHJv
 dyB1cyBvdXQgYXQgdGhpcyBwb2ludCEgKi8KKysgICBDb21waWxlciBtdXN0
 IHRocm93IHVzIG91dCBhdCB0aGlzIHBvaW50ISAqLworICNlbmRpZgorICNl
 bmRpZgorIApkaWZmIC1ydU4gbmV0Y2RmLm9yaWcvcGtnLXBsaXN0IG5ldGNk
 Zi9wa2ctcGxpc3QKLS0tIG5ldGNkZi5vcmlnL3BrZy1wbGlzdAkyMDA4LTA3
 LTIzIDIxOjIxOjMzLjAwMDAwMDAwMCAtMDUwMAorKysgbmV0Y2RmL3BrZy1w
 bGlzdAkyMDA4LTA3LTIzIDIyOjI2OjMzLjAwMDAwMDAwMCAtMDUwMApAQCAt
 Myw2ICszLDggQEAKIGluY2x1ZGUvbmN2YWx1ZXMuaAogaW5jbHVkZS9uZXRj
 ZGYuaAogaW5jbHVkZS9uZXRjZGYuaGgKKyUlRk9SVFJBTiUlaW5jbHVkZS9u
 ZXRjZGYubW9kCislJUZPUlRSQU4lJWluY2x1ZGUvdHlwZXNpemVzLm1vZAog
 aW5jbHVkZS9uZXRjZGZjcHAuaAogbGliL2xpYm5ldGNkZi5hCiBsaWIvbGli
 bmV0Y2RmLmxhCkBAIC0xMiw2ICsxNCwxMCBAQAogbGliL2xpYm5ldGNkZl9j
 KysubGEKIGxpYi9saWJuZXRjZGZfYysrLnNvCiBsaWIvbGlibmV0Y2RmX2Mr
 Ky5zby40CislJUZPUlRSQU4lJWxpYi9saWJuZXRjZGZmLmEKKyUlRk9SVFJB
 TiUlbGliL2xpYm5ldGNkZmYubGEKKyUlRk9SVFJBTiUlbGliL2xpYm5ldGNk
 ZmYuc28KKyUlRk9SVFJBTiUlbGliL2xpYm5ldGNkZmYuc28uNAogJSVQT1JU
 RE9DUyUlJSVET0NTRElSJSUvQ09QWVJJR0hUCiAlJVBPUlRET0NTJSUlJURP
 Q1NESVIlJS9SRUFETUUKICUlUE9SVERPQ1MlJSUlRE9DU0RJUiUlL1JFTEVB
 U0VfTk9URVMK
 
 --0-1054946411-1216870240=:69305--
State-Changed-From-To: feedback->closed 
State-Changed-By: beech 
State-Changed-When: Thu Aug 7 08:30:01 UTC 2008 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125915 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/125915: commit references a PR
Date: Thu,  7 Aug 2008 08:29:57 +0000 (UTC)

 beech       2008-08-07 08:29:49 UTC
 
   FreeBSD ports repository
 
   Modified files:
     science/netcdf       Makefile pkg-plist 
   Added files:
     science/netcdf/files patch-fortran+cfortran.h 
   Log:
   - Add experimental WITH_FORTRAN knob and a patch to have it compile.
   - It's off by default as it doesn't seem to be required by any port.
   - No functional change.
   
   PR:             ports/125915
   Submitted by:   Pedro F. Giffuni <pfgshield-freebsd@yahoo.com>
   Approved by:    maintainer timeout (>2 Weeks)
   
   Revision  Changes    Path
   1.32      +13 -1     ports/science/netcdf/Makefile
   1.1       +21 -0     ports/science/netcdf/files/patch-fortran+cfortran.h (new)
   1.8       +6 -0      ports/science/netcdf/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
