From root@cubic.org  Fri Jul 18 22:36:50 2008
Return-Path: <root@cubic.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C0826106564A
	for <freebsd-gnats-submit@freebsd.org>; Fri, 18 Jul 2008 22:36:50 +0000 (UTC)
	(envelope-from root@cubic.org)
Received: from QMTA03.westchester.pa.mail.comcast.net (qmta03.westchester.pa.mail.comcast.net [76.96.62.32])
	by mx1.freebsd.org (Postfix) with ESMTP id 7C3308FC1B
	for <freebsd-gnats-submit@freebsd.org>; Fri, 18 Jul 2008 22:36:50 +0000 (UTC)
	(envelope-from root@cubic.org)
Received: from OMTA10.westchester.pa.mail.comcast.net ([76.96.62.28])
	by QMTA03.westchester.pa.mail.comcast.net with comcast
	id rYZ41Z03X0cZkys53aLp9Z; Fri, 18 Jul 2008 22:20:49 +0000
Received: from _HOSTNAME_ ([24.6.177.165])
	by OMTA10.westchester.pa.mail.comcast.net with comcast
	id raLo1Z00C3aVeMC3WaLoLy; Fri, 18 Jul 2008 22:20:49 +0000
Received: by _HOSTNAME_ (sSMTP sendmail emulation); Fri, 18 Jul 2008 23:24:28 +0200
Message-Id: <20080718223650.7C3308FC1B@mx1.freebsd.org>
Date: Fri, 18 Jul 2008 23:24:28 +0200
From: "Charlie &" <root@cubic.org>
Reply-To: doj@cubic.org
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: fix of documentation packaging for devel/quilt port
X-Send-Pr-Version: 3.113
X-GNATS-Notify: doj@cubic.org

>Number:         125760
>Category:       ports
>Synopsis:       fix of documentation packaging for devel/quilt port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lippe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 18 22:40:02 UTC 2008
>Closed-Date:    Tue Aug 05 17:01:10 UTC 2008
>Last-Modified:  Tue Aug 05 17:01:10 UTC 2008
>Originator:     Dirk Jagdmann
>Release:        FreeBSD 6.1-RELEASE-p11 i386
>Organization:
>Environment:
System: FreeBSD freebsd6.doj 6.1-RELEASE-p11 FreeBSD 6.1-RELEASE-p11 #0: Thu Jan 4 22:21:55 CET 2007 root@freebsd6.doj:/usr/obj/usr/src/sys/SMP i386


	
>Description:
	In one of the patches to devel/quilt port version 0.46 the listing
	of the documentation files and their directory were included in
	pkg-plist with the %%PORTSDIR%% prefix, which would mark the files
	as optionally installed. As they are always installed with the
	Makefile directive PORTDOCS= there is no need to list them again
	in pkg-plist. The patch below fixed this and bumps the patchlevel
	of devel/quilt to 4.
	This problem was reported by "QA Tindy" on 2008-07-17:
	http://t64.tecnik93.com/logs/7-STABLE-FTP/quilt-0.46_3.log
>How-To-Repeat:
	Install and deinstall devel/quilt with patchlevel 3 and three files
	will remain in usr/local/share/doc/quilt/ along with the directory.
	After applying the patch the files and directory are removed when
	deinstalling.
>Fix:
Index: quilt/pkg-plist
===================================================================
--- quilt.orig/pkg-plist	2008-06-23 23:38:14.000000000 +0200
+++ quilt/pkg-plist	2008-07-18 23:02:49.000000000 +0200
@@ -48,9 +48,6 @@
 share/libexec/quilt/unapplied
 share/libexec/quilt/upgrade
 share/libexec/quilt/wrapper/patch
-%%PORTDOCS%%%%DOCSDIR%%/README
-%%PORTDOCS%%%%DOCSDIR%%/README.MAIL
-%%PORTDOCS%%%%DOCSDIR%%/quilt.pdf
 %%NLS%%share/locale/de/LC_MESSAGES/quilt.mo
 %%NLS%%share/locale/fr/LC_MESSAGES/quilt.mo
 %%NLS%%share/locale/ja/LC_MESSAGES/quilt.mo
@@ -60,4 +57,3 @@
 @dirrm share/libexec/quilt
 @dirrm share/libexec
 @dirrm etc/bash_completion.d
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
Index: quilt/Makefile
===================================================================
--- quilt.orig/Makefile	2008-06-23 23:38:14.000000000 +0200
+++ quilt/Makefile	2008-07-18 23:07:13.000000000 +0200
@@ -7,7 +7,7 @@
 
 PORTNAME=	quilt
 PORTVERSION=	0.46
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_SAVANNAH}
 MASTER_SITE_SUBDIR=	quilt
@@ -31,7 +31,7 @@
 CONFIGURE_ARGS=	--with-sed=${LOCALBASE}/bin/gsed --without-getopt --with-patch=${LOCALBASE}/bin/gpatch
 
 MAN1=		guards.1 quilt.1
-PORTDOCS=	README* quilt.pdf
+PORTDOCS=	README README.MAIL quilt.pdf
 
 .include <bsd.port.pre.mk>
 
>Release-Note:
>Audit-Trail:
Class-Changed-From-To: maintainer-update->change-request 
Class-Changed-By: edwin 
Class-Changed-When: Fri Jul 18 22:40:11 UTC 2008 
Class-Changed-Why:  
Fix category (submitter is not maintainer) (via the GNATS Auto Assign 
Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125760 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Jul 18 22:40:15 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125760 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: doj@cubic.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/125760: fix of documentation packaging for devel/quilt port
Date: Fri, 18 Jul 2008 22:40:13 UT

 Maintainer of devel/quilt,
 
 Please note that PR ports/125760 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/125760
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Dirk Jagdmann <doj@cubic.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/125760: fix of documentation packaging for devel/quilt
 port
Date: Fri, 18 Jul 2008 19:11:31 -0700

 Hello ports submitters,
 
 I've written and sumbitted the patch and PR myself, although from a 
 badly configured FreeBSD is had available. As current ports maintainer I 
 approve the fix.
 
 -- 
 ---> Dirk Jagdmann
 ----> http://cubic.org/~doj
 -----> http://llg.cubic.org
Responsible-Changed-From-To: freebsd-ports-bugs->lippe 
Responsible-Changed-By: lippe 
Responsible-Changed-When: Sat Jul 19 04:05:58 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125760 
State-Changed-From-To: feedback->closed 
State-Changed-By: lippe 
State-Changed-When: Tue Aug 5 17:01:09 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125760 
>Unformatted:
