From Fraser@mail.frase.id.au  Thu Jul 17 09:14:38 2008
Return-Path: <Fraser@mail.frase.id.au>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 571C31065680
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 17 Jul 2008 09:14:38 +0000 (UTC)
	(envelope-from Fraser@mail.frase.id.au)
Received: from mail.frase.id.au (203-219-142-174.static.tpgi.com.au [203.219.142.174])
	by mx1.freebsd.org (Postfix) with ESMTP id CBC9A8FC24
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 17 Jul 2008 09:14:37 +0000 (UTC)
	(envelope-from Fraser@mail.frase.id.au)
Received: from mail.frase.id.au (localhost [127.0.0.1])
	by mail.frase.id.au (8.14.2/8.14.2) with ESMTP id m6H9EZIC051330
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 17 Jul 2008 19:14:35 +1000 (EST)
	(envelope-from Fraser@mail.frase.id.au)
Received: (from Fraser@localhost)
	by mail.frase.id.au (8.14.2/8.14.2/Submit) id m6H9EZAr051329;
	Thu, 17 Jul 2008 19:14:35 +1000 (EST)
	(envelope-from Fraser)
Message-Id: <200807170914.m6H9EZAr051329@mail.frase.id.au>
Date: Thu, 17 Jul 2008 19:14:35 +1000 (EST)
From: Fraser Tweedale <frase@frase.id.au>
Reply-To: Fraser Tweedale <frase@frase.id.au>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] multimedia/gpodder - fix dependencies
X-Send-Pr-Version: 3.113
X-GNATS-Notify: chess@chessgriffin.com

>Number:         125709
>Category:       ports
>Synopsis:       [PATCH] multimedia/gpodder - fix dependencies
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 17 09:20:01 UTC 2008
>Closed-Date:    Tue Jul 22 01:08:10 UTC 2008
>Last-Modified:  Tue Jul 22 01:10:00 UTC 2008
>Originator:     Fraser Tweedale
>Release:        FreeBSD 7.0-RELEASE-p1 i386
>Organization:
>Environment:
System: FreeBSD bacardi 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #35: Sun Jun 1 11:33:22 EST 2008 Fraser@bacardi:/usr/obj/usr/src/sys/BACARDI i386


	
>Description:
Add pysqlite2 dependency.
Make libgpod a LIB_DEPENDS, not RUN_DEPENDS
Fix some questionable syntax.

>How-To-Repeat:
	
>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/multimedia/gpodder/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- Makefile	16 Jul 2008 13:00:10 -0000	1.13
+++ Makefile	17 Jul 2008 09:11:55 -0000
@@ -19,6 +19,7 @@
 		convert:${PORTSDIR}/graphics/ImageMagick \
 		help2man:${PORTSDIR}/misc/help2man
 RUN_DEPENDS=	${PYTHON_SITELIBDIR}/feedparser.py:${PORTSDIR}/textproc/py-feedparser \
+		${PYTHON_SITELIBDIR}/pysqlite2/_sqlite.so:${PORTSDIR}/databases/py-pysqlite23 \
 		wget:${PORTSDIR}/ftp/wget \
 		xdg-open:${PORTSDIR}/devel/xdg-utils
 
@@ -51,13 +52,13 @@
 .endif
 
 .if defined(WITH_IPOD)
-RUN_DEPENDS+=	gpod.3:${PORTSDIR}/audio/libgpod \
-		${PYTHON_SITELIBDIR}/py-mad:${PORTSDIR}/audio/py-mad
+LIB_DEPENDS+=	gpod.3:${PORTSDIR}/audio/libgpod
+RUN_DEPENDS+=	${PYTHON_SITELIBDIR}/madmodule.so:${PORTSDIR}/audio/py-mad
 .endif
 
 .if defined(WITH_VIDEO)
 RUN_DEPENDS+=	mplayer:${PORTSDIR}/multimedia/mplayer \
-RUN_DEPENDS+=	${PYTHON_SITELIBDIR}/ID3.py:${PORTSDIR}/audio/py-id3
+		${PYTHON_SITELIBDIR}/ID3.py:${PORTSDIR}/audio/py-id3
 .endif
 
 .if defined(WITH_MP3TAG)

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jul 17 09:20:42 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125709 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: chess@chessgriffin.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/125709: [PATCH] multimedia/gpodder - fix dependencies
Date: Thu, 17 Jul 2008 09:20:40 UT

 Maintainer of multimedia/gpodder,
 
 Please note that PR ports/125709 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/125709
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Chess Griffin <chess@chessgriffin.com>
To: bug-followup@FreeBSD.org, frase@frase.id.au
Cc:  
Subject: Re: ports/125709: [PATCH] multimedia/gpodder - fix dependencies
Date: Fri, 18 Jul 2008 08:58:43 -0400

 Thank you for the report and the patch.  I have tested the patch on my 
 6/7/8 tinderbox and it builds fine, and looks to fix the identified 
 problems.  I have not had a chance to test the actual program on a 
 machine, but I do not see any issues.
 
 Please commit the patch.
 
 Thanks again!
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Fri Jul 18 14:52:28 UTC 2008 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125709 
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: wxs 
Responsible-Changed-When: Fri Jul 18 15:02:47 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125709 
State-Changed-From-To: open->closed 
State-Changed-By: wxs 
State-Changed-When: Tue Jul 22 01:08:09 UTC 2008 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125709 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/125709: commit references a PR
Date: Tue, 22 Jul 2008 01:08:10 +0000 (UTC)

 wxs         2008-07-22 01:07:57 UTC
 
   FreeBSD ports repository
 
   Modified files:
     multimedia/gpodder   Makefile 
   Log:
   Add dependency on pysqlite2.
   Fix other dependencies (LIB not RUN).
   
   PR:             ports/125709
   Submitted by:   Fraser Tweedale <frase@frase.id.au>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.14      +5 -3      ports/multimedia/gpodder/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
