From str@trantor.komkon.org  Tue Jul 15 22:26:23 2008
Return-Path: <str@trantor.komkon.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8FB31106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Jul 2008 22:26:23 +0000 (UTC)
	(envelope-from str@trantor.komkon.org)
Received: from trantor.komkon.org (trantor.komkon.org [65.217.243.220])
	by mx1.freebsd.org (Postfix) with ESMTP id 489258FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Jul 2008 22:26:23 +0000 (UTC)
	(envelope-from str@trantor.komkon.org)
Received: from trantor.komkon.org (str@localhost.komkon.org [127.0.0.1])
	by trantor.komkon.org (8.14.3/8.13.3) with ESMTP id m6FMQLXh069545
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT)
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Jul 2008 18:26:21 -0400 (EDT)
	(envelope-from str@trantor.komkon.org)
Received: (from str@localhost)
	by trantor.komkon.org (8.14.3/8.13.3/Submit) id m6FMQL6B069544;
	Tue, 15 Jul 2008 18:26:21 -0400 (EDT)
	(envelope-from str)
Message-Id: <200807152226.m6FMQL6B069544@trantor.komkon.org>
Date: Tue, 15 Jul 2008 18:26:21 -0400 (EDT)
From: Igor Roshchin <str@komkon.org>
Reply-To: Igor Roshchin <str@komkon.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Incorrect startup variable in mail/up-imapproxy rc.d/imapproxyd.sh 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         125655
>Category:       ports
>Synopsis:       Incorrect startup variable in mail/up-imapproxy rc.d/imapproxyd.sh
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    mbr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 15 22:30:01 UTC 2008
>Closed-Date:    Sat Jan 02 22:33:35 UTC 2010
>Last-Modified:  Sat Jan 02 22:33:35 UTC 2010
>Originator:     Igor Roshchin
>Release:        FreeBSD 5.4-RELEASE i386
>Organization:
Komkon 
>Environment:
System: FreeBSD myhost.domain.com 5.4-RELEASE FreeBSD 5.4-RELEASE #2: Tue Jul 12 16:03:42 EDT 2005 root@myhost.domain.com:/usr/obj/usr/src/sys/NEW i386


	
>Description:
	/usr/local/etc/rc.d/imapproxyd.sh incorrectly uses imapproxyd_conf
	variable that is not being used by /etc/rc.subr:
	# imapproxyd_conf (file):       Set location of conf file.
	#                               Default is "/usr/local/etc/imapproxyd.conf"
	Hence, this config file location is not being read by the program.
	As a result, the program looks for the hardcoded default:
	/etc/imapproxy.conf
	As far as I can tell, /etc/rc.subr does not contain ${name}_conf
	even on 6.x and 7.x systems (rev=1.86)
	One of the possibilities to correct this is to add 
	imapproxyd_flags="-f ${imapproxyd_conf}"


>How-To-Repeat:
	rm /etc/imapproxy.conf 
	create /usr/local/etc/imapproxyd.conf
	reinstall port and try to start it, - it will not start.
	
>Fix:

Here is the patch:

--- files/imapproxyd.sh.in.orig	Fri Jul 20 23:59:50 2007
+++ files/imapproxyd.sh.in.orig	Tue Jul 15 18:05:07 2008
@@ -22,9 +22,11 @@
 load_rc_config $name
 
 : ${imapproxyd_enable="NO"}
 : ${imapproxyd_conf="%%PREFIX%%/etc/imapproxyd.conf"}
 
+imapproxyd_flags="-f ${imapproxyd_conf}"
+
 command=%%PREFIX%%/sbin/in.imapproxyd
 required_files="${imapproxyd_conf}"
 
 run_rc_command "$1"
	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->mbr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Jul 15 22:30:13 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125655 

From: Igor Roshchin <str@komkon.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/125655: Incorrect startup variable in mail/up-imapproxy rc.d/imapproxyd.sh
Date: Thu, 25 Dec 2008 11:01:06 -0500 (EST)

 I just tried to build the same port on 7.0-RELEASE and the (mis-)behavior 
 is still there (obviously).
 
 
 The patch is simple. Please, review it and commit.
State-Changed-From-To: open->closed 
State-Changed-By: mbr 
State-Changed-When: Sat Jan 2 22:33:20 UTC 2010 
State-Changed-Why:  
Fixed via autoconf, thanks anyway 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125655 
>Unformatted:
