From nobody@FreeBSD.org  Sun Jul 13 12:36:06 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2215810656BF
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Jul 2008 12:36:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C0488FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Jul 2008 12:36:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m6DCa5EG094497
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Jul 2008 12:36:05 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m6DCa5ux094496;
	Sun, 13 Jul 2008 12:36:05 GMT
	(envelope-from nobody)
Message-Id: <200807131236.m6DCa5ux094496@www.freebsd.org>
Date: Sun, 13 Jul 2008 12:36:05 GMT
From: Jan Henrik Sylvester <me@janh.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysutils/testdisk configure picks up libs as installed
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         125564
>Category:       ports
>Synopsis:       sysutils/testdisk configure picks up libs as installed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    flz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 13 12:40:01 UTC 2008
>Closed-Date:    Fri Jul 18 09:13:12 UTC 2008
>Last-Modified:  Fri Jul 18 09:20:02 UTC 2008
>Originator:     Jan Henrik Sylvester
>Release:        FreeBSD 7.0-RELEASE-p2 i386
>Organization:
>Environment:
>Description:
sysutils/testdisk configure picks up optional dependencies if installed => add '.else CONFIGURE_ARGS+=--without-*' to '.if defined(WITH_*)'

configure picks up iconv if present => add WITH_ICONV OPTION

e2fsprogs does not currently provide ext2fs.so, since it does not do 'make install-libs' => comment out WITH_E2FSPROGS for now (or change e2fsprogs port)
>How-To-Repeat:
- install sysutils/testdisk with libiconv present

- install sysutils/testdisk with ntfsprogs present but disabled in OPTIONS

- try to install sysutils/testdisk WITH_E2FSPROGS
>Fix:
- add WITH_ICONV to OPTIONS
- for disabled OPTIONS, add CONFIGURE_ARGS+=--without-*
- remove WITH_E2FSPROGS (as long as e2fsprogs does not provide ext2fs.so)

Patch attached with submission follows:

diff -urN Makefile.orig Makefile
--- Makefile.orig	2008-02-14 14:23:29.000000000 +0100
+++ Makefile	2008-07-13 13:46:42.000000000 +0200
@@ -25,22 +25,37 @@
 PLIST_FILES=	sbin/testdisk sbin/photorec
 PORTDOCS=	*
 
-OPTIONS=	E2FSPROGS "Use ext2fs extensions" off \
+OPTIONS=	ICONV "Use iconv extensions" on \
 		NTFSPROGS "Use ntfs extensions" off \
 		PROGSREISERFS "Use reiserfs extensions" off
+#		E2FSPROGS "Use ext2fs extensions" off
 
 .include <bsd.port.pre.mk>
 
-.if defined(WITH_E2FSPROGS)
-LIB_DEPENDS+=	ext2fs.2:${PORTSDIR}/sysutils/e2fsprogs
+.if defined(WITH_ICONV)
+LIB_DEPENDS+=   iconv.3:${PORTSDIR}/converters/libiconv
+.else
+CONFIGURE_ARGS+=--without-iconv
 .endif
 
+# e2fsprogs does not provide ext2fs.so any more
+# since it does not do 'make install-libs'
+#.if defined(WITH_E2FSPROGS)
+#LIB_DEPENDS+=	ext2fs.2:${PORTSDIR}/sysutils/e2fsprogs
+#.else
+#CONFIGURE_ARGS+=--without-ext2fs
+#.endif
+
 .if defined(WITH_NTFSPROGS)
 LIB_DEPENDS+=	ntfs.9:${PORTSDIR}/sysutils/ntfsprogs
+.else
+CONFIGURE_ARGS+=--without-ntfs
 .endif
 
 .if defined(WITH_PROGSREISERFS)
 LIB_DEPENDS+=	reiserfs-0.3.0:${PORTSDIR}/sysutils/progsreiserfs
+.else
+CONFIGURE_ARGS+=--without-reiserfs
 .endif
 
 post-patch:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->flz 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Jul 13 12:40:18 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125564 
State-Changed-From-To: open->closed 
State-Changed-By: flz 
State-Changed-When: Fri Jul 18 09:13:10 UTC 2008 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125564 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/125564: commit references a PR
Date: Fri, 18 Jul 2008 09:12:58 +0000 (UTC)

 flz         2008-07-18 09:12:49 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/testdisk    Makefile distinfo 
   Log:
   - Update sysutils/testdisk to 6.10.
   - Don't install documentation if NOPORTDOCS is defined.
   - Explicitely disable filesystem support when not selected. [1]
   
   PR:             ports/125564 [1]
   Submitted by:   Jan Henrik Sylvester <me@janh.de> [1]
   
   Revision  Changes    Path
   1.20      +28 -4     ports/sysutils/testdisk/Makefile
   1.14      +6 -3      ports/sysutils/testdisk/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
