From root@asa.org.ua  Thu Jul  3 14:12:46 2008
Return-Path: <root@asa.org.ua>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D9F68106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Jul 2008 14:12:46 +0000 (UTC)
	(envelope-from root@asa.org.ua)
Received: from piggy.asa.org.ua (asa.org.ua [213.130.25.69])
	by mx1.freebsd.org (Postfix) with ESMTP id 906B78FC1F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Jul 2008 14:12:46 +0000 (UTC)
	(envelope-from root@asa.org.ua)
Received: from root 	by piggy.asa.org.ua with local id 1KEPLn-000CHI-0r
	for FreeBSD-gnats-submit@freebsd.org; Thu, 03 Jul 2008 16:59:55 +0300
Message-Id: <E1KEPLn-000CHI-0r@piggy.asa.org.ua>
Date: Thu, 03 Jul 2008 16:59:55 +0300
From: Alex Miller <asm@asm.kiev.ua>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [maintainer update] Fix "does not compile with gcc 4.2" problem
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         125220
>Category:       ports
>Synopsis:       [maintainer update] net/frickin: fix "does not compile with gcc 4.2" problem
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gahr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 03 14:20:02 UTC 2008
>Closed-Date:    Mon Jul 07 11:11:09 UTC 2008
>Last-Modified:  Mon Jul  7 11:20:01 UTC 2008
>Originator:     Alex Miller
>Release:        FreeBSD 7.0-RELEASE i386
>Organization:
Home Sweet Home, Inc.
>Environment:
System: FreeBSD 7.0-RELEASE i386

>Description:

	Does not compile with gcc 4.2

>How-To-Repeat:

	Try to compile on 7.xx

>Fix:


diff -urN frickin.orig/Makefile frickin/Makefile
--- frickin.orig/Makefile	2007-12-22 03:23:34.000000000 +0300
+++ frickin/Makefile	2008-07-03 16:43:00.000000000 +0400
@@ -6,6 +6,7 @@
 #
 
 PORTNAME=	frickin
+PORTREVISION?=  1
 DISTVERSION=	2.0BETA2
 CATEGORIES=	net
 MASTER_SITES=	SF
@@ -43,8 +44,4 @@
 IGNORE=		does not compile with old version of pf
 .endif
 
-.if ${OSVERSION} >= 700042
-BROKEN=		does not compile with gcc 4.2
-.endif
-
 .include <bsd.port.post.mk>
diff -urN frickin.orig/files/patch-session.cpp frickin/files/patch-session.cpp
--- frickin.orig/files/patch-session.cpp	1970-01-01 03:00:00.000000000 +0300
+++ frickin/files/patch-session.cpp	2008-07-03 16:34:00.000000000 +0400
@@ -0,0 +1,11 @@
+--- src/session.cpp.orig	2007-01-13 19:28:47.000000000 +0200
++++ src/session.cpp	2008-07-03 16:33:51.000000000 +0300
+@@ -130,7 +130,7 @@
+ 
+ Session* Session::detatch(Client* a_Client)
+ {
+-    list<Client*>::iterator clientIter = NULL;
++    list<Client*>::iterator clientIter = (std::_List_iterator<Client*>)NULL;
+ 
+     assert(a_Client);
+     clientIter = find(m_ClientList.begin(), m_ClientList.end(), a_Client);
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gahr 
Responsible-Changed-By: gahr 
Responsible-Changed-When: Fri Jul 4 18:58:35 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125220 
State-Changed-From-To: open->feedback 
State-Changed-By: gahr 
State-Changed-When: Fri Jul 4 23:04:55 UTC 2008 
State-Changed-Why:  
While it may work, this is not correct. 

What you want is: 

+-    list<Client*>::iterator clientIter = NULL; ++ 
list<Client*>::iterator clientIter = m_ClientList.end(); 

Do you approve this modification? 


http://www.freebsd.org/cgi/query-pr.cgi?pr=125220 
State-Changed-From-To: feedback->closed 
State-Changed-By: gahr 
State-Changed-When: Mon Jul 7 11:11:07 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125220 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/125220: commit references a PR
Date: Mon,  7 Jul 2008 11:11:30 +0000 (UTC)

 gahr        2008-07-07 11:11:16 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/frickin          Makefile 
   Added files:
     net/frickin/files    patch-session.cpp 
   Log:
   - Fix build with GCC 4.2
   
   PR:             125220
   Submitted by:   Alex Miller <asm@asm.kiev.ua> (maintainer)
   
   Revision  Changes    Path
   1.4       +1 -4      ports/net/frickin/Makefile
   1.1       +11 -0     ports/net/frickin/files/patch-session.cpp (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
