From nobody@FreeBSD.org  Mon Jun 30 23:34:32 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D11C11065671
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 30 Jun 2008 23:34:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id BE9818FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 30 Jun 2008 23:34:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m5UNYWjH076917
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 30 Jun 2008 23:34:32 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m5UNYWqj076916;
	Mon, 30 Jun 2008 23:34:32 GMT
	(envelope-from nobody)
Message-Id: <200806302334.m5UNYWqj076916@www.freebsd.org>
Date: Mon, 30 Jun 2008 23:34:32 GMT
From: Warren Block <wblock@wonkity.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] graphics/autotrace options setting ignored
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         125129
>Category:       ports
>Synopsis:       [patch] graphics/autotrace options setting ignored
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 30 23:40:01 UTC 2008
>Closed-Date:    Tue Jul 01 08:30:13 UTC 2008
>Last-Modified:  Tue Jul  1 08:40:00 UTC 2008
>Originator:     Warren Block
>Release:        7-STABLE
>Organization:
>Environment:
FreeBSD speedy.wonkity.com 7.0-STABLE FreeBSD 7.0-STABLE #0: Mon Jun 23 09:20:32 MDT 2008     root@speedy.wonkity.com:/usr/obj/usr/src/sys/SPEEDY  i386
>Description:
graphics/autotrace port has OPTIONS setting in the Makefile, but the options are ignored due to missing .include <bsd.port.pre.mk> statement.
>How-To-Repeat:
cd /usr/ports/graphics/autotrace
make config
  disable MING option
make
  ...and watch it try to include /usr/ports/graphics/ming anyway
>Fix:
Apply patch.


Patch attached with submission follows:

--- Makefile.orig	2008-06-30 16:53:59.000000000 -0600
+++ Makefile	2008-06-30 17:24:19.000000000 -0600
@@ -27,6 +27,8 @@
 OPTIONS=	MING "Enable swf interface" on \
 		PSTOEDIT "Convert postscript to other formats" on
 
+.include <bsd.port.pre.mk>
+
 .if !defined (WITHOUT_MING)
 LIB_DEPENDS+=	ming.4:${PORTSDIR}/graphics/ming
 CONFIGURE_ENV?=	CPPFLAGS="-I${LOCALBASE}/include -I${LOCALBASE}/include/ming"
@@ -47,4 +49,4 @@
 		/^PSTOEDIT_CONFIG=/ s|=.*$$|=pkg-config| ' ${WRKSRC}/configure
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Tue Jul 1 08:30:07 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125129 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/125129: commit references a PR
Date: Tue,  1 Jul 2008 08:30:08 +0000 (UTC)

 miwi        2008-07-01 08:29:57 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/autotrace   Makefile 
   Log:
   - Fix Options
   
   PR:             125129
   Submitted by:   Warren Block <wblock@wonkity.com>
   
   Revision  Changes    Path
   1.39      +4 -2      ports/graphics/autotrace/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
