From nobody@FreeBSD.org  Mon Jun 30 01:33:12 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8B8741065684
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 30 Jun 2008 01:33:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 7A9478FC23
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 30 Jun 2008 01:33:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m5U1XCD5072590
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 30 Jun 2008 01:33:12 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m5U1XBeD072588;
	Mon, 30 Jun 2008 01:33:11 GMT
	(envelope-from nobody)
Message-Id: <200806300133.m5U1XBeD072588@www.freebsd.org>
Date: Mon, 30 Jun 2008 01:33:11 GMT
From: Chris Pet <chrispetso@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: BitchX core dumps on AMD64
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         125108
>Category:       ports
>Synopsis:       irc/BitchX core dumps on AMD64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 30 01:40:01 UTC 2008
>Closed-Date:    Thu Jul 03 00:22:39 UTC 2008
>Last-Modified:  Sun Feb 27 22:43:53 EST 2011
>Originator:     Chris Petrik
>Release:        FreeBSD 7.0-STABLE AMD64
>Organization:
None
>Environment:
FreeBSD slappy.domain 7.0-STABLE FreeBSD 7.0-STABLE #0: Wed Jun 25 04:25:57 CDT 2008     root@.gateway.2wire.net:/usr/obj/usr/src/sys/chris  amd64

>Description:
BitchX 1.1-final and 1.2-SVN both coredump when loaded on a AMD64 based pc. I have tested this with a old patch named patch-amd64 which fixes the issue. Not sure why the patch was removed and also why the commit notes say some patches were removed as they were added to the branch. Any who the patch fixes the coredump this issue is irrelevant in the trunk version of BitchX.
>How-To-Repeat:
compile bitchx from ports on a AMD64 pc
>Fix:


Patch attached with submission follows:

diff -ur BitchX.orig/include/module.h BitchX/include/module.h
--- BitchX.orig/include/module.h	Fri Apr 11 03:09:07 2003
+++ include/module.h	Sun Jan  8 17:18:15 2006
@@ -15,7 +15,7 @@
 
 #include "struct.h"
 
-typedef int (*Function_ptr)();
+typedef long (*Function_ptr)();
 
 #ifdef WANT_DLL
 #ifdef HPUX
diff -ur BitchX.orig/include/modval.h BitchX/include/modval.h
--- BitchX.orig/include/modval.h	Fri Apr 11 03:09:07 2003
+++ include/modval.h	Sun Jan  8 17:18:15 2006
@@ -318,7 +318,7 @@
 #define show_window(x) ((void) (global[SHOW_WINDOW]((Window *)x)))
 #define get_status_by_refnum(x, y) ((char *) (global[GET_STATUS_BY_REFNUM]((unsigned int)x, (unsigned int)y)))
 #define get_visible_by_refnum(x) ((int) (global[GET_VISIBLE_BY_REFNUM]((char *)x)))
-#define get_window_by_desc(x) ((Window *) (global[GET_WINDOW_BY_DESC]((unsigned int)x)))
+#define get_window_by_desc(x) ((Window *) (global[GET_WINDOW_BY_DESC]((unsigned long)x)))
 #define get_window_by_refnum(x) ((Window *) (global[GET_WINDOW_BY_REFNUM]((unsigned int)x)))
 #define get_window_by_name(x) ((Window *) (global[GET_WINDOW_BY_NAME]((char *)x)))
 #define next_window(x, y) ((void) (global[FUNC_NEXT_WINDOW]((char)x, (char *)y)))
diff -ur BitchX.orig/source/screen.c BitchX/source/screen.c
--- BitchX.orig/source/screen.c	Thu Jul 31 09:01:08 2003
+++ source/screen.c	Sun Jan  8 17:18:18 2006
@@ -1377,8 +1377,8 @@
 {
 	if (!w)
 		w = current_window;
-	if (w->screen)
-		w->screen->cursor_window = w;
+/*	if (w->screen)
+		w->screen->cursor_window = w;*/
 }
 
 /*


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jun 30 01:44:05 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125108 

From: "Chris Pet." <chrispetso@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@freebsd.org
Cc:  
Subject: Re: ports/125108: BitchX core dumps on AMD64
Date: Sun, 29 Jun 2008 20:50:02 -0500

 I would just like to add that the patch was not made by me, but rather
 someone else I just reused it.
 
 On 6/29/08, FreeBSD-gnats-submit@freebsd.org
 <FreeBSD-gnats-submit@freebsd.org> wrote:
 > Thank you very much for your problem report.
 > It has the internal identification `ports/125108'.
 > The individual assigned to look at your
 > report is: freebsd-ports-bugs.
 >
 > You can access the state of your problem report at any time
 > via this link:
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=125108
 >
 >>Category:       ports
 >>Responsible:    freebsd-ports-bugs
 >>Synopsis:       BitchX core dumps on AMD64
 >>Arrival-Date:   Mon Jun 30 01:40:01 UTC 2008
 >
State-Changed-From-To: open->closed 
State-Changed-By: beech 
State-Changed-When: Thu Jul 3 00:22:22 UTC 2008 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125108 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/125108: commit references a PR
Date: Thu,  3 Jul 2008 00:22:02 +0000 (UTC)

 beech       2008-07-03 00:21:56 UTC
 
   FreeBSD ports repository
 
   Modified files:
     irc/bitchx           Makefile 
   Added files:
     irc/bitchx/files     patch-amd64_fix 
   Log:
   - Add patch to fix core dump issue on amd64
   - Bump portrevision
   
   PR:             ports/125108
   Submitted by:   Chris Pet <chrispetso@gmail.com>
   
   Revision  Changes    Path
   1.91      +1 -1      ports/irc/bitchx/Makefile
   1.1       +44 -0     ports/irc/bitchx/files/patch-amd64_fix (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
