From cherry@spica.trombik.org  Fri Jun 27 03:33:42 2008
Return-Path: <cherry@spica.trombik.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 28E5F1065687
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 27 Jun 2008 03:33:42 +0000 (UTC)
	(envelope-from cherry@spica.trombik.org)
Received: from spica.trombik.org (spica.trombik.org [211.19.48.12])
	by mx1.freebsd.org (Postfix) with ESMTP id EEDF68FC17
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 27 Jun 2008 03:33:41 +0000 (UTC)
	(envelope-from cherry@spica.trombik.org)
Received: by spica.trombik.org (Postfix, from userid 999)
	id 807331CD01; Fri, 27 Jun 2008 12:33:38 +0900 (JST)
Message-Id: <20080627033338.807331CD01@spica.trombik.org>
Date: Fri, 27 Jun 2008 12:33:38 +0900 (JST)
From: Tomoyuki Sakurai <cherry@trombik.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: marcus@FreeBSD.org
Subject: [PATCH] ports-mgmt/portlint: warn %%PORTDOCS%%%%EXAMPLESDIR%%
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         125037
>Category:       ports
>Synopsis:       [PATCH] ports-mgmt/portlint: warn %%PORTDOCS%%%%EXAMPLESDIR%%
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marcus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 27 03:40:01 UTC 2008
>Closed-Date:    Sat Jul 05 06:03:47 UTC 2008
>Last-Modified:  Sat Jul  5 06:10:01 UTC 2008
>Originator:     Tomoyuki Sakurai
>Release:        FreeBSD 7.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD spica.trombik.org 7.0-STABLE FreeBSD 7.0-STABLE #3: Tue Jun 24 08:49:06 JST 2008
>Description:
- warn %%PORTDOCS%%%%EXAMPLESDIR%% and %%PORTDOCS%%%%DATADIR%% in plist

Port maintainer (marcus@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- portlint-2.9.9.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/ports-mgmt/portlint/Makefile /usr/home/cherry/svk/ports/ports-mgmt/portlint/Makefile
--- /usr/ports/ports-mgmt/portlint/Makefile	2008-03-23 09:25:30.000000000 +0900
+++ /usr/home/cherry/svk/ports/ports-mgmt/portlint/Makefile	2008-06-27 12:25:57.000000000 +0900
@@ -8,7 +8,7 @@
 #
 
 PORTNAME=	portlint
-PORTVERSION=	2.9.8
+PORTVERSION=	2.9.9
 CATEGORIES=	ports-mgmt
 MASTER_SITES=	# none
 DISTFILES=	# none
diff -ruN --exclude=CVS /usr/ports/ports-mgmt/portlint/src/portlint.pl /usr/home/cherry/svk/ports/ports-mgmt/portlint/src/portlint.pl
--- /usr/ports/ports-mgmt/portlint/src/portlint.pl	2008-03-23 09:25:30.000000000 +0900
+++ /usr/home/cherry/svk/ports/ports-mgmt/portlint/src/portlint.pl	2008-06-27 12:25:45.000000000 +0900
@@ -46,7 +46,7 @@
 # version variables
 my $major = 2;
 my $minor = 9;
-my $micro = 8;
+my $micro = 9;
 
 sub l { '[{(]'; }
 sub r { '[)}]'; }
@@ -837,6 +837,15 @@
 			$sharedocused++;
 		}
 
+		if ($_ =~ /^\%\%PORTDOCS\%\%.*\%\%DATADIR\%\%/) {
+			&perror("WARN", $file, $., "Wrong pair of variables is used. ".
+					"Use %%PORTDATA%% and %%DATADIR%% instead.");
+		}
+		if ($_ =~ /^\%\%PORTDOCS\%\%.*\%\%EXAMPLESDIR\%\%/) {
+			&perror("WARN", $file, $., "Wrong pair of variables is used. ".
+					"Use %%PORTEXAMPLES%% and %%EXAMPLESDIR%% instead.");
+		}
+
 		if ($_ =~ /^share\/examples\//) {
 			&perror("WARN", $file, $., "If and only if your port is ".
 				"EXAMPLESDIR-safe (that is, a user can override EXAMPLESDIR ".
--- portlint-2.9.9.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->marcus 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jun 27 03:40:08 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125037 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Sat Jul 5 06:03:28 UTC 2008 
State-Changed-Why:  
I committed something that's a bit more flexible in 2.9.9. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125037 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/125037: commit references a PR
Date: Sat,  5 Jul 2008 06:02:37 +0000 (UTC)

 marcus      2008-07-05 06:02:28 UTC
 
   FreeBSD ports repository
 
   Modified files:
     ports-mgmt/portlint  Makefile 
     ports-mgmt/portlint/src portlint.pl 
   Log:
   Update to 2.9.9.
   
   Check for misuse of the %%XXXDIR%% constructs in order to help with the QA
   Tinderbox build reports.
   
   PR:             125037
   Submitted by:   leeym
   
   Revision  Changes    Path
   1.122     +1 -1      ports/ports-mgmt/portlint/Makefile
   1.99      +8 -2      ports/ports-mgmt/portlint/src/portlint.pl
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
