From nobody@FreeBSD.org  Tue Jun 24 02:21:38 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 309541065674
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 Jun 2008 02:21:38 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 1525C8FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 Jun 2008 02:21:38 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m5O2LbhJ087349
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 Jun 2008 02:21:37 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m5O2LbDb087348;
	Tue, 24 Jun 2008 02:21:37 GMT
	(envelope-from nobody)
Message-Id: <200806240221.m5O2LbDb087348@www.freebsd.org>
Date: Tue, 24 Jun 2008 02:21:37 GMT
From: "Pedro F. Giffuni" <pfgshield-freebsd@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: lang/yorick add maintainer mode
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: johans@stack.nl

>Number:         124918
>Category:       ports
>Synopsis:       lang/yorick add maintainer mode
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    johans
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 24 02:30:01 UTC 2008
>Closed-Date:    Thu Jun 26 12:29:04 UTC 2008
>Last-Modified:  Thu Jun 26 12:30:03 UTC 2008
>Originator:     Pedro F. Giffuni
>Release:        6.3-Release
>Organization:
>Environment:
FreeBSD kakumen.cable.net.co 6.3-RELEASE FreeBSD 6.3-RELEASE #10: Sat Jan 19 01:13:55 COT 2008     root@kakumen.cable.net.co:/usr/src/sys/amd64/compile/SMP  amd64
>Description:
I added a regression-test target for yorick, however, since it requires and X terminal to complete I hid it under the MAINTAINER_MODE.
>How-To-Repeat:

>Fix:
diff -ruN yorick.orig/Makefile yorick/Makefile
--- yorick.orig/Makefile	2008-06-23 21:07:31.000000000 -0500
+++ yorick/Makefile	2008-06-23 21:09:19.000000000 -0500
@@ -56,4 +56,10 @@
 	  ${INSTALL_DATA} $$f ${PREFIX}/${INFO_PATH}; \
 	done
 
+.ifdef MAINTAINER_MODE
+regression-test: build
+	(cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} check)
+
+.endif
+
 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->johans 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Jun 24 02:30:07 UTC 2008 
Responsible-Changed-Why:  
johans@stack.nl => johans@ (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124918 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Jun 24 02:30:12 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124918 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: johans@stack.nl
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/124918: lang/yorick add maintainer mode
Date: Tue, 24 Jun 2008 02:30:09 UT

 Maintainer of lang/yorick,
 
 Please note that PR ports/124918 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124918
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->closed 
State-Changed-By: johans 
State-Changed-When: Thu Jun 26 12:28:29 UTC 2008 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124918 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/124918: commit references a PR
Date: Thu, 26 Jun 2008 12:28:20 +0000 (UTC)

 johans      2008-06-26 12:28:08 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/yorick          Makefile 
   Log:
   Add optional regression tests
   
   PR:             ports/124918
   Submitted by:   Pedro F. Giffuni
   
   Revision  Changes    Path
   1.22      +6 -0      ports/lang/yorick/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
