From nobody@FreeBSD.org  Sat Jun 21 22:57:59 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 69E4F106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Jun 2008 22:57:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 631628FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Jun 2008 22:57:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m5LMvxGT058632
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Jun 2008 22:57:59 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m5LMvxx4058621;
	Sat, 21 Jun 2008 22:57:59 GMT
	(envelope-from nobody)
Message-Id: <200806212257.m5LMvxx4058621@www.freebsd.org>
Date: Sat, 21 Jun 2008 22:57:59 GMT
From: Peter Jeremy <peterjeremy@optushome.com.au>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Correctly note emacs-calc dependency/compatability info
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: andrewb@cs.cmu.edu

>Number:         124859
>Category:       ports
>Synopsis:       [patch] Correctly note math/emacs-calc dependency/compatability info
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rafan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 21 23:00:13 UTC 2008
>Closed-Date:    Sun Aug 31 07:33:17 UTC 2008
>Last-Modified:  Sun Aug 31 07:40:00 UTC 2008
>Originator:     Peter Jeremy
>Release:        7.0-STABLE
>Organization:
n/a
>Environment:
FreeBSD server.vk2pj.dyndns.org 7.0-STABLE FreeBSD 7.0-STABLE #18: Sun May 18 15:02:39 EST 2008     root@server.vk2pj.dyndns.org:/var/obj/k7/usr/src/sys/server  i386

>Description:
The functionality of emacs-calc has been integrated into emacs-22.  The upgrade of editors/emacs from emacs-21 to emacs-22 thereby "broke" emacs-calc because they both install common files.  Some investigation shows that it also conflicts with xemacs-packages for the same reason.

emacs-calc is still usable with older emacsen.

The attached patch changes emacs-calc to depend on emacs21 instead of emacs and
adds appropriate conflicts entries.

>How-To-Repeat:
cd /home/ports/math/emacs-calc && make
>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /usr/ncvs/ports/math/emacs-calc/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile	19 Jun 2008 02:54:51 -0000	1.7
+++ Makefile	21 Jun 2008 22:48:54 -0000
@@ -16,12 +16,10 @@
 MAINTAINER=	andrewb@cs.cmu.edu
 COMMENT=	Arbitrary-precision calculator for Emacs
 
-RUN_DEPENDS=	emacs:${PORTSDIR}/editors/emacs
-BUILD_DEPENDS=	emacs:${PORTSDIR}/editors/emacs
+RUN_DEPENDS=	emacs:${PORTSDIR}/editors/emacs21
+BUILD_DEPENDS=	emacs:${PORTSDIR}/editors/emacs21
 
-BROKEN=		Incorrect pkg-plist
-DEPRECATED=	Has been broken for more than 6 months
-EXPIRATION_DATE=2008-09-19
+CONFLICTS=	emacs-22.* xemacs-packages-\*
 
 INFO=		calc
 


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: lippe 
State-Changed-When: Sat Jun 21 23:23:12 UTC 2008 
State-Changed-Why:  
Ask for maintainer approval. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124859 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: andrewb@cs.cmu.edu
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/124859: [patch] Correctly note math/emacs-calc dependency/compatability info
Date: Sat, 21 Jun 2008 23:48:16 UT

 Maintainer of math/emacs-calc,
 
 Please note that PR ports/124859 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124859
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Andrew Bernard" <andrewb@cs.cmu.edu>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/124859: [patch] Correctly note math/emacs-calc dependency/compatability info
Date: Sun, 22 Jun 2008 20:51:47 -0400

 ------=_Part_18134_3983928.1214182307981
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Approved -- thanks!
 
 -andrew
 
 On Sun, Jun 22, 2008 at 2:48 AM, Edwin Groothuis <edwin@freebsd.org> wrote:
 
 > Maintainer of math/emacs-calc,
 >
 > Please note that PR ports/124859 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124859
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
 
 ------=_Part_18134_3983928.1214182307981
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Approved -- thanks!<br><br>-andrew<br><br><div class="gmail_quote">On Sun, Jun 22, 2008 at 2:48 AM, Edwin Groothuis &lt;<a href="mailto:edwin@freebsd.org">edwin@freebsd.org</a>&gt; wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
 Maintainer of math/emacs-calc,<br>
 <br>
 Please note that PR ports/124859 has just been submitted.<br>
 <br>
 If it contains a patch for an upgrade, an enhancement or a bug fix<br>
 you agree on, reply to this email stating that you approve the patch<br>
 and a committer will take care of it.<br>
 <br>
 The full text of the PR can be found at:<br>
  &nbsp; &nbsp;<a href="http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124859" target="_blank">http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124859</a><br>
 <font color="#888888"><br>
 --<br>
 Edwin Groothuis via the GNATS Auto Assign Tool<br>
 edwin@FreeBSD.org<br>
 </font></blockquote></div><br>
 
 ------=_Part_18134_3983928.1214182307981--
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Tue Jun 24 00:35:51 UTC 2008 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124859 
Responsible-Changed-From-To: freebsd-ports-bugs->rafan 
Responsible-Changed-By: rafan 
Responsible-Changed-When: Sun Aug 31 04:45:26 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124859 
State-Changed-From-To: open->closed 
State-Changed-By: rafan 
State-Changed-When: Sun Aug 31 07:33:16 UTC 2008 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124859 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/124859: commit references a PR
Date: Sun, 31 Aug 2008 07:33:20 +0000 (UTC)

 rafan       2008-08-31 07:33:11 UTC
 
   FreeBSD ports repository
 
   Modified files:
     math/emacs-calc      Makefile 
   Log:
   - Unbreak this port by using emacs 21 (this port is integrated into emacs22)
   - While I'm here, use bsd.emacs.mk instead of hard coding the dependency
   
   PR:             ports/124859
   Submitted by:   Peter Jeremy <peterjeremy at optushome.com.au>
   Approved by:    Andrew Bernard" <andrewb at cs.cmu.edu> (maintainer)
   
   Revision  Changes    Path
   1.8       +3 -5      ports/math/emacs-calc/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
