From nobody@FreeBSD.org  Sat Jun 21 04:39:45 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 61C67106568F
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Jun 2008 04:39:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 0EF188FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Jun 2008 04:39:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m5L4di6t037174
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Jun 2008 04:39:44 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m5L4ditC037173;
	Sat, 21 Jun 2008 04:39:44 GMT
	(envelope-from nobody)
Message-Id: <200806210439.m5L4ditC037173@www.freebsd.org>
Date: Sat, 21 Jun 2008 04:39:44 GMT
From: bf <bf2006a@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH]security/tor-devel: instrumented downloads option, regression-test target
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: peter.thoenen@yahoo.com

>Number:         124812
>Category:       ports
>Synopsis:       [PATCH]security/tor-devel: instrumented downloads option, regression-test target
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 21 04:40:01 UTC 2008
>Closed-Date:    Sat Jun 28 15:22:55 UTC 2008
>Last-Modified:  Sat Jun 28 15:22:55 UTC 2008
>Originator:     bf
>Release:        7-STABLE i386
>Organization:
-
>Environment:
>Description:
Allow for instrumented downloads option ( usage: http://archives.seul.org/or/dev/Jun-2008/msg00024.html ); change the name of the "check" target to "regression-test", following other recent changes in ports.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN tor-devel.orig/Makefile tor-devel/Makefile
--- tor-devel.orig/Makefile	2008-06-20 19:54:03.000000000 -0400
+++ tor-devel/Makefile	2008-06-21 00:29:25.257430875 -0400
@@ -7,6 +7,7 @@
 
 PORTNAME=	tor
 DISTVERSION=	0.2.1.1-alpha
+PORTREVISION=	1
 CATEGORIES=	security net
 MASTER_SITES=	http://www.torproject.org/dist/ \
 		http://tor.cypherpunks.at/dist/ \
@@ -29,6 +30,7 @@
 OPTIONS=	BUFFREELISTS "freelists for buffer RAM" on \
 		CELLPOOL "memory pool allocator for cells" on \
 		GEOIP "track country data" off \
+		INSTR_DOWNLOADS "instrument downloads for analysis" off \
 		TCMALLOC "use the tcmalloc memory allocation library" off \
 		THREADS "multi-threading support" on \
 		TRANSPARENT "transparent proxy support" on \
@@ -62,6 +64,12 @@
 CONFIGURE_ARGS+=	--disable-geoip-stats
 .endif
 
+.if defined(WITH_INSTR_DOWNLOADS)
+CONFIGURE_ARGS+=	--enable-instrument-downloads
+.else
+CONFIGURE_ARGS+=	--disable-instrument-downloads
+.endif
+
 .if defined(WITH_TCMALLOC)
 CONFIGURE_ARGS+=	--with-tcmalloc
 LIB_DEPENDS+=		tcmalloc:${PORTSDIR}/devel/google-perftools
@@ -113,7 +121,7 @@
 	${CHOWN} _tor:_tor /var/db/tor
 	${CAT} ${PKGMESSAGE}
 
-check:
+regression-test:
 	@( cd ${BUILD_WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE} \
 	${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} check )
 


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Jun 21 04:40:07 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124812 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: peter.thoenen@yahoo.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/124812: [PATCH]security/tor-devel: instrumented downloads option, regression-test target
Date: Sat, 21 Jun 2008 04:40:05 UT

 Maintainer of security/tor-devel,
 
 Please note that PR ports/124812 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124812
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Sat Jun 21 09:03:39 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124812 

From: bf <bf2006a@yahoo.com>
To: bug-followup@FreeBSD.org, peter.thoenen@yahoo.com
Cc:  
Subject: ports/124812: [PATCH]security/tor-devel: instrumented downloads option, regression-test target
Date: Sat, 21 Jun 2008 06:12:30 -0700 (PDT)

 --0-1953582847-1214053950=:96108
 Content-Type: text/plain; charset=iso-8859-1
 Content-Transfer-Encoding: 8bit
 Content-Id: 
 Content-Disposition: inline
 
 Please consider the following patch instead of the
 earlier one; in addition to making the changes in the
 first patch, the second patch also updates the port to
 0.2.1.2-alpha , which contains a number of bugfixes
 and enhancements.
 
 b.
 
 
 
       
 --0-1953582847-1214053950=:96108
 Content-Type: text/plain; name="tor-devel.txt"
 Content-Description: 1100987249-tor-devel.txt
 Content-Disposition: inline; filename="tor-devel.txt"
 
 diff -ruN tor-devel.orig/Makefile tor-devel/Makefile
 --- tor-devel.orig/Makefile	2008-06-20 19:54:03.000000000 -0400
 +++ tor-devel/Makefile	2008-06-21 08:44:17.226008724 -0400
 @@ -6,7 +6,7 @@
  #
  
  PORTNAME=	tor
 -DISTVERSION=	0.2.1.1-alpha
 +DISTVERSION=	0.2.1.2-alpha
  CATEGORIES=	security net
  MASTER_SITES=	http://www.torproject.org/dist/ \
  		http://tor.cypherpunks.at/dist/ \
 @@ -29,6 +29,7 @@
  OPTIONS=	BUFFREELISTS "freelists for buffer RAM" on \
  		CELLPOOL "memory pool allocator for cells" on \
  		GEOIP "track country data" off \
 +		INSTR_DOWNLOADS "instrument downloads for analysis" off \
  		TCMALLOC "use the tcmalloc memory allocation library" off \
  		THREADS "multi-threading support" on \
  		TRANSPARENT "transparent proxy support" on \
 @@ -62,6 +63,12 @@
  CONFIGURE_ARGS+=	--disable-geoip-stats
  .endif
  
 +.if defined(WITH_INSTR_DOWNLOADS)
 +CONFIGURE_ARGS+=	--enable-instrument-downloads
 +.else
 +CONFIGURE_ARGS+=	--disable-instrument-downloads
 +.endif
 +
  .if defined(WITH_TCMALLOC)
  CONFIGURE_ARGS+=	--with-tcmalloc
  LIB_DEPENDS+=		tcmalloc:${PORTSDIR}/devel/google-perftools
 @@ -113,7 +120,7 @@
  	${CHOWN} _tor:_tor /var/db/tor
  	${CAT} ${PKGMESSAGE}
  
 -check:
 +regression-test:
  	@( cd ${BUILD_WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE} \
  	${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} check )
  
 diff -ruN tor-devel.orig/distinfo tor-devel/distinfo
 --- tor-devel.orig/distinfo	2008-06-20 19:54:03.000000000 -0400
 +++ tor-devel/distinfo	2008-06-21 08:44:17.226008724 -0400
 @@ -1,3 +1,3 @@
 -MD5 (tor-0.2.1.1-alpha.tar.gz) = 3ff9c9c8e4787bb97a79cc99795c21ae
 -SHA256 (tor-0.2.1.1-alpha.tar.gz) = a1f8ed1b8666c77acd7d7f276b15c704f426165d8811d3dd406979bd940bc6df
 -SIZE (tor-0.2.1.1-alpha.tar.gz) = 2199099
 +MD5 (tor-0.2.1.2-alpha.tar.gz) = 122778603272fd3e53f6c2e7b6be4a81
 +SHA256 (tor-0.2.1.2-alpha.tar.gz) = a3bd84cdc332d57b4570c1f043e59498b454753f24202ebdf20456a33f3d0989
 +SIZE (tor-0.2.1.2-alpha.tar.gz) = 2191555
 
 --0-1953582847-1214053950=:96108--

From: Peter Thoenen <peter.thoenen@yahoo.com>
To: bug-followup@FreeBSD.org
Cc: bf <bf2006a@yahoo.com>
Subject: Re: ports/124812: [PATCH]security/tor-devel: instrumented downloads
 option, regression-test target
Date: Sat, 21 Jun 2008 15:40:19 -0400

 I don't have a box currently to test but this is approved as everything 
 looks good and BF always does a good job with his patches :)

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/124812: commit references a PR
Date: Sat, 28 Jun 2008 15:18:35 +0000 (UTC)

 miwi        2008-06-28 15:18:30 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/tor-devel   Makefile distinfo 
   Log:
   - Update to 0.2.1.2-alpha
   - Add regression-test
   
   PR:             124812
   Submitted by:   bf <bf2006a@yahoo.com>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.63      +9 -2      ports/security/tor-devel/Makefile
   1.46      +3 -3      ports/security/tor-devel/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: miwi 
State-Changed-When: Sat Jun 28 15:22:54 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124812 
>Unformatted:
