From gahr@FreeBSD.org  Thu Jun 19 10:58:00 2008
Return-Path: <gahr@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C3A60106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 19 Jun 2008 10:58:00 +0000 (UTC)
	(envelope-from gahr@FreeBSD.org)
Received: from cpanel03.rubas-s03.net (cpanel03.rubas-s03.net [195.182.222.73])
	by mx1.freebsd.org (Postfix) with ESMTP id 563098FC1B
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 19 Jun 2008 10:58:00 +0000 (UTC)
	(envelope-from gahr@FreeBSD.org)
Received: from [213.142.183.219] (helo=gahrtop.localhost)
	by cpanel03.rubas-s03.net with esmtpa (Exim 4.68)
	(envelope-from <gahr@FreeBSD.org>)
	id 1K9Hq0-00062D-3m
	for FreeBSD-gnats-submit@freebsd.org; Thu, 19 Jun 2008 12:57:56 +0200
Received: from gahrtop.localhost (localhost [127.0.0.1])
	by gahrtop.localhost (Postfix) with ESMTP id 6838C50841
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 19 Jun 2008 12:57:49 +0200 (CEST)
Message-Id: <1213873069.52717@gahrtop.localhost>
Date: Thu, 19 Jun 2008 12:57:49 +0200
From: "Pietro Cerutti" <gahr@FreeBSD.org>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: [patch] emulators/win4bsd IGNORE if scheduler is not 4BSD
X-Send-Pr-Version: gtk-send-pr 0.4.9 
X-GNATS-Notify: bacon@smithers.neuro.mcw.edu

>Number:         124755
>Category:       ports
>Synopsis:       [patch] emulators/win4bsd IGNORE if scheduler is not 4BSD
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gahr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 19 11:00:12 UTC 2008
>Closed-Date:    Thu Jun 19 13:59:47 UTC 2008
>Last-Modified:  Thu Jun 19 14:00:07 UTC 2008
>Originator:     Pietro Cerutti
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
The FreeBSD Project 
>Environment:


System: FreeBSD 8.0-CURRENT #0: Wed Jun 18 01:38:09 CEST 2008
    root@gahrtop.localhost:/usr/obj/usr/src/sys/MSI1034



>Description:


The kqemu module needed by win4bsd needs the 4BSD scheduler:

> cat /tmp/build-kqemu.log 

Source path       /usr/tmp/.build_kqemu-54331/kqemu
C compiler        gcc
Host C compiler   gcc
make              gmake
host CPU          i386
Warning: Object directory not changed from original /usr/tmp/.build_kqemu-54331/kqemu
@ -> /usr/src/sys
machine -> /usr/src/sys/i386/include
cc -O2 -pipe -march=prescott -fno-strict-aliasing -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -c kqemu-freebsd.c
kqemu-freebsd.c: In function 'kqemu_schedule':
kqemu-freebsd.c:211: error: 'sched_lock' undeclared (first use in this function)
kqemu-freebsd.c:211: error: (Each undeclared identifier is reported only once
kqemu-freebsd.c:211: error: for each function it appears in.)
*** Error code 1

Stop in /usr/tmp/.build_kqemu-54331/kqemu.



>How-To-Repeat:





>Fix:


--- win4bsd.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/emulators/win4bsd/Makefile,v
retrieving revision 1.5
diff -u -u -r1.5 Makefile
--- Makefile	6 Jun 2008 13:27:06 -0000	1.5
+++ Makefile	19 Jun 2008 10:52:44 -0000
@@ -34,13 +34,18 @@
 .include <bsd.port.pre.mk>
 
 .if ${OSVERSION} > 600000
-LIB_DEPENDS+=  c.5:${PORTSDIR}/misc/compat5x
+LIB_DEPENDS+=	c.5:${PORTSDIR}/misc/compat5x
 .endif
 
 .if !exists(/usr/src/sys/kern)
 IGNORE=		requires system source for installing kqemu, the accelerator that provides native CPU speed in Win4BSD.  Please install the system sources in /usr/src (e.g. using sysinstall), and run make again
 .endif
 
+SCHED_NAME!=	${SYSCTL} -n kern.sched.name
+.if ${SCHED_NAME} != "4BSD"
+IGNORE=		requires the traditional 4BSD scheduler. Please rebuild your kernel with options SCHED_4BSD, and run make again
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|/usr/local|${PREFIX}|' ${WRKSRC}/+POST-* \
 		${WRKSRC}/usr/local/lib/win4bsd/bin/postinstall.sh \
--- win4bsd.diff ends here ---



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gahr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Jun 19 11:00:20 UTC 2008 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124755 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jun 19 11:00:25 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124755 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: bacon@smithers.neuro.mcw.edu
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/124755: [patch] emulators/win4bsd IGNORE if scheduler is not 4BSD
Date: Thu, 19 Jun 2008 11:00:22 UT

 Maintainer of emulators/win4bsd,
 
 Please note that PR ports/124755 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124755
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Jason Bacon <jwbacon@tds.net>
To: bug-followup@FreeBSD.ORG
Cc: bacon@smithers.neuro.mcw.edu
Subject: Re: ports/124755: [patch] emulators/win4bsd IGNORE if scheduler is
 not 4BSD
Date: Thu, 19 Jun 2008 08:40:28 -0500

 Approved, thanks.
 
 Edwin Groothuis wrote:
 > Maintainer of emulators/win4bsd,
 >
 > Please note that PR ports/124755 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124755
 >
 >   
 
State-Changed-From-To: feedback->closed 
State-Changed-By: gahr 
State-Changed-When: Thu Jun 19 13:59:47 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124755 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/124755: commit references a PR
Date: Thu, 19 Jun 2008 13:59:36 +0000 (UTC)

 gahr        2008-06-19 13:59:27 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/win4bsd    Makefile 
   Log:
   - Mark as IGNORE if the scheduler is not 4BSD
   
   PR:             124755
   Submitted by:   yours truly
   Approved by:    maintainer (via private e-mail)
   
   Revision  Changes    Path
   1.6       +6 -1      ports/emulators/win4bsd/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
