From tobias.rehbein@web.de  Sat Jun 14 21:27:24 2008
Return-Path: <tobias.rehbein@web.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C8D4A106567A
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 14 Jun 2008 21:27:24 +0000 (UTC)
	(envelope-from tobias.rehbein@web.de)
Received: from fmmailgate01.web.de (fmmailgate01.web.de [217.72.192.221])
	by mx1.freebsd.org (Postfix) with ESMTP id 585688FC1B
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 14 Jun 2008 21:27:24 +0000 (UTC)
	(envelope-from tobias.rehbein@web.de)
Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172])
	by fmmailgate01.web.de (Postfix) with ESMTP id A1C67E3ABEF0
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 14 Jun 2008 23:27:17 +0200 (CEST)
Received: from [88.134.75.43] (helo=sushi.pseudo.local)
	by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256)
	(WEB.DE 4.109 #226)
	id 1K7dHJ-0001UG-00
	for FreeBSD-gnats-submit@freebsd.org; Sat, 14 Jun 2008 23:27:17 +0200
Received: from sushi.pseudo.local (localhost [127.0.0.1])
	by sushi.pseudo.local (8.14.2/8.14.2) with ESMTP id m5ELOeCX047437
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 14 Jun 2008 23:24:40 +0200 (CEST)
	(envelope-from tobi@sushi.pseudo.local)
Received: (from tobi@localhost)
	by sushi.pseudo.local (8.14.2/8.14.2/Submit) id m5ELOeYg047436;
	Sat, 14 Jun 2008 23:24:40 +0200 (CEST)
	(envelope-from tobi)
Message-Id: <200806142124.m5ELOeYg047436@sushi.pseudo.local>
Date: Sat, 14 Jun 2008 23:24:40 +0200 (CEST)
From: Tobias Rehbein <tobias.rehbein@web.de>
Sender: tobias.rehbein@web.de
Reply-To: Tobias Rehbein <tobias.rehbein@web.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] www/nanoblogger regression: wrong file modes
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         124594
>Category:       ports
>Synopsis:       [patch] www/nanoblogger regression: wrong file modes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jadawin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 14 21:30:06 UTC 2008
>Closed-Date:    Sun Jun 15 18:47:27 UTC 2008
>Last-Modified:  Sun Jun 15 18:50:04 UTC 2008
>Originator:     Tobias Rehbein
>Release:        FreeBSD 7.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD sushi.pseudo.local 7.0-STABLE FreeBSD 7.0-STABLE #8: Wed Jun 11 22:18:31 CEST 2008 tobi@sushi.pseudo.local:/usr/obj/usr/src/sys/SUSHI i386


	
>Description:
	My last submission regarding this port introduced a regression which went unnoticed. I introduced the usage of the COPYTREE_SHARE macro. This macro sets file modes which are not suitable for the default data directory which is used as the sekeleton for new blogs. The problem is that the files must be writable.

This means new users will not be able to create new working blogs. This went unnoticed as I tested in an existing blog. I just noticed this issue as I am currently working on the porting of nanoblogger 3.4 and test a broader variety of test cases.

>How-To-Repeat:
	Install www/nanoblogger and create a new blog. Writing entries for this blog will not be possible.
>Fix:
	Switch to the old behaviour for the default data directory. See attached patch.

Anyway it's not good to have writable files in /usr/share/nanoblogger. I will file a bug report upstream to change the file modes accordingly after copying the files into the actual blog directory.

--- patch.txt begins here ---
diff -ruN www/nanoblogger.orig/Makefile www/nanoblogger/Makefile
--- www/nanoblogger.orig/Makefile	2008-06-14 01:33:10.000000000 +0200
+++ www/nanoblogger/Makefile	2008-06-14 23:06:51.000000000 +0200
@@ -30,11 +30,13 @@
 	${INSTALL_SCRIPT} ${WRKSRC}/nb ${PREFIX}/bin
 	${INSTALL_DATA} ${WRKSRC}/nb.conf ${PREFIX}/etc/nb.conf.sample
 	${MKDIR} ${DATADIR}
-.for data in default lang lib moods plugins
+.for data in lang lib moods plugins
 	${MKDIR} ${DATADIR}/${data} && \
 		( cd ${WRKSRC}/${data} && \
 			${COPYTREE_SHARE} \* ${DATADIR}/${data} "! -name *.orig ! -name *.bak" )
 .endfor
+	${MKDIR} ${DATADIR}/default && \
+		${CP} -R ${WRKSRC}/default ${DATADIR}/
 	${CP} ${WRKSRC}/welcome-to-nb.txt ${DATADIR}
 
 post-install:
--- patch.txt ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jadawin 
Responsible-Changed-By: jadawin 
Responsible-Changed-When: Sun Jun 15 08:28:39 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124594 

From: Tobias Rehbein <tobias.rehbein@web.de>
To: bug-followup@freebsd.org
Cc:  
Subject: [FreeBSD-gnats-submit@freebsd.org: Re: ports/124594: [patch] www/nanoblogger regression: wrong file modes]
Date: Sun, 15 Jun 2008 13:01:15 +0200

 --opJtzjQTFsWo+cga
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Just for the report:
 
 Bug has been reported upstream, see http://sourceforge.net/tracker/index.php?func=detail&aid=1994340&group_id=103576&atid=635240
 
 --opJtzjQTFsWo+cga
 Content-Type: message/rfc822
 Content-Disposition: inline
 
 Received: from sushi.pseudo.local (localhost [127.0.0.1])
 	by sushi.pseudo.local (8.14.2/8.14.2) with ESMTP id m5FA7vhp001272
 	for <tobi@localhost>; Sun, 15 Jun 2008 12:07:57 +0200 (CEST)
 	(envelope-from gnats@freebsd.org)
 Received: from pop3.web.de [217.72.192.134]
 	by sushi.pseudo.local with POP3 (fetchmail-6.3.8)
 	for <tobi@localhost> (single-drop); Sun, 15 Jun 2008 12:07:57 +0200 (CEST)
 Received: from [69.147.83.53] (helo=mx2.freebsd.org)
 	by mx18.web.de with esmtp (WEB.DE 4.109 #226)
 	id 1K7dK9-0006rO-00
 	for tobias.rehbein@web.de; Sat, 14 Jun 2008 23:30:13 +0200
 Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
 	by mx2.freebsd.org (Postfix) with ESMTP id 74BAD1501B0
 	for <tobias.rehbein@web.de>; Sat, 14 Jun 2008 21:30:12 +0000 (UTC)
 	(envelope-from gnats@FreeBSD.org)
 Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
 	by hub.freebsd.org (Postfix) with ESMTP id 5D5C4106572F
 	for <tobias.rehbein@web.de>; Sat, 14 Jun 2008 21:30:07 +0000 (UTC)
 	(envelope-from gnats@FreeBSD.org)
 Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
 	by mx1.freebsd.org (Postfix) with ESMTP id 31CFE8FC1B
 	for <tobias.rehbein@web.de>; Sat, 14 Jun 2008 21:30:07 +0000 (UTC)
 	(envelope-from gnats@FreeBSD.org)
 Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
 	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5ELU7JU054252
 	for <tobias.rehbein@web.de>; Sat, 14 Jun 2008 21:30:07 GMT
 	(envelope-from gnats@freefall.freebsd.org)
 Received: (from gnats@localhost)
 	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5ELU6pJ054228;
 	Sat, 14 Jun 2008 21:30:06 GMT
 	(envelope-from gnats)
 Date: Sat, 14 Jun 2008 21:30:06 GMT
 Message-Id: <200806142130.m5ELU6pJ054228@freefall.freebsd.org>
 To: Tobias Rehbein <tobias.rehbein@web.de>
 From: FreeBSD-gnats-submit@freebsd.org
 Subject: Re: ports/124594: [patch] www/nanoblogger regression: wrong file modes
 Reply-To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@freebsd.org
 In-Reply-To: Your message of Sat, 14 Jun 2008 23:24:40 +0200 (CEST)
 	<200806142124.m5ELOeYg047436@sushi.pseudo.local>
 Sender: gnats@freebsd.org
 
 Thank you very much for your problem report.
 It has the internal identification `ports/124594'.
 The individual assigned to look at your
 report is: freebsd-ports-bugs. 
 
 You can access the state of your problem report at any time
 via this link:
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=124594
 
 >Category:       ports
 >Responsible:    freebsd-ports-bugs
 >Synopsis:       [patch] www/nanoblogger regression: wrong file modes
 >Arrival-Date:   Sat Jun 14 21:30:06 UTC 2008
 
 --opJtzjQTFsWo+cga--
State-Changed-From-To: open->closed 
State-Changed-By: jadawin 
State-Changed-When: Sun Jun 15 18:47:26 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124594 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/124594: commit references a PR
Date: Sun, 15 Jun 2008 18:47:15 +0000 (UTC)

 jadawin     2008-06-15 18:46:30 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/nanoblogger      Makefile 
   Log:
   - Fixing wrong file modes.
   
   PR:             ports/124594
   Submitted by:   Tobias Rehbein <tobias.rehbein web.de>
   Approved by:    mentor (implicit)
   
   Revision  Changes    Path
   1.12      +3 -1      ports/www/nanoblogger/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
