From j@uriah.heep.sax.de  Mon Jun  2 20:54:16 2008
Return-Path: <j@uriah.heep.sax.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2BD251065684
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  2 Jun 2008 20:54:16 +0000 (UTC)
	(envelope-from j@uriah.heep.sax.de)
Received: from uriah.heep.sax.de (uriah.heep.sax.de [213.240.137.9])
	by mx1.freebsd.org (Postfix) with ESMTP id DB5708FC19
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  2 Jun 2008 20:54:15 +0000 (UTC)
	(envelope-from j@uriah.heep.sax.de)
Received: by uriah.heep.sax.de (Postfix, from userid 107)
	id 05DE04A; Mon,  2 Jun 2008 22:37:20 +0200 (MET DST)
Message-Id: <20080602203721.05DE04A@uriah.heep.sax.de>
Date: Mon,  2 Jun 2008 22:37:20 +0200 (MET DST)
From: Joerg Wunsch <j@uriah.heep.sax.de>
Reply-To: Joerg Wunsch <j@uriah.heep.sax.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [amd64] X.org server runs in infinite loop
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         124220
>Category:       ports
>Synopsis:       x11-servers/xorg-server - X.org server runs in infinite loop on amd64
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-x11
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 02 21:00:05 UTC 2008
>Closed-Date:    Mon Mar 02 00:54:56 UTC 2009
>Last-Modified:  Mon Mar 02 00:54:56 UTC 2009
>Originator:     Joerg Wunsch
>Release:        FreeBSD 7.0-RELEASE amd64
>Organization:
>Environment:
FreeBSD dhcp203.local.heep.sax.de 7.0-STABLE FreeBSD 7.0-STABLE #0: Thu May 29 10:35:31 CEST 2008     root@dhcp203.local.heep.sax.de:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:

When specifiying the "PreferredMode" keyword in the monitor section of
xorg.conf, the server enters an infinite loop.

>How-To-Repeat:

Add
        Option      "PreferredMode" "1280x1024"
to xorg.conf.

>Fix:

The following patch has been obtained from Mandriva Linux, and
fixes the issue:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/x11-servers/xorg-server/Makefile,v
retrieving revision 1.59
diff -u -r1.59 Makefile
--- Makefile	29 May 2008 11:02:54 -0000	1.59
+++ Makefile	2 Jun 2008 20:05:03 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	xorg-server
 PORTVERSION=	1.4
-PORTREVISION=	9
+PORTREVISION=	10
 PORTEPOCH=	1
 CATEGORIES=	x11-servers
 MASTER_SITES=	http://xorg.freedesktop.org/releases/individual/xserver/:fdo \
Index: files/patch-Xserver-hw-xfree86-modes-xf86Crtc.c
===================================================================
RCS file: files/patch-Xserver-hw-xfree86-modes-xf86Crtc.c
diff -N files/patch-Xserver-hw-xfree86-modes-xf86Crtc.c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-Xserver-hw-xfree86-modes-xf86Crtc.c	2 Jun 2008 20:04:52 -0000
@@ -0,0 +1,27 @@
+From 69eced3fea70451645b407c4a5a0a25fed38e3fd Mon Sep 17 00:00:00 2001
+From: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
+Date: Mon, 28 Jan 2008 16:23:39 -0200
+Subject: [PATCH] Avoid an infinite loop at initialization if PreferredMode option is used and there is more than one mode with the given name.
+
+---
+ hw/xfree86/modes/xf86Crtc.c |    5 ++++-
+ 1 files changed, 4 insertions(+), 1 deletions(-)
+
+diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c
+index f75e9a4..191feb3 100644
+--- hw/xfree86/modes/xf86Crtc.c
++++ hw/xfree86/modes/xf86Crtc.c
+@@ -1410,8 +1410,11 @@ xf86ProbeOutputModes (ScrnInfoPtr scrn, int maxX, int maxY)
+ 
+ 	if (preferred_mode)
+ 	{
+-	    for (mode = output->probed_modes; mode; mode = mode->next)
++	    DisplayModePtr next;
++
++	    for (mode = output->probed_modes; mode; mode = next)
+ 	    {
++		next = mode->next;
+ 		if (!strcmp (preferred_mode, mode->name))
+ 		{
+ 		    if (mode != output->probed_modes)
+



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->x11 
Responsible-Changed-By: joerg 
Responsible-Changed-When: Mon Jun 2 23:26:16 MEST 2008 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124220 

From: Garrett Cooper <yanefbsd@gmail.com>
To: j@uriah.heep.sax.de, bug-followup@freebsd.org
Cc:  
Subject: Re: ports/124220: x11-servers/xorg-server - X.org server runs in 
	infinite loop on amd64
Date: Sun, 1 Mar 2009 12:23:58 -0800

 Hi Joerg,
      Could you tell us whether or not this issue still occurs with the
 latest Xorg?
 Thanks,
 -Garrett

From: Joerg Wunsch <j@uriah.heep.sax.de>
To: Garrett Cooper <yanefbsd@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/124220: x11-servers/xorg-server - X.org server runs in infinite loop on amd64
Date: Sun, 1 Mar 2009 21:28:25 +0100

 As Garrett Cooper wrote:
 
 >      Could you tell us whether or not this issue still occurs with
 > the latest Xorg?
 
 Sorry, I eventually decided against running that machine in amd64 mode
 then, so I don't have an amd64 machine around anymore to test.
 
 -- 
 cheers, J"org               .-.-.   --... ...--   -.. .  DL8DTL
 
 http://www.sax.de/~joerg/                        NIC: JW11-RIPE
 Never trust an operating system you don't have sources for. ;-)
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Mon Mar 2 00:53:47 UTC 2009 
State-Changed-Why:  
Submitter can no longer reproduce (not running amd64 mode).  There have 
been many updates to xorg components since then.  If someone else is 
experiencing this we can re-open. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124220 
>Unformatted:
