From nobody@FreeBSD.org  Thu May 29 07:06:42 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 92675106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 29 May 2008 07:06:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 8A08F8FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 29 May 2008 07:06:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m4T752tU019612
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 29 May 2008 07:05:02 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m4T752ET019611;
	Thu, 29 May 2008 07:05:02 GMT
	(envelope-from nobody)
Message-Id: <200805290705.m4T752ET019611@www.freebsd.org>
Date: Thu, 29 May 2008 07:05:02 GMT
From: "Scot W. Hetzel" <swhetzel@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] graphics/gnash and graphics/gnash-devel: Detects wrong libraries on FreeBSD/amd64
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: amdmi3@amdmi3.ru

>Number:         124091
>Category:       ports
>Synopsis:       [patch] graphics/gnash and graphics/gnash-devel: Detects wrong libraries on FreeBSD/amd64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 29 07:10:01 UTC 2008
>Closed-Date:    Sun Jun 01 20:51:57 UTC 2008
>Last-Modified:  Sun Jun  1 21:00:09 UTC 2008
>Originator:     Scot W. Hetzel
>Release:        8.0-CURRENT
>Organization:
>Environment:
FreeBSD hp010 8.0-CURRENT FreeBSD 8.0-CURRENT #4: Sat May 17 20:53:07 CDT 2008     root@hp010:/usr/obj/usr/src/8x/sys/DV8135NR  amd64

>Description:
While compiling the graphics/gnash port I noticed that during the configure phase it was reporting:

:
checking whether pthreads work with -pthread... yes^M
checking searching for pthread library... using -L/usr/lib32 -lpthread^M
:
        POSIX Threads flags are: -D_THREAD_SAFE -pthread^M
        POSIX Threads lib is: -L/usr/lib32 -lpthread^M
:
        Z flags are: default include path^M
        Z libs are: -L/usr/lib32 -lz ^M

Which causes the port to build with the wrong libraries.
>How-To-Repeat:
On FreeBSD/AMD64, install the  lib32 libraries, and then perform a make configure
>Fix:
Apply the attached patch

Patch attached with submission follows:

Index: gnash/Makefile
===================================================================
RCS file: /home/ncvs/ports/graphics/gnash/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- gnash/Makefile	24 May 2008 18:57:13 -0000	1.24
+++ gnash/Makefile	29 May 2008 06:43:12 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	gnash
 PORTVERSION=	0.8.2
+PORTREVISON=	1
 CATEGORIES=	graphics
 MASTER_SITES=	${MASTER_SITE_GNU}
 MASTER_SITE_SUBDIR=	${PORTNAME}/${PORTVERSION}
@@ -170,6 +171,7 @@
 		${WRKSRC}/utilities/Makefile.in ${WRKSRC}/cygnal/Makefile.in
 	@${REINPLACE_CMD} -e '/^PTHREAD_[LC][IF]*=/ d' ${WRKSRC}/configure
 	@${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g; \
+		s|/lib64|/lib|g; \
 		s|/usr/X11R6|${LOCALBASE}|g' ${WRKSRC}/configure \
 		${WRKSRC}/macros/libslist ${WRKSRC}/macros/incllist
 
Index: gnash-devel/Makefile
===================================================================
RCS file: /home/ncvs/ports/graphics/gnash-devel/Makefile,v
retrieving revision 1.25
diff -u -r1.25 Makefile
--- gnash-devel/Makefile	27 May 2008 09:16:24 -0000	1.25
+++ gnash-devel/Makefile	29 May 2008 06:42:38 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	gnash
 PORTVERSION=	0.8.2
+PORTREVISION=	1
 CATEGORIES=	graphics
 MASTER_SITES=	${MASTER_SITE_GNU}
 MASTER_SITE_SUBDIR=	${PORTNAME}/${PORTVERSION}
@@ -170,6 +171,7 @@
 		${WRKSRC}/utilities/Makefile.in ${WRKSRC}/cygnal/Makefile.in
 	@${REINPLACE_CMD} -e '/^PTHREAD_[LC][IF]*=/ d' ${WRKSRC}/configure
 	@${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g; \
+		s|/lib64|/lib|g; \
 		s|/usr/X11R6|${LOCALBASE}|g' ${WRKSRC}/configure \
 		${WRKSRC}/macros/libslist ${WRKSRC}/macros/incllist
 


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu May 29 07:10:07 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124091 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: amdmi3@amdmi3.ru
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/124091: [patch] graphics/gnash and graphics/gnash-devel: Detects wrong libraries on FreeBSD/amd64
Date: Thu, 29 May 2008 07:10:06 UT

 Maintainer of graphics/gnash,
 
 Please note that PR ports/124091 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124091
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/124091: [patch] graphics/gnash and graphics/gnash-devel:
	Detects wrong libraries on FreeBSD/amd64
Date: Thu, 29 May 2008 11:57:57 +0400

 * Edwin Groothuis (edwin@FreeBSD.org) wrote:
 
 > Please note that PR ports/124091 has just been submitted.
 Approved, thanks!
 
 -- 
 Dmitry A. Marakasov    | jabber: amdmi3@jabber.ru
 amdmi3@amdmi3.ru       | http://www.amdmi3.ru
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Thu May 29 09:38:57 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124091 
State-Changed-From-To: feedback->closed 
State-Changed-By: miwi 
State-Changed-When: Sun Jun 1 20:51:56 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124091 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/124091: commit references a PR
Date: Sun,  1 Jun 2008 20:51:52 +0000 (UTC)

 miwi        2008-06-01 20:51:44 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/gnash       Makefile 
   Log:
   - Fix wrong libraries path on amd64
   - Bump PORTREVISION
   
   PR:             124091
   Submitted by:   "Scot W. Hetzel" <swhetzel@gmail.com>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.25      +2 -0      ports/graphics/gnash/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
