From andrey.zverev@electro-com.ru  Sun May 18 10:55:39 2008
Return-Path: <andrey.zverev@electro-com.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D0399106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 18 May 2008 10:55:39 +0000 (UTC)
	(envelope-from andrey.zverev@electro-com.ru)
Received: from mail.electro-com.ru (mail.electro-com.ru [86.110.161.242])
	by mx1.freebsd.org (Postfix) with ESMTP id 909878FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 18 May 2008 10:55:39 +0000 (UTC)
	(envelope-from andrey.zverev@electro-com.ru)
Received: from az by mail.electro-com.ru with local (Exim 4.66 (FreeBSD))
	(envelope-from <andrey.zverev@electro-com.ru>)
	id 1JxgYE-000L8m-Gh
	for FreeBSD-gnats-submit@freebsd.org; Sun, 18 May 2008 14:55:38 +0400
Message-Id: <E1JxgYE-000L8m-Gh@mail.electro-com.ru>
Date: Sun, 18 May 2008 14:55:38 +0400
From: Andrej Zverev <andrey.zverev@electro-com.ru>
Sender: Andrej Zverev <andrey.zverev@electro-com.ru>
Reply-To: Andrej Zverev <andrey.zverev@electro-com.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] fixes for comms/smstools
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         123787
>Category:       ports
>Synopsis:       [PATCH] fixes for comms/smstools
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    itetcu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 18 11:00:06 UTC 2008
>Closed-Date:    Thu Jun 05 09:43:51 UTC 2008
>Last-Modified:  Thu Jun 05 09:44:25 UTC 2008
>Originator:     Andrej Zverev
>Release:        
>Organization:
>Environment:
System: FreeBSD mail.electro-com.ru 5.4-STABLE FreeBSD 5.4-STABLE #0: Tue Oct 11 20:28:18 MSD 2005 root@mxcorp.electro-com.ru:/usr/obj/usr/src/sys/mxcorp i386


	
>Description:
- Fix mastersite[1]
- Fix everytime clearing of config file[2]
- Fix expand of files/patch-src_smsd_cfg.c macros[3]
- BUMP portrevision

[1] - Mastersite has changed.
[2] - Every reinstall of software cause to overide smsd.conf file.
Better install smsd.conf.sample as std and add notice about it.
[3] - files/patch-src_smsd_cfg.c has intoduce of %%PREFIX%% macro, but
it's never expanded and binary file have %%PREFIX%%/etc/smsd.conf inside

	
>How-To-Repeat:
	
>Fix:

	

--- patch-smstools.diff begins here ---
Index: smstools/Makefile
===================================================================
RCS file: /home/pcvs/ports/comms/smstools/Makefile,v
retrieving revision 1.9
diff -u -r1.9 Makefile
--- smstools/Makefile	18 May 2008 09:27:59 -0000	1.9
+++ smstools/Makefile	18 May 2008 10:39:37 -0000
@@ -7,8 +7,9 @@
 
 PORTNAME=	smstools
 PORTVERSION=	2.2.20
+PORTREVISION=	1
 CATEGORIES=	comms
-MASTER_SITES=	http://www.meinemullemaus.de/smstools/packages/
+MASTER_SITES=	http://smstools.meinemullemaus.de/packages/
 
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Tools to handle Short Message Service
@@ -39,20 +40,20 @@
 		sms2unicode sms2xml smsevent smsresend sql_demo unicode2sms
 
 post-patch:
-	@${REINPLACE_CMD} 's|%%PREFIX%%|${PREFIX}|g' ${WRKSRC}/install.sh
+	@${REINPLACE_CMD} 's|%%PREFIX%%|${PREFIX}|g' ${WRKSRC}/install.sh \
+		${WRKSRC}/src/smsd_cfg.c
 
 post-install:
 .if !defined(NOPORTDOCS)
 	@${MKDIR} ${DOCSDIR}
 	@${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/doc/,} ${DOCSDIR}/
 .endif
+
 .if !defined(NOPORTEXAMPLES)
 	@${MKDIR} ${EXAMPLESDIR}
 	@${INSTALL_DATA} ${EXAMPLES:S,^,${WRKSRC}/examples/,} ${EXAMPLESDIR}/
 .endif
 	@${INSTALL_SCRIPT} ${SCRIPTS:S,^,${WRKSRC}/scripts/,} ${PREFIX}/bin
-
-#post-install:
-	@${INSTALL_DATA} ${WRKSRC}/examples/smsd.conf.easy ${PREFIX}/etc/smsd.conf
+	@${INSTALL_DATA} ${WRKSRC}/examples/smsd.conf.easy ${PREFIX}/etc/smsd.conf.sample
 
 .include <bsd.port.mk>
Index: smstools/pkg-plist
===================================================================
RCS file: /home/pcvs/ports/comms/smstools/pkg-plist,v
retrieving revision 1.6
diff -u -r1.6 pkg-plist
--- smstools/pkg-plist	22 Feb 2008 13:24:18 -0000	1.6
+++ smstools/pkg-plist	18 May 2008 10:39:37 -0000
@@ -12,7 +12,7 @@
 bin/smsresend
 bin/sql_demo
 bin/unicode2sms
-etc/smsd.conf
+etc/smsd.conf.sample
 %%PORTDOCS%%%%DOCSDIR%%/alarmhandler.html
 %%PORTDOCS%%%%DOCSDIR%%/blacklist.html
 %%PORTDOCS%%%%DOCSDIR%%/book.html
Index: smstools/files/patch-install.sh
===================================================================
RCS file: /home/pcvs/ports/comms/smstools/files/patch-install.sh,v
retrieving revision 1.3
diff -u -r1.3 patch-install.sh
--- smstools/files/patch-install.sh	22 Feb 2008 13:24:22 -0000	1.3
+++ smstools/files/patch-install.sh	18 May 2008 10:39:37 -0000
@@ -1,5 +1,5 @@
---- install.sh.old	2008-02-05 23:45:04.000000000 -0200
-+++ install.sh	2008-02-05 23:45:05.000000000 -0200
+--- install.sh.old	Thu Dec 27 19:14:44 2007
++++ install.sh	Sun May 18 14:26:44 2008
 @@ -2,7 +2,7 @@
  #Do not run directly. This is a helper script for make.
  
@@ -14,11 +14,11 @@
  
  echo "Installing config file"
 -copy examples/smsd.conf.easy /etc/smsd.conf
-+copy examples/smsd.conf.easy %%PREFIX%%/etc/smsd.conf
++#copy examples/smsd.conf.easy %%PREFIX%%/etc/smsd.conf
  
  echo "Creating minimum spool directories"
  makedir $SPOOLDIR
-@@ -76,15 +76,6 @@
+@@ -76,15 +76,7 @@
  makedir $SPOOLDIR/outgoing
  makedir $SPOOLDIR/checked
  
@@ -34,4 +34,5 @@
  echo ""
  echo "Example script files are not installed automatically."
 -echo 'Please dont forget to edit /etc/smsd.conf.'
-+echo 'Please dont forget to edit %%PREFIX%%/etc/smsd.conf.'
++echo 'Please dont forget to rename and edit  %%PREFIX%%/etc/smsd.conf.sample'
++echo 'to %%PREFIX%%/etc/smsd.conf'
--- patch-smstools.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->itetcu 
Responsible-Changed-By: itetcu 
Responsible-Changed-When: Mon May 19 19:04:19 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123787 
State-Changed-From-To: open->closed 
State-Changed-By: itetcu 
State-Changed-When: Thu Jun 5 09:43:50 UTC 2008 
State-Changed-Why:  
pav@ committed something similar

http://www.freebsd.org/cgi/query-pr.cgi?pr=123787 
>Unformatted:
