From carpetsmoker@rwxrwxrwx.net  Sat May 17 19:38:38 2008
Return-Path: <carpetsmoker@rwxrwxrwx.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 550631065674
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 May 2008 19:38:38 +0000 (UTC)
	(envelope-from carpetsmoker@rwxrwxrwx.net)
Received: from mail.rwxrwxrwx.net (rwxrwxrwx.net [82.93.23.199])
	by mx1.freebsd.org (Postfix) with ESMTP id A8DBB8FC22
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 May 2008 19:38:37 +0000 (UTC)
	(envelope-from carpetsmoker@rwxrwxrwx.net)
Received: from localhost (unknown [127.0.0.1])
	by mail.rwxrwxrwx.net (Postfix) with ESMTP id BD0D36D4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 May 2008 21:36:42 +0200 (CEST)
Received: from mail.rwxrwxrwx.net ([127.0.0.1])
	by localhost (mail.rwxrwxrwx.net [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id pTSrGSYSrSlJ for <FreeBSD-gnats-submit@freebsd.org>;
	Sat, 17 May 2008 21:36:39 +0200 (CEST)
Received: from phong.rwxrwxrwx.net (phong [192.168.100.13])
	by mail.rwxrwxrwx.net (Postfix) with SMTP id 465E96D4AA
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 May 2008 21:36:39 +0200 (CEST)
Received: by phong.rwxrwxrwx.net (sSMTP sendmail emulation); Sat, 17 May 2008 21:38:56 +0200
Message-Id: <20080517193639.465E96D4AA@mail.rwxrwxrwx.net>
Date: Sat, 17 May 2008 21:38:56 +0200
From: "Martin Tournoij" <carpetsmoker@rwxrwxrwx.net>
Reply-To: Martin Tournoij <carpetsmoker@xs4all.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [NEW PORT] graphics/geeqie  Lightweight image viewer forked from GQview
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         123770
>Category:       ports
>Synopsis:       [NEW PORT] graphics/geeqie  Lightweight image viewer forked from GQview
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    amdmi3
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 17 19:40:01 UTC 2008
>Closed-Date:    Thu Jun 26 11:03:48 UTC 2008
>Last-Modified:  Thu Jun 26 11:10:01 UTC 2008
>Originator:     Martin Tournoij
>Release:        FreeBSD 7.0-STABLE i386
>Organization:
>Environment:
FreeBSD phong.rwxrwxrwx.net 7.0-STABLE FreeBSD 7.0-STABLE #0: Fri Mar 21 20:18:47 CET 2008     carpetsmoker@phong.rwxrwxrwx.net:/usr/obj/usr/src/sys/PHONG  i386

>Description:

Geeqie is a lightweight Gtk+ based image viewer for Unix operating systems. 

Main features
  o EXIF, IPTC and XMP metadata browsing and editing.
  o Interoperability, easy integration with other software.
  o geeqie works on files and directories, there is no need to import images.
  o Fast preview for many raw image formats.
  o Tools for image comparison, sorting and managing photo collection.

History
  Geeqie has been forked from gqview project, because it was not possible to
  contact gqview author and the only maintainer. Geeqie projects goal is to move
  the development forward and also integrate the existing patches. 

Project Status
  Geeqie is currently in alpha state. Everybody is encouraged to try the new
  features, however for stable software look at the original project.

WWW: http://geeqie.sourceforge.net/

>How-To-Repeat:

>Fix:

--- geeqie.shar begins here ---
# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	Makefile
#	pkg-plist
#	pkg-descr
#	distinfo
#
echo x - Makefile
sed 's/^X//' >Makefile << 'END-of-Makefile'
X# New ports collection makefile for:	graphics/geeqie
X# Date created:				17 May 2008
X# Whom:					Martin Tournoij <carpetsmoker@xs4all.nl>
X#
X# $Carpetsmoker: ports/graphics/geeqie/Makefile,v 1.2 2008/05/17 19:35:22 carpetsmoker Exp $
X# $FreeBSD$
X#
X
XPORTNAME=	geeqie
XPORTVERSION=	1.0alpha1
XCATEGORIES=	graphics
XMASTER_SITES=	SF
X
XMAINTAINER=	carpetsmoker@xs4all.nl
XCOMMENT=	Lightweight image viewer forked from GQview
X
XLIB_DEPENDS=	png.5:${PORTSDIR}/graphics/png
X
XUSE_GNOME=	gtk20
XGNU_CONFIGURE=	yes
XCONFIGURE_ARGS=	--docdir="${DOCSDIR}" \
X		--htmldir="${DOCSDIR}/html" \
X		--with-htmldir="${DOCSDIR}/html" \
X		--with-readmedir="${DOCSDIR}"
XMAKE_ARGS+=	top_builddir="${WRKSRC}"
X
XMAN1=		geeqie.1
X
XOPTIONS=	EXIV2 "Enable EXIV2 for metadata editing" on \
X		LCMS "Enable LCMS for color adjusting" on
X
X.include <bsd.port.pre.mk>
X
X.if defined(WITH_EXIV2)
XLIB_DEPENDS+=	exiv2:${PORTSDIR}/graphics/exiv2
XCONFIGURE_ARGS+=--with-exiv2
X.else
XCONFIGURE_ARGS+=--without-exiv2
X.endif
X
X.if defined(WITH_LCMS)
XLIB_DEPENDS+=	lcms:${PORTSDIR}/graphics/lcms
XCONFIGURE_ARGS+=--with-lcms
X.else
XCONFIGURE_ARGS+=--without-lcms
X.endif
X
Xpost-patch:
X	@${REINPLACE_CMD} -e 's| -r %F||' \
X		${WRKSRC}/geeqie.desktop
X
X.include <bsd.port.post.mk>
END-of-Makefile
echo x - pkg-plist
sed 's/^X//' >pkg-plist << 'END-of-pkg-plist'
Xbin/geeqie
X%%DOCSDIR%%/html/gnu_fdl.txt
X%%DOCSDIR%%/html/gqview_faq.html
X%%DOCSDIR%%/html/index.html
X%%DOCSDIR%%/html/1_introduction.html
X%%DOCSDIR%%/html/2_main_window.html
X%%DOCSDIR%%/html/2_1_navigation.html
X%%DOCSDIR%%/html/2_2_menus.html
X%%DOCSDIR%%/html/2_3_layout.html
X%%DOCSDIR%%/html/2_4_file_pane.html
X%%DOCSDIR%%/html/2_5_folder_pane.html
X%%DOCSDIR%%/html/2_6_image_pane.html
X%%DOCSDIR%%/html/2_7_status_bar.html
X%%DOCSDIR%%/html/3_other_windows.html
X%%DOCSDIR%%/html/3_1_image_window.html
X%%DOCSDIR%%/html/3_2_image_properties.html
X%%DOCSDIR%%/html/4_image_management.html
X%%DOCSDIR%%/html/4_1_copy_move.html
X%%DOCSDIR%%/html/4_2_rename.html
X%%DOCSDIR%%/html/4_3_delete.html
X%%DOCSDIR%%/html/4_4_external_editing.html
X%%DOCSDIR%%/html/5_image_search.html
X%%DOCSDIR%%/html/5_1_search.html
X%%DOCSDIR%%/html/5_2_finding_duplicates.html
X%%DOCSDIR%%/html/6_collections.html
X%%DOCSDIR%%/html/7_sidebars.html
X%%DOCSDIR%%/html/7_1_exif.html
X%%DOCSDIR%%/html/7_2_sort_manager.html
X%%DOCSDIR%%/html/7_3_keywords.html
X%%DOCSDIR%%/html/8_image_presentation.html
X%%DOCSDIR%%/html/8_1_slideshow.html
X%%DOCSDIR%%/html/8_2_fullscreen.html
X%%DOCSDIR%%/html/9_printing.html
X%%DOCSDIR%%/html/10_options.html
X%%DOCSDIR%%/html/10_1_general.html
X%%DOCSDIR%%/html/10_2_image.html
X%%DOCSDIR%%/html/10_3_window.html
X%%DOCSDIR%%/html/10_4_filtering.html
X%%DOCSDIR%%/html/10_5_editor_commands.html
X%%DOCSDIR%%/html/10_6_advanced.html
X%%DOCSDIR%%/html/10_7_hidden.html
X%%DOCSDIR%%/html/11_reference.html
X%%DOCSDIR%%/html/11_1_command_line.html
X%%DOCSDIR%%/html/11_2_keyboard_shortcuts.html
X%%DOCSDIR%%/html/11_3_thumbnails.html
X%%DOCSDIR%%/html/11_4_management.html
X%%DOCSDIR%%/html/12_credits.html
X%%DOCSDIR%%/README
X%%DOCSDIR%%/COPYING
X%%DOCSDIR%%/ChangeLog
X%%DOCSDIR%%/TODO
Xshare/pixmaps/geeqie.png
Xshare/applications/geeqie.desktop
X@dirrm share/applications
X@dirrm %%DOCSDIR%%/html
X@dirrm %%DOCSDIR%%
END-of-pkg-plist
echo x - pkg-descr
sed 's/^X//' >pkg-descr << 'END-of-pkg-descr'
XGeeqie is a lightweight Gtk+ based image viewer for Unix operating systems. 
X
XMain features
X  o EXIF, IPTC and XMP metadata browsing and editing.
X  o Interoperability, easy integration with other software.
X  o geeqie works on files and directories, there is no need to import images.
X  o Fast preview for many raw image formats.
X  o Tools for image comparison, sorting and managing photo collection.
X
XHistory
X  Geeqie has been forked from gqview project, because it was not possible to
X  contact gqview author and the only maintainer. Geeqie projects goal is to move
X  the development forward and also integrate the existing patches. 
X
XProject Status
X  Geeqie is currently in alpha state. Everybody is encouraged to try the new
X  features, however for stable software look at the original project.
X
XWWW: http://geeqie.sourceforge.net/
END-of-pkg-descr
echo x - distinfo
sed 's/^X//' >distinfo << 'END-of-distinfo'
XMD5 (geeqie-1.0alpha1.tar.gz) = 8e4838018b597cb6df056959ccf1ba45
XSHA256 (geeqie-1.0alpha1.tar.gz) = 7df5b644e572ec0f8a489c31ccf01789d602c788cffa33bca5ecd236020ad199
XSIZE (geeqie-1.0alpha1.tar.gz) = 1970338
END-of-distinfo
exit
--- geeqie.shar ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: miwi 
State-Changed-When: Sun Jun 1 01:44:03 UTC 2008 
State-Changed-Why:  
Hi, 

You port don't respect NOPORTEXAMPLES and/or NOPORTDOCS.  Please fix it 
and submit a followup to this PR. Look at the Porters Handbook for 
instructions. 

- Martin 


http://www.freebsd.org/cgi/query-pr.cgi?pr=123770 
Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3 
Responsible-Changed-By: amdmi3 
Responsible-Changed-When: Tue Jun 24 12:01:54 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123770 

From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: bug-followup@FreeBSD.org, Martin Tournoij <carpetsmoker@xs4all.nl>
Cc:  
Subject: Re: ports/123770: [NEW PORT] graphics/geeqie Lightweight image
	viewer forked from GQview
Date: Tue, 24 Jun 2008 16:19:36 +0400

 * Martin Tournoij (carpetsmoker@rwxrwxrwx.net) wrote:
 
 > >Synopsis:       [NEW PORT] graphics/geeqie  Lightweight image viewer forked from GQview
 
 I've pathched the port for you to respect NOPORTDOCS (+ some other nits).
 Approve and I'll commit it.
 
 --- geeqie.patch begins here ---
 diff -ruN geeqie.orig/Makefile geeqie/Makefile
 --- geeqie.orig/Makefile	2008-06-24 16:01:08.000000000 +0400
 +++ geeqie/Makefile	2008-06-24 15:57:45.000000000 +0400
 @@ -7,7 +7,7 @@
  #
  
  PORTNAME=	geeqie
 -PORTVERSION=	1.0alpha1
 +DISTVERSION=	1.0alpha1
  CATEGORIES=	graphics
  MASTER_SITES=	SF
  
 @@ -24,6 +24,8 @@
  		--with-readmedir="${DOCSDIR}"
  MAKE_ARGS+=	top_builddir="${WRKSRC}"
  
 +PORTDOCS=	*
 +
  MAN1=		geeqie.1
  
  OPTIONS=	EXIV2 "Enable EXIV2 for metadata editing" on \
 @@ -32,14 +34,14 @@
  .include <bsd.port.pre.mk>
  
  .if defined(WITH_EXIV2)
 -LIB_DEPENDS+=	exiv2:${PORTSDIR}/graphics/exiv2
 +LIB_DEPENDS+=	exiv2.3:${PORTSDIR}/graphics/exiv2
  CONFIGURE_ARGS+=--with-exiv2
  .else
  CONFIGURE_ARGS+=--without-exiv2
  .endif
  
  .if defined(WITH_LCMS)
 -LIB_DEPENDS+=	lcms:${PORTSDIR}/graphics/lcms
 +LIB_DEPENDS+=	lcms.1:${PORTSDIR}/graphics/lcms
  CONFIGURE_ARGS+=--with-lcms
  .else
  CONFIGURE_ARGS+=--without-lcms
 @@ -48,5 +50,11 @@
  post-patch:
  	@${REINPLACE_CMD} -e 's| -r %F||' \
  		${WRKSRC}/geeqie.desktop
 +.if defined(NOPORTDOCS)
 +	@${REINPLACE_CMD} -e '/^install-data-am:/ s|install-helpDATA||' \
 +		${WRKSRC}/doc/Makefile.in
 +	@${REINPLACE_CMD} -e '/^install-data-am:/,/^[a-z]/ s|install-readmeDATA||' \
 +		${WRKSRC}/Makefile.in
 +.endif
  
  .include <bsd.port.post.mk>
 diff -ruN geeqie.orig/pkg-plist geeqie/pkg-plist
 --- geeqie.orig/pkg-plist	2008-06-24 16:01:08.000000000 +0400
 +++ geeqie/pkg-plist	2008-06-24 15:51:04.000000000 +0400
 @@ -1,56 +1,4 @@
  bin/geeqie
 -%%DOCSDIR%%/html/gnu_fdl.txt
 -%%DOCSDIR%%/html/gqview_faq.html
 -%%DOCSDIR%%/html/index.html
 -%%DOCSDIR%%/html/1_introduction.html
 -%%DOCSDIR%%/html/2_main_window.html
 -%%DOCSDIR%%/html/2_1_navigation.html
 -%%DOCSDIR%%/html/2_2_menus.html
 -%%DOCSDIR%%/html/2_3_layout.html
 -%%DOCSDIR%%/html/2_4_file_pane.html
 -%%DOCSDIR%%/html/2_5_folder_pane.html
 -%%DOCSDIR%%/html/2_6_image_pane.html
 -%%DOCSDIR%%/html/2_7_status_bar.html
 -%%DOCSDIR%%/html/3_other_windows.html
 -%%DOCSDIR%%/html/3_1_image_window.html
 -%%DOCSDIR%%/html/3_2_image_properties.html
 -%%DOCSDIR%%/html/4_image_management.html
 -%%DOCSDIR%%/html/4_1_copy_move.html
 -%%DOCSDIR%%/html/4_2_rename.html
 -%%DOCSDIR%%/html/4_3_delete.html
 -%%DOCSDIR%%/html/4_4_external_editing.html
 -%%DOCSDIR%%/html/5_image_search.html
 -%%DOCSDIR%%/html/5_1_search.html
 -%%DOCSDIR%%/html/5_2_finding_duplicates.html
 -%%DOCSDIR%%/html/6_collections.html
 -%%DOCSDIR%%/html/7_sidebars.html
 -%%DOCSDIR%%/html/7_1_exif.html
 -%%DOCSDIR%%/html/7_2_sort_manager.html
 -%%DOCSDIR%%/html/7_3_keywords.html
 -%%DOCSDIR%%/html/8_image_presentation.html
 -%%DOCSDIR%%/html/8_1_slideshow.html
 -%%DOCSDIR%%/html/8_2_fullscreen.html
 -%%DOCSDIR%%/html/9_printing.html
 -%%DOCSDIR%%/html/10_options.html
 -%%DOCSDIR%%/html/10_1_general.html
 -%%DOCSDIR%%/html/10_2_image.html
 -%%DOCSDIR%%/html/10_3_window.html
 -%%DOCSDIR%%/html/10_4_filtering.html
 -%%DOCSDIR%%/html/10_5_editor_commands.html
 -%%DOCSDIR%%/html/10_6_advanced.html
 -%%DOCSDIR%%/html/10_7_hidden.html
 -%%DOCSDIR%%/html/11_reference.html
 -%%DOCSDIR%%/html/11_1_command_line.html
 -%%DOCSDIR%%/html/11_2_keyboard_shortcuts.html
 -%%DOCSDIR%%/html/11_3_thumbnails.html
 -%%DOCSDIR%%/html/11_4_management.html
 -%%DOCSDIR%%/html/12_credits.html
 -%%DOCSDIR%%/README
 -%%DOCSDIR%%/COPYING
 -%%DOCSDIR%%/ChangeLog
 -%%DOCSDIR%%/TODO
  share/pixmaps/geeqie.png
  share/applications/geeqie.desktop
 -@dirrm share/applications
 -@dirrm %%DOCSDIR%%/html
 -@dirrm %%DOCSDIR%%
 +@dirrmtry share/applications
 --- geeqie.patch ends here ---
 
 -- 
 Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
 amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

From: Martin Tournoij <carpetsmoker@rwxrwxrwx.net>
To: Dmitry Marakasov <amdmi3@amdmi3.ru>
Cc: bug-followup@FreeBSD.org, Martin Tournoij <carpetsmoker@xs4all.nl>
Subject: Re: ports/123770: [NEW PORT] graphics/geeqie Lightweight image
	viewer forked from GQview
Date: Thu, 26 Jun 2008 05:04:29 +0200

 On Tue, Jun 24, 2008 at 04:19:36PM +0400, Dmitry Marakasov wrote:
 > * Martin Tournoij (carpetsmoker@rwxrwxrwx.net) wrote:
 > 
 > > >Synopsis:       [NEW PORT] graphics/geeqie  Lightweight image viewer forked from GQview
 > 
 > I've pathched the port for you to respect NOPORTDOCS (+ some other nits).
 > Approve and I'll commit it.
 > 
 > --- geeqie.patch begins here ---
 > [..snip..]
 > --- geeqie.patch ends here ---
 
 Hello Dmitry,
 
 I had some other stuff to do, a new port isn't exactly high priority
 IMO, which is why I hadn't looked in to this yet.
 
 Thank you for the patch, one small comment:
 I generally leave out library versions, in my experience it's not
 needed, and only causes addition port "updates" and unneeded "You need
 to upgrade libxyz" errors for users ... But this is just my
 preference...
 
 Other than this is seems fine so go ahead and commit it.
 
 A question:
 I was always under the impression that PORTDOCS was semi-optional.
 
 Some ports require large dependencies to build the documentation
 (docbook, doxygen, latex, etc), or it takes a very long time to build
 the docs, or the docs take up a lot of space, for these ports
 NOPORTDOCS makes sense.
 But for a port like this, where the documentation consistent only out
 of a few HTML files, very little is gained by using NOPORTDOCS, it
 doesn't matter in dependencies, it matters very little in build time,
 and the documentation only takes up very little space.
 
 So this is why I never bothered with NOPORTDOCS if implementing it is
 non-trivial.
 
 I have some other ports that do not implement NOPORTDCS either, and no
 commiter ever made a comment about it, has the policy been changed? Or
 have I just been "lucky"?
 
 -- 
 Martin Tournoij
 carpetsmoker@rwxrwxrwx.net
 http://www.daemonforums.org
 
 QOTD:
 Call on God, but row away from the rocks.
 		-- Indian proverb
State-Changed-From-To: feedback->closed 
State-Changed-By: amdmi3 
State-Changed-When: Thu Jun 26 11:03:47 UTC 2008 
State-Changed-Why:  
New port added, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123770 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/123770: commit references a PR
Date: Thu, 26 Jun 2008 11:01:36 +0000 (UTC)

 amdmi3      2008-06-26 11:01:22 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics             Makefile 
   Added files:
     graphics/geeqie      Makefile distinfo pkg-descr pkg-plist 
   Log:
   Geeqie is a lightweight Gtk+ based image viewer for Unix operating systems.
   
   Main features
     o EXIF, IPTC and XMP metadata browsing and editing.
     o Interoperability, easy integration with other software.
     o geeqie works on files and directories, there is no need to import images.
     o Fast preview for many raw image formats.
     o Tools for image comparison, sorting and managing photo collection.
   
   History
     Geeqie has been forked from gqview project, because it was not possible to
     contact gqview author and the only maintainer. Geeqie projects goal is to move
     the development forward and also integrate the existing patches.
   
   Project Status
     Geeqie is currently in alpha state. Everybody is encouraged to try the new
     features, however for stable software look at the original project.
   
   WWW: http://geeqie.sourceforge.net/
   
   PR:             ports/123770
   Submitted by:   Martin Tournoij <carpetsmoker at rwxrwxrwx dot net>
   Approved by:    miwi (mentor)
   
   Revision  Changes    Path
   1.1167    +1 -0      ports/graphics/Makefile
   1.1       +60 -0     ports/graphics/geeqie/Makefile (new)
   1.1       +3 -0      ports/graphics/geeqie/distinfo (new)
   1.1       +19 -0     ports/graphics/geeqie/pkg-descr (new)
   1.1       +4 -0      ports/graphics/geeqie/pkg-plist (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
 
