From nobody@FreeBSD.org  Mon May 12 11:23:28 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9B56E106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 May 2008 11:23:28 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 89EE78FC1E
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 May 2008 11:23:28 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m4CBMNEY042225
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 May 2008 11:22:23 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m4CBMNMf042224;
	Mon, 12 May 2008 11:22:23 GMT
	(envelope-from nobody)
Message-Id: <200805121122.m4CBMNMf042224@www.freebsd.org>
Date: Mon, 12 May 2008 11:22:23 GMT
From: Frank Fenor <frank@fenor.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Update: devel/tclxml-libxml2 - Install missing file and man-page
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         123607
>Category:       ports
>Synopsis:       Update: devel/tclxml-libxml2 - Install missing file and man-page
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 12 11:30:00 UTC 2008
>Closed-Date:    Sun Jun 29 02:08:37 UTC 2008
>Last-Modified:  Sun Jun 29 02:10:01 UTC 2008
>Originator:     Frank Fenor
>Release:        FreeBSD 7.0-PRERELEASE
>Organization:
>Environment:
>Description:
First fix: The upstream forgot to include the tcllibxml2Config.sh file into the installationprocess. Also, not all macros are filled in correctly, so we'll fix that too.

Second fix: The upstream provides a manpage, but does not offer any way to install it. So we'll do it ourself - if not asked otherwise.
>How-To-Repeat:

>Fix:
Apply patch.

Patch attached with submission follows:

diff -Nru /usr/ports/devel/tclxml-libxml2/Makefile /jails/test1/usr/ports/devel/tclxml-libxml2/Makefile
--- /usr/ports/devel/tclxml-libxml2/Makefile	2008-05-05 17:03:01.000000000 +0200
+++ /jails/test1/usr/ports/devel/tclxml-libxml2/Makefile	2008-05-12 01:31:16.000000000 +0200
@@ -5,6 +5,7 @@
 # $FreeBSD: ports/devel/tclxml-libxml2/Makefile,v 1.1 2008/05/05 15:03:01 beech Exp $
 #
 
+PORTREVISION=	1
 PKGNAMESUFFIX=	-libxml2
 
 MAINTAINER=	frank@fenor.de
@@ -18,4 +19,22 @@
 
 MASTERDIR=	${.CURDIR}/../tclxml
 
-.include	"${MASTERDIR}/Makefile"
\ No newline at end of file
+.if !defined(NOPORTDOCS)
+MANN=		tclxml.n
+.endif
+
+post-build:
+	${REINPLACE_CMD} -e 's|@tcldomxml_LIB_FILE@|libTclXML_libxml2${PORTVERSION}.so|' \
+	-e 's|@tclxml_libxml2_LIB_SPEC@|${LOCALBASE}/lib/TclXML_libxml2${PORTVERSION}/libTclXML_libxml2${PORTVERSION}.so|' \
+	-e 's|@tclxml_libxml2_stub_LIB_FILE@|libTclxmlstub${PORTVERSION}.a|' \
+	-e 's|@tclxml_libxml2_STUB_LIB_SPEC@|${LOCALBASE}/lib/Tclxml${PORTVERSION}/libTclxmlstub${PORTVERSION}.a|' \
+	-e 's|@tclxml_libxml2_STUB_LIB_PATH@|${LOCALBASE}/lib/TclXML_libxml2${PORTVERSION}|' \
+	${WRKSRC}/tcllibxml2Config.sh
+
+post-install:
+	${INSTALL_SCRIPT} ${WRKSRC}/tcllibxml2Config.sh ${LOCALBASE}/lib
+.if !defined(NOPORTDOCS)
+	${INSTALL_MAN} ${WRKSRC}/../doc/tclxml.n ${MANPREFIX}/man/mann
+.endif
+
+.include	"${MASTERDIR}/Makefile"
diff -Nru /usr/ports/devel/tclxml-libxml2/files/patch-doc-tclxml.n /jails/test1/usr/ports/devel/tclxml-libxml2/files/patch-doc-tclxml.n
--- /usr/ports/devel/tclxml-libxml2/files/patch-doc-tclxml.n	1970-01-01 01:00:00.000000000 +0100
+++ /jails/test1/usr/ports/devel/tclxml-libxml2/files/patch-doc-tclxml.n	2008-05-12 02:17:49.000000000 +0200
@@ -0,0 +1,24 @@
+--- ../doc/tclxml.n.orig	2008-05-12 01:26:34.000000000 +0200
++++ ../doc/tclxml.n	2008-05-12 01:26:50.000000000 +0200
+@@ -5,14 +5,14 @@
+ '\" Copyright (c) 2004 Zveno Pty Ltd
+ '\" http://www.zveno.com/
+ '\"
+-Zveno makes this software and all associated data and documentation
+-('Software') available free of charge for any purpose.  Copies may be made
+-of this Software but all of this notice must be included on any copy.
++'\" Zveno makes this software and all associated data and documentation
++'\" ('Software') available free of charge for any purpose.  Copies may be made
++'\" of this Software but all of this notice must be included on any copy.
+ '\"
+-The Software was developed for research purposes and Zveno does not
+-warrant that it is error free or fit for any purpose.  Zveno disclaims any
+-liability for all claims, expenses, losses, damages and costs any user may
+-incur as a result of using, copying or modifying the Software.
++'\" The Software was developed for research purposes and Zveno does not
++'\" warrant that it is error free or fit for any purpose.  Zveno disclaims any
++'\" liability for all claims, expenses, losses, damages and costs any user may
++'\" incur as a result of using, copying or modifying the Software.
+ '\"
+ '\"
+ '\" RCS: @(#) $Id: nroff.xsl,v 1.3 2003/12/03 20:06:33 balls Exp $
diff -Nru /usr/ports/devel/tclxml-libxml2/pkg-plist /jails/test1/usr/ports/devel/tclxml-libxml2/pkg-plist
--- /usr/ports/devel/tclxml-libxml2/pkg-plist	2008-05-05 17:03:02.000000000 +0200
+++ /jails/test1/usr/ports/devel/tclxml-libxml2/pkg-plist	2008-05-12 00:19:31.000000000 +0200
@@ -3,5 +3,6 @@
 include/tclxml-libxml2/tclxml-libxml2Decls.h
 lib/TclXML_libxml2%%VER%%/libTclXML_libxml2%%VER%%.so
 lib/TclXML_libxml2%%VER%%/pkgIndex.tcl
+lib/tcllibxml2Config.sh
 @dirrm lib/TclXML_libxml2%%VER%%
-@dirrm include/tclxml-libxml2
\ No newline at end of file
+@dirrm include/tclxml-libxml2


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon May 12 11:30:05 UTC 2008 
Responsible-Changed-Why:  
beech@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123607 
State-Changed-From-To: open->closed 
State-Changed-By: beech 
State-Changed-When: Sun Jun 29 02:08:23 UTC 2008 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123607 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/123607: commit references a PR
Date: Sun, 29 Jun 2008 02:07:54 +0000 (UTC)

 beech       2008-06-29 02:07:49 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/tclxml-libxml2 Makefile pkg-plist 
   Log:
   - The upstream forgot to include the tcllibxml2Config.sh file into the installationprocess.
   - Also, not all macros are filled in correctly, so we'll fix that too.
   
   PR:             ports/123607
   Submitted by:   Frank Fenor <frank@fenor.de> (maintainer)
   
   Revision  Changes    Path
   1.2       +15 -1     ports/devel/tclxml-libxml2/Makefile
   1.2       +2 -1      ports/devel/tclxml-libxml2/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
