From nobody@FreeBSD.org  Thu Apr 24 18:05:02 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 76B0F106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Apr 2008 18:05:02 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 7CA298FC1E
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Apr 2008 18:05:02 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m3OI4Ytc030423
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Apr 2008 18:04:34 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m3OI4YsH030422;
	Thu, 24 Apr 2008 18:04:34 GMT
	(envelope-from nobody)
Message-Id: <200804241804.m3OI4YsH030422@www.freebsd.org>
Date: Thu, 24 Apr 2008 18:04:34 GMT
From: Ganael Laplanche <ganael.laplanche@martymac.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Port fix: multimedia/gxmms - Fix compilation
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: radek@raadradd.com

>Number:         123057
>Category:       ports
>Synopsis:       Port fix: multimedia/gxmms - Fix compilation
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 24 18:10:01 UTC 2008
>Closed-Date:    Mon Apr 28 17:20:38 UTC 2008
>Last-Modified:  Mon Apr 28 17:30:01 UTC 2008
>Originator:     Ganael Laplanche
>Release:        7.0-STABLE
>Organization:
http://contribs.martymac.com
>Environment:
FreeBSD home.martymac.com 7.0-STABLE FreeBSD 7.0-STABLE #14: Sun Apr 20 14:11:03 CEST 2008     root@home.martymac.com:/usr/obj/usr/src/sys/MYKERNEL  amd64
>Description:
This patch includes the following :

- fixes compilation
- removes the BROKEN flag
- adds a missing dependency on GETTEXT
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -aurN gxmms.orig/Makefile gxmms/Makefile
--- gxmms.orig/Makefile	2008-03-24 18:02:20.000000000 +0100
+++ gxmms/Makefile	2008-04-24 19:56:00.005755242 +0200
@@ -18,10 +18,9 @@
 BUILD_DEPENDS=	xmms:${PORTSDIR}/multimedia/xmms
 RUN_DEPENDS=	xmms:${PORTSDIR}/multimedia/xmms
 
-BROKEN=		Does not compile
-
 USE_GMAKE=	yes
 USE_GNOME=	gnomehack gnomepanel gnomeprefix intlhack
+USE_GETTEXT=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
 		LDFLAGS="-L${LOCALBASE}/lib"
diff -aurN gxmms.orig/files/patch-src-interface.c gxmms/files/patch-src-interface.c
--- gxmms.orig/files/patch-src-interface.c	1970-01-01 01:00:00.000000000 +0100
+++ gxmms/files/patch-src-interface.c	2008-04-24 15:31:54.000000000 +0200
@@ -0,0 +1,11 @@
+--- src/interface.c.orig	2008-04-24 15:30:43.000000000 +0200
++++ src/interface.c	2008-04-24 15:31:31.000000000 +0200
+@@ -224,7 +224,7 @@
+     gdouble width;
+     GtkWidget *progress;
+     BonoboUIComponent *popup;
+-    gchar info[256] = _("No track");
++    gchar info[256] = "No track";
+ 
+     progress = xmms->track_control.progress;
+     if (!xmms_remote_is_running(xmms->session))
diff -aurN gxmms.orig/files/patch-src-xmmsctrl.c gxmms/files/patch-src-xmmsctrl.c
--- gxmms.orig/files/patch-src-xmmsctrl.c	2004-11-04 14:56:44.000000000 +0100
+++ gxmms/files/patch-src-xmmsctrl.c	2008-04-24 15:37:52.000000000 +0200
@@ -1,7 +1,11 @@
---- src/xmmsctrl.c.orig	Fri Sep  3 00:19:54 2004
-+++ src/xmmsctrl.c	Thu Nov  4 14:36:56 2004
-@@ -48,13 +48,14 @@
-     static gchar *msg_error = _("Sorry, unable to launch XMMS.");
+--- src/xmmsctrl.c.orig	2004-09-03 00:19:54.000000000 +0200
++++ src/xmmsctrl.c	2008-04-24 15:36:57.000000000 +0200
+@@ -45,16 +45,17 @@
+ xmms_start(XMMSData *xmms)
+ {
+     static gchar *exec_cmd = "xmms";
+-    static gchar *msg_error = _("Sorry, unable to launch XMMS.");
++    gchar *msg_error = _("Sorry, unable to launch XMMS.");
      gint timer;
      time_t lt;
 +    gchar *exec_this;


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Apr 24 18:10:07 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123057 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: radek@raadradd.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/123057: Port fix: multimedia/gxmms - Fix compilation
Date: Thu, 24 Apr 2008 18:10:04 UT

 Maintainer of multimedia/gxmms,
 
 Please note that PR ports/123057 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/123057
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: =?UTF-8?Q?Rados=C5=82aw_Koz=C5=82owski?= <radek@raadradd.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/123057: Port fix: multimedia/gxmms - Fix compilation
Date: Thu, 24 Apr 2008 22:02:53 +0200

 On Apr 24, 2008, at 8:10 PM, Edwin Groothuis wrote:
 
 > Maintainer of multimedia/gxmms,
 >
 > Please note that PR ports/123057 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/123057
 
 Approved.
 
 Radek
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Thu Apr 24 21:04:09 UTC 2008 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123057 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Mon Apr 28 17:20:37 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123057 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/123057: commit references a PR
Date: Mon, 28 Apr 2008 17:20:38 +0000 (UTC)

 miwi        2008-04-28 17:20:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     multimedia/gxmms     Makefile 
     multimedia/gxmms/files patch-src-xmmsctrl.c 
   Added files:
     multimedia/gxmms/files patch-src-interface.c 
   Log:
   - Fix build
   
   PR:             123057
   Submitted by:   Ganael Laplanche <ganael.laplanche@martymac.com>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.12      +1 -2      ports/multimedia/gxmms/Makefile
   1.1       +11 -0     ports/multimedia/gxmms/files/patch-src-interface.c (new)
   1.2       +8 -4      ports/multimedia/gxmms/files/patch-src-xmmsctrl.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
