From nobody@FreeBSD.org  Thu Apr 17 16:00:55 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 086E1106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 17 Apr 2008 16:00:55 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id F305C8FC20
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 17 Apr 2008 16:00:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m3HG0gZw013469
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 17 Apr 2008 16:00:42 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m3HG0g3R013468;
	Thu, 17 Apr 2008 16:00:42 GMT
	(envelope-from nobody)
Message-Id: <200804171600.m3HG0g3R013468@www.freebsd.org>
Date: Thu, 17 Apr 2008 16:00:42 GMT
From: Roger Marquis <marquis@roble.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: proftpd port fails to check inted.conf before adding an rc script
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         122859
>Category:       ports
>Synopsis:       ftp/proftpd port fails to check inted.conf before adding an rc script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 17 16:10:02 UTC 2008
>Closed-Date:    Fri Apr 18 02:27:51 UTC 2008
>Last-Modified:  Fri Apr 18 03:30:01 UTC 2008
>Originator:     Roger Marquis
>Release:        6.2-RELEASE
>Organization:
>Environment:
6.2-RELEASE amd64
>Description:
The proftpd port has a great list of options but "start at boot" is not one of them.  Ideally the Makefile would allow the user to choose between traditional (inetd) and heavily used (rc script) modes.  At least it should check /etc/inetd.conf (and /etc/rc.conf for inetd) before installing an rc script.  Either that or add "start at boot" to the options list.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Apr 17 23:02:28 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122859 

From: Beech Rintoul <beech@freebsd.org>
To: bug-followup@FreeBSD.org
Cc: Roger Marquis <marquis@roble.com>
Subject: ports/122859: ftp/proftpd port fails to check inted.conf before adding an rc script
Date: Thu, 17 Apr 2008 18:18:55 -0800

 Thank you for your suggestion. Many ports (including base) install rc 
 scripts. However you still have to activate them in /etc/rc.conf to 
 use them. You have to manually configure proftpd to run from inetd 
 and the presence of an rc script doesn't interfere unless you also 
 have proftpd_enable= "yes" set. Also, updating will not overwrite 
 your configs. You also can just delete the script if you're using 
 inetd. What your suggesting, while sounding easy would require far 
 more code than is in one rc script. It simply isn't possible to add 
 every option that a user might want, which is why there is ample 
 documentation for custom installs.
 
 Cheers,
 
 Beech
 -- 
 ---------------------------------------------------------------------------------------
 Beech Rintoul - FreeBSD Developer - beech@FreeBSD.org
 /"\   ASCII Ribbon Campaign  | FreeBSD Since 4.x
 \ / - NO HTML/RTF in e-mail   | http://www.freebsd.org
  X  - NO Word docs in e-mail | Latest Release:
 / \  - http://www.FreeBSD.org/releases/7.0R/announce.html
 ---------------------------------------------------------------------------------------
 
 
 
State-Changed-From-To: open->closed 
State-Changed-By: beech 
State-Changed-When: Fri Apr 18 02:27:28 UTC 2008 
State-Changed-Why:  
Not a bug 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122859 

From: Roger Marquis <marquis@roble.com>
To: bug-followup@FreeBSD.org
Cc: beech@FreeBSD.org
Subject: Re: ports/122859: ftp/proftpd port fails to check inted.conf before
 adding an rc script
Date: Thu, 17 Apr 2008 20:26:16 -0700 (PDT)

 Good points Beech, but I'm not sure I agree about the amount of code.
 Wouldn't it just be a matter of:
 
   if [ "`egrep -i '^proftpd_enable.*Y' /etc/rc.conf`" != "" ]; then
     install -m 750 proftpd.sh ${PREFIX}/etc/rc.d/
   fi
 
 Roger
>Unformatted:
