From nobody@FreeBSD.org  Sun Apr 13 20:31:03 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8E541106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Apr 2008 20:31:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 7B6268FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Apr 2008 20:31:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m3DKUwhG027663
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 13 Apr 2008 20:30:58 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m3DKUwhd027662;
	Sun, 13 Apr 2008 20:30:58 GMT
	(envelope-from nobody)
Message-Id: <200804132030.m3DKUwhd027662@www.freebsd.org>
Date: Sun, 13 Apr 2008 20:30:58 GMT
From: Skalozubov Ilia <root@skinc.su>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Port mail/postfixadmin - incorrect syntax in mysqli_real_escape_string function
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: ports.maintainer@evilphi.com

>Number:         122735
>Category:       ports
>Synopsis:       [patch] Port mail/postfixadmin - incorrect syntax in mysqli_real_escape_string function
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 13 20:40:00 UTC 2008
>Closed-Date:    Sat May 17 13:21:38 UTC 2008
>Last-Modified:  Sat May 17 13:30:01 UTC 2008
>Originator:     Skalozubov Ilia
>Release:        
>Organization:
>Environment:
>Description:
Incorrect syntax of function mysqli_real_escape_string in functions.inc.php
This error occurs when option 'magic_quotes_gpc' disabled in php config and postfixadmin used own functions to quoting strings.
>How-To-Repeat:
Install postfixadmin with mysqli support.
Disable 'magic_quotes_gpc' in php config.
Open http://URL_TO_POSTFIXADMIN/admin/create-domain.php
When press button to create new domain, you'll get error messages.
>Fix:


Patch attached with submission follows:

--- functions.inc.php	2008-04-13 22:09:18.000000000 +0300
+++ functions.inc.php	2008-04-13 22:09:32.000000000 +0300
@@ -129,7 +129,12 @@
    if (get_magic_quotes_gpc () == 0)
    {
       if ($CONF['database_type'] == "mysql")  $escaped_string = mysql_real_escape_string ($string);
-      if ($CONF['database_type'] == "mysqli")  $escaped_string = mysqli_real_escape_string ($string);
+      if ($CONF['database_type'] == "mysqli")
+      {
+         $link = db_connect ();
+         $escaped_string = mysqli_real_escape_string ($link, $string);
+         mysqli_close ($link);
+      }
       if ($CONF['database_type'] == "pgsql")  $escaped_string = pg_escape_string ($string);
    }
    else


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Apr 13 20:40:12 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122735 
State-Changed-From-To: feedback->closed 
State-Changed-By: rafan 
State-Changed-When: Sat May 17 13:21:33 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122735 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/122735: commit references a PR
Date: Sat, 17 May 2008 13:21:39 +0000 (UTC)

 rafan       2008-05-17 13:21:31 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/postfixadmin    Makefile 
   Added files:
     mail/postfixadmin/files patch-functions.inc.php 
   Log:
   - Fix mysqli_real_escape_string syntax
   - Bump PORTREVISION
   
   PR:             ports/122735
   Submitted by:   Skalozubov Ilia <root at skinc.su>
   Approved by:    maintainer timeout (1 month)
   
   Revision  Changes    Path
   1.27      +1 -1      ports/mail/postfixadmin/Makefile
   1.1       +16 -0     ports/mail/postfixadmin/files/patch-functions.inc.php (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
