From hmo@sep.oldach.net  Sun Apr 13 10:25:07 2008
Return-Path: <hmo@sep.oldach.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A009B106564A;
	Sun, 13 Apr 2008 10:25:07 +0000 (UTC)
	(envelope-from hmo@sep.oldach.net)
Received: from rigel.oldach.net (rigel.oldach.net [194.8.96.250])
	by mx1.freebsd.org (Postfix) with ESMTP id 2C7A78FC1C;
	Sun, 13 Apr 2008 10:25:06 +0000 (UTC)
	(envelope-from hmo@sep.oldach.net)
Received: from sep.oldach.net (hmo.in-dsl.de [217.197.85.210])
	by rigel.oldach.net (8.14.2/8.14.2/hmo30jul04) with ESMTP id m3D9ugLw042946
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Sun, 13 Apr 2008 11:56:43 +0200 (CEST)
	(envelope-from hmo@sep.oldach.net)
Received: from sep.oldach.net (localhost [127.0.0.1])
	by sep.oldach.net (8.14.2/8.14.2/hmo26jun05) with ESMTP id m3D9ufv4004147
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sun, 13 Apr 2008 11:56:41 +0200 (CEST)
	(envelope-from hmo@sep.oldach.net)
Received: (from root@localhost)
	by sep.oldach.net (8.14.2/8.14.2/Submit/hmo26jun05) id m3D9ueoU004146;
	Sun, 13 Apr 2008 11:56:40 +0200 (CEST)
	(envelope-from hmo)
Message-Id: <200804130956.m3D9ueoU004146@sep.oldach.net>
Date: Sun, 13 Apr 2008 11:56:40 +0200 (CEST)
From: ports-net-vnc-apr08@oldach.net (Helge Oldach)
Reply-To: ports-net-vnc-apr08@sep.oldach.net (Helge Oldach)
To: FreeBSD-gnats-submit@freebsd.org
Cc: james@now.ie, anders@freebsd.org
Subject: [patch] ports/net/vnc build failure WITHOUT_SERVER
X-Send-Pr-Version: 3.113
X-GNATS-Notify: james@now.ie

>Number:         122714
>Category:       ports
>Synopsis:       [patch] ports/net/vnc build failure WITHOUT_SERVER
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    anders
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 13 10:30:01 UTC 2008
>Closed-Date:    Tue Apr 15 22:25:27 UTC 2008
>Last-Modified:  Tue Apr 15 22:30:01 UTC 2008
>Originator:     Helge Oldach
>Release:        FreeBSD 6.3-1189 i386
>Organization:
>Environment:

System: FreeBSD localhost 6.3-1189 FreeBSD 6.3-1189 #0: Fri Apr 11 11:53:41 CEST 2008 toor@localhost:/usr/obj/usr/src/sys/HMO i386

>Description:

ports/net/vnc does not patch properly when WITHOUT_SERVER is enabled:

# make -DPATCH_DEBUG
===>  Vulnerability check disabled, database not found
===>  Found saved configuration for vnc-4.1.2_2
===>  Extracting for vnc-4.1.2_2
=> MD5 Checksum OK for xc/vnc-4_1_2-unixsrc.tar.gz.
=> SHA256 Checksum OK for xc/vnc-4_1_2-unixsrc.tar.gz.
===>  Patching for vnc-4.1.2_2
===>  Applying FreeBSD patches for vnc-4.1.2_2
===>   Applying FreeBSD patch /usr/ports/net/vnc/files/patch-xc-config-util-printver.c
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- xc/config/util/printver.c.orig     2003-02-26 10:21:33.000000000 +0100
|+++ xc/config/util/printver.c  2008-03-16 10:07:56.000000000 +0100
--------------------------
File to patch:

The reason is that all files following the ${PATCHDIR}/patch*
naming scheme are applied automatically and unconditionally.
This includes files/patch-xc-config-util-printver.c which is only
applicable for WITH_SERVER builds.

>How-To-Repeat:

>Fix:

Rename ${PATCHDIR}/patch-xc-config-util-printver.c to
${PATCHDIR}/extra-patch-xc-config-util-printver.c

and

add ${PATCHDIR}/extra-patch-xc-config-util-printver.c to
EXTRA_PATCHES in Makefile.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Apr 13 10:30:12 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122714 
Responsible-Changed-From-To: freebsd-ports-bugs->anders 
Responsible-Changed-By: anders 
Responsible-Changed-When: Sun Apr 13 12:09:56 UTC 2008 
Responsible-Changed-Why:  
As I did the update on this port, I will also handle this PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122714 
State-Changed-From-To: feedback->closed 
State-Changed-By: anders 
State-Changed-When: Tue Apr 15 22:24:49 UTC 2008 
State-Changed-Why:  
I have fixed this now. Thanks for reporting. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122714 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/122714: commit references a PR
Date: Tue, 15 Apr 2008 22:24:04 +0000 (UTC)

 anders      2008-04-15 22:23:56 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/vnc              Makefile 
   Removed files:
     net/vnc/files        patch-xc-config-util-printver.c 
   Log:
   Fix build when WITHOUT_SERVER is set.
   
   PR:             122714
   Submitted by:   Helge Oldach <ports-net-vnc-apr08@oldach.net>
   Approved by:    maintainer timeout
   
   Revision  Changes    Path
   1.53      +2 -1      ports/net/vnc/Makefile
   1.2       +0 -10     ports/net/vnc/files/patch-xc-config-util-printver.c (dead)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
