From nobody@FreeBSD.org  Thu Apr 10 20:21:54 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BC259106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 10 Apr 2008 20:21:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A91858FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 10 Apr 2008 20:21:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m3AKLYpu020306
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 10 Apr 2008 20:21:34 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m3AKLXvP020304;
	Thu, 10 Apr 2008 20:21:33 GMT
	(envelope-from nobody)
Message-Id: <200804102021.m3AKLXvP020304@www.freebsd.org>
Date: Thu, 10 Apr 2008 20:21:33 GMT
From: bf <bf2006a@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] sysutils/cdrtools-devel: fix build WITH_CDDB (also cdrtools and audio/cripple)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         122636
>Category:       ports
>Synopsis:       [PATCH] sysutils/cdrtools-devel: fix build WITH_CDDB (also cdrtools and audio/cripple)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 10 20:30:02 UTC 2008
>Closed-Date:    Fri Apr 11 22:43:00 UTC 2008
>Last-Modified:  Fri Apr 11 22:43:00 UTC 2008
>Originator:     bf
>Release:        7-STABLE i386
>Organization:
-
>Environment:
>Description:
Because of a bump in the shared library version, the recent sysutils/libcdio update broke a number of other ports, including:

sysutils/cdrtools (WITH_CDDB), 
sysutils/cdrtools-devel (WITH_CDDB),
and audio/cripple.  

(For the last port, it *ought* to have broken the build, but since the Makefile was already ... well ... crippled -- with LIB_DEPENDS misspelled as LIB_DEPENDES, it didn't make things worse.)


>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -druN cdrtools-devel.orig/Makefile cdrtools-devel/Makefile
--- cdrtools-devel.orig/Makefile	2008-04-09 16:40:00.000000000 -0400
+++ cdrtools-devel/Makefile	2008-04-10 16:11:27.883593022 -0400
@@ -92,7 +92,7 @@
 .if exists(${LOCALBASE}/lib/libcdio.a) || defined(WITH_CDDB)
 WITH_CDDB=	yes
 LIB_DEPENDS+=	cddb.4:${PORTSDIR}/audio/libcddb \
-		cdio.7:${PORTSDIR}/sysutils/libcdio
+		cdio.8:${PORTSDIR}/sysutils/libcdio
 .endif
 
 pre-everything::


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->marius 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Apr 10 20:30:11 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122636 

From: Marius Strobl <marius@alchemy.franken.de>
To: bug-followup@FreeBSD.org, bf2006a@yahoo.com
Cc:  
Subject: Re: ports/122636: [PATCH] sysutils/cdrtools-devel: fix build WITH_CDDB (also cdrtools and audio/cripple)
Date: Thu, 10 Apr 2008 22:38:28 +0200

 Could you please provide a log of how cdrtools-devel is failing?
 I currently think that its audio/libcddb and sysutils/libcdio
 dependencies were added in error in the first place.
 
 Marius
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/122636: commit references a PR
Date: Fri, 11 Apr 2008 22:37:00 +0000 (UTC)

 marius      2008-04-11 22:36:52 UTC
 
   FreeBSD ports repository (src committer)
 
   Modified files:
     sysutils/cdrtools-devel Makefile 
   Log:
   Remove erroneous dependencies on audio/libcddb and sysutils/libcdio.
   
   PR:             122636
   Approved by:    netchild
   
   Revision  Changes    Path
   1.91      +0 -10     ports/sysutils/cdrtools-devel/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: marius 
State-Changed-When: Fri Apr 11 22:41:54 UTC 2008 
State-Changed-Why:  

close 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122636 
>Unformatted:
