From nobody@FreeBSD.org  Wed Apr  9 00:44:51 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0A93D106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  9 Apr 2008 00:44:51 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id ED8818FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  9 Apr 2008 00:44:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m390iYeQ033784
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 9 Apr 2008 00:44:34 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m390iYKL033783;
	Wed, 9 Apr 2008 00:44:34 GMT
	(envelope-from nobody)
Message-Id: <200804090044.m390iYKL033783@www.freebsd.org>
Date: Wed, 9 Apr 2008 00:44:34 GMT
From: Michael Johnson <ahze@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] print/cups-base : fix cups.desktop so a browser really opens
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         122590
>Category:       ports
>Synopsis:       [PATCH] print/cups-base : fix cups.desktop so a browser really opens
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 09 00:50:01 UTC 2008
>Closed-Date:    Thu Apr 10 12:39:45 CEST 2008
>Last-Modified:  Fri Apr 11 05:00:08 UTC 2008
>Originator:     Michael Johnson
>Release:        
>Organization:
>Environment:
>Description:
Add depends on devel/xdg-utils (which has no depends) and use 'xdg-open http://localhost:631/' instead of 'htmlview http://localhost:631' in the cups.desktop file. htmlview is not found in ports... Plus xdg-open works with GNOME, KDE, XFCE, and generic desktops.

I thought about using devel/gvfs for gvfs-open but that would cause a dependency loop, plus I doubt KDE people would like that. =)
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/print/cups-base/Makefile,v
retrieving revision 1.92
diff -u -r1.92 Makefile
--- Makefile	2 Apr 2008 15:20:37 -0000	1.92
+++ Makefile	9 Apr 2008 00:39:24 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	cups
 PORTVERSION=	1.3.7
+PORTREVISION=	1
 DISTVERSIONSUFFIX=	-source
 CATEGORIES=	print
 MASTER_SITES=	EASYSW/${PORTNAME}/${DISTVERSION}
@@ -18,6 +19,7 @@
 LIB_DEPENDS=	jpeg.9:${PORTSDIR}/graphics/jpeg \
 		png.5:${PORTSDIR}/graphics/png \
 		tiff.4:${PORTSDIR}/graphics/tiff
+RUN_DEPENDS=	xdg-open:${PORTSDIR}/devel/xdg-utils
 
 CONFLICTS=	LPRng-[0-9]*
 
@@ -185,6 +187,7 @@
 .endif
 
 post-patch:
+	@${REINPLACE_CMD} -e 's|htmlview|xdg-open|' ${WRKSRC}/desktop/cups.desktop
 	@${REINPLACE_CMD} -e '/SILENT/d' ${WRKSRC}/Makedefs.in
 	@${REINPLACE_CMD} -e '/share/s|/usr/share|${PREFIX}/share|g' ${WRKSRC}/Makefile
 	@${REINPLACE_CMD} -e 's|/etc/cups|/usr/local/etc/cups|g' ${WRKSRC}/man/*.man*


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Apr 9 00:50:13 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122590 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/122590: commit references a PR
Date: Thu, 10 Apr 2008 04:20:44 +0000 (UTC)

 dinoex      2008-04-10 04:20:33 UTC
 
   FreeBSD ports repository
 
   Modified files:
     print/cups-base      Makefile 
   Log:
   - Add depends on devel/xdg-utils
   - use 'xdg-open http://localhost:631/' in the cups.desktop file.
   PR:             122590
   Submitted by:   Michael Johnson
   
   Revision  Changes    Path
   1.93      +3 -0      ports/print/cups-base/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Thu Apr 10 12:39:23 CEST 2008 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122590 

From: Neil Darlow <neil@darlow.co.uk>
To: bug-followup@FreeBSD.org, ahze@FreeBSD.org
Cc:  
Subject: Re: ports/122590: [PATCH] print/cups-base : fix cups.desktop so a
 browser really opens
Date: Thu, 10 Apr 2008 14:23:25 +0100

 Couldn't this have been provided as an optional feature?
 
 A fix for desktops results in another redundant package for those of us 
 who run cups on servers without X installed.
 
 Regards,
 Neil Darlow

From: "Michael Johnson" <ahze@freebsd.org>
To: "Neil Darlow" <neil@darlow.co.uk>
Cc: bug-followup@freebsd.org
Subject: Re: ports/122590: [PATCH] print/cups-base : fix cups.desktop so a browser really opens
Date: Thu, 10 Apr 2008 09:28:28 -0400

 ------=_Part_5833_28180032.1207834108044
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 On Thu, Apr 10, 2008 at 9:23 AM, Neil Darlow <neil@darlow.co.uk> wrote:
 
 > Couldn't this have been provided as an optional feature?
 >
 > A fix for desktops results in another redundant package for those of us
 > who run cups on servers without X installed.
 >
 
 xdg-utils is 300K with no depends.
 
 
 >
 > Regards,
 > Neil Darlow
 >
 
 ------=_Part_5833_28180032.1207834108044
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 <br><br><div class="gmail_quote">On Thu, Apr 10, 2008 at 9:23 AM, Neil Darlow &lt;<a href="mailto:neil@darlow.co.uk">neil@darlow.co.uk</a>&gt; wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
 Couldn&#39;t this have been provided as an optional feature?<br>
 <br>
 A fix for desktops results in another redundant package for those of us who run cups on servers without X installed.<br>
 </blockquote><div><br>xdg-utils is 300K with no depends. <br>&nbsp;</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
 Regards,<br><font color="#888888">
 Neil Darlow<br>
 </font></blockquote></div><br>
 
 ------=_Part_5833_28180032.1207834108044--

From: Neil Darlow <neil@darlow.co.uk>
To: bug-followup@FreeBSD.org, ahze@FreeBSD.org
Cc:  
Subject: Re: ports/122590: [PATCH] print/cups-base : fix cups.desktop so a
 browser really opens
Date: Thu, 10 Apr 2008 16:40:42 +0100

 But xdg-utils is of absolutely no use on a system without X regardless 
 of its size.
 
 The RUN_DEPENDS could easily have been wrapped by:
 
 .if !defined( WITHOUT_X11 )
 .endif
 
 and prevented the need to introduce a dependency for such systems.
 
 Regards,
 Neil Darlow

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/122590: commit references a PR
Date: Fri, 11 Apr 2008 04:59:17 +0000 (UTC)

 dinoex      2008-04-11 04:59:09 UTC
 
   FreeBSD ports repository
 
   Modified files:
     print/cups-base      Makefile 
   Log:
   - new option WITH_XDG_OPEN
   PR:             122590
   Suggested by:   Neil Darlow
   
   Revision  Changes    Path
   1.94      +9 -3      ports/print/cups-base/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
