From nobody@FreeBSD.org  Tue Apr  8 15:13:27 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E0D531065670
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  8 Apr 2008 15:13:27 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id CFE378FC32
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  8 Apr 2008 15:13:27 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m38FDBZK009625
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 8 Apr 2008 15:13:11 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m38FDBkW009624;
	Tue, 8 Apr 2008 15:13:11 GMT
	(envelope-from nobody)
Message-Id: <200804081513.m38FDBkW009624@www.freebsd.org>
Date: Tue, 8 Apr 2008 15:13:11 GMT
From: Sven Herschke <shersch@incore.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: mail/kbiff never build with ssl support
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         122574
>Category:       ports
>Synopsis:       mail/kbiff never build with ssl support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    barner
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 08 15:20:00 UTC 2008
>Closed-Date:    Tue Apr 08 20:23:45 UTC 2008
>Last-Modified:  Tue Apr  8 20:30:00 UTC 2008
>Originator:     Sven Herschke
>Release:        6.2
>Organization:
>Environment:
FreeBSD 6.2-RELEASE-p1 i386
>Description:
Configure script from port mail/kbiff has following twice and incorrect ssl check between line 25470 and line 25505:

# Check whether --enable-ssl or --disable-ssl was given.
if test "${enable_ssl+set}" = set; then
  enableval="$enable_ssl"
  use_ssl=$enableval
else
  use_ssl=yes
fi;

if test "$use_ssl" == "yes"; then

cat >>confdefs.h <<\_ACEOF
#define USE_SSL
_ACEOF

fi


# Check whether --enable-ssl or --disable-ssl was given.
if test "${enable_ssl+set}" = set; then
  enableval="$enable_ssl"
  use_ssl=$enableval
else
  use_ssl=yes
fi;

if test "$use_ssl" == "yes"; then

cat >>confdefs.h <<\_ACEOF
#define USE_SSL
_ACEOF

fi


The syntax error is in following code:
if test "$use_ssl" == "yes"; then

String comparsion with test only needs one equals sign.

>How-To-Repeat:

>Fix:
Remove twice code and change line 
    if test "$use_ssl" == "yes"; then
to
    if test "$use_ssl" = "yes"; then

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->barner 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Apr 8 15:20:09 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122574 
State-Changed-From-To: open->closed 
State-Changed-By: barner 
State-Changed-When: Tue Apr 8 20:23:44 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122574 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/122574: commit references a PR
Date: Tue,  8 Apr 2008 20:23:27 +0000 (UTC)

 barner      2008-04-08 20:23:18 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/kbiff           Makefile 
   Added files:
     mail/kbiff/files     patch-configure 
   Log:
   - Fix SSL support
   - Bump port revision
   
   PR:             ports/122574
   Submitted by:   Sven Herschke
   
   Revision  Changes    Path
   1.47      +12 -2     ports/mail/kbiff/Makefile
   1.3       +20 -0     ports/mail/kbiff/files/patch-configure (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
