From sunpoet@sunpoet.net  Mon Apr  7 18:22:09 2008
Return-Path: <sunpoet@sunpoet.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CE1E9106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  7 Apr 2008 18:22:09 +0000 (UTC)
	(envelope-from sunpoet@sunpoet.net)
Received: from sunpoet.net (sunpoet.net [203.204.205.212])
	by mx1.freebsd.org (Postfix) with ESMTP id 7255B8FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  7 Apr 2008 18:22:09 +0000 (UTC)
	(envelope-from sunpoet@sunpoet.net)
Received: by sunpoet.net (Postfix, from userid 1000)
	id 218F217026; Tue,  8 Apr 2008 02:24:18 +0800 (CST)
Message-Id: <20080407182418.218F217026@sunpoet.net>
Date: Tue,  8 Apr 2008 02:24:18 +0800 (CST)
From: Sunpoet Po-Chuan Hsieh <sunpoet@sunpoet.net>
Reply-To: Sunpoet Po-Chuan Hsieh <sunpoet@sunpoet.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] net/tintin++-devel: fix build with Big5 enabled, take maintainership 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         122541
>Category:       ports
>Synopsis:       [PATCH] net/tintin++-devel: fix build with Big5 enabled, take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    clsung
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 07 18:30:01 UTC 2008
>Closed-Date:    Wed Apr 09 09:00:00 UTC 2008
>Last-Modified:  Wed Apr  9 09:00:03 UTC 2008
>Originator:     Sunpoet Po-Chuan Hsieh
>Release:        FreeBSD 6.3-STABLE i386
>Organization:
SUNPOET.net
>Environment:
System: FreeBSD IRIS.sunpoet.net 6.3-STABLE FreeBSD 6.3-STABLE #16: Fri Feb 22 08:37:15 CST 2008 sunpoet@IRIS.sunpoet.net:/usr/obj/usr/src/sys/sunpoet i386


	
>Description:
1. fix build with Big5 enabled (chinese/tintin++)
2. take maintainership
	
>How-To-Repeat:
% cd /usr/ports/chinese/tintin++
...
===>  Building for zh-tintin-1.98.1
cc -Wall  -O2 -pipe -s -msse -msse2 -march=pentium4 -fno-strict-aliasing -D_GNU_SOURCE -DHAVE_CONFIG_H -DBIG5    -c action.c
cc -Wall  -O2 -pipe -s -msse -msse2 -march=pentium4 -fno-strict-aliasing -D_GNU_SOURCE -DHAVE_CONFIG_H -DBIG5    -c alias.c
cc -Wall  -O2 -pipe -s -msse -msse2 -march=pentium4 -fno-strict-aliasing -D_GNU_SOURCE -DHAVE_CONFIG_H -DBIG5    -c files.c
cc -Wall  -O2 -pipe -s -msse -msse2 -march=pentium4 -fno-strict-aliasing -D_GNU_SOURCE -DHAVE_CONFIG_H -DBIG5    -c help.c
cc -Wall  -O2 -pipe -s -msse -msse2 -march=pentium4 -fno-strict-aliasing -D_GNU_SOURCE -DHAVE_CONFIG_H -DBIG5    -c highlight.c
cc -Wall  -O2 -pipe -s -msse -msse2 -march=pentium4 -fno-strict-aliasing -D_GNU_SOURCE -DHAVE_CONFIG_H -DBIG5    -c strhash.c
cc -Wall  -O2 -pipe -s -msse -msse2 -march=pentium4 -fno-strict-aliasing -D_GNU_SOURCE -DHAVE_CONFIG_H -DBIG5    -c llist.c
cc -Wall  -O2 -pipe -s -msse -msse2 -march=pentium4 -fno-strict-aliasing -D_GNU_SOURCE -DHAVE_CONFIG_H -DBIG5    -c log.c
cc -Wall  -O2 -pipe -s -msse -msse2 -march=pentium4 -fno-strict-aliasing -D_GNU_SOURCE -DHAVE_CONFIG_H -DBIG5    -c main.c
cc -Wall  -O2 -pipe -s -msse -msse2 -march=pentium4 -fno-strict-aliasing -D_GNU_SOURCE -DHAVE_CONFIG_H -DBIG5    -c misc.c
misc.c: In function `do_parse':
misc.c:293: error: syntax error before ')' token
gmake: *** [misc.o] Error 1
*** Error code 2

Stop in /usr/ports/chinese/tintin++.
*** Error code 1

Stop in /usr/ports/chinese/tintin++.

	
>Fix:
diff -ruN /usr/ports/net/tintin++-devel/Makefile /usr/ports/sunpoet/tintin++-devel/Makefile
--- /usr/ports/net/tintin++-devel/Makefile	2008-04-07 17:14:59.000000000 +0800
+++ /usr/ports/sunpoet/tintin++-devel/Makefile	2008-04-07 18:14:11.000000000 +0800
@@ -11,7 +11,7 @@
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE_EXTENDED}
 MASTER_SITE_SUBDIR=	${PORTNAME}
 
-MAINTAINER?=	ports@FreeBSD.org
+MAINTAINER?=	sunpoet@sunpoet.net
 COMMENT=	A client program to help playing muds (devel version)
 
 LATEST_LINK=	${PORTNAME}-devel
@@ -23,7 +23,7 @@
 USE_GCC=	3.2+
 
 PLIST_FILES=	bin/tt++
-PORTDOCS=	BUGS CREDITS FAQ README TODO tintin19.txt chat_protocol.txt
+PORTDOCS=	BUGS CREDITS FAQ README TODO chat_protocol.txt tintin19.txt
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|-lpthread|${PTHREAD_LIBS}|' ${WRKSRC}/Makefile.in
@@ -32,7 +32,7 @@
 	${INSTALL_PROGRAM} ${WRKSRC}/tt++ ${PREFIX}/bin
 .ifndef NOPORTDOCS
 	${MKDIR} ${DOCSDIR}
-.for i in FAQ README TODO CREDITS BUGS docs/tintin19.txt docs/chat_protocol.txt
+.for i in BUGS CREDITS FAQ README TODO docs/chat_protocol.txt docs/tintin19.txt
 	${INSTALL_DATA} ${WRKSRC}/../${i} ${DOCSDIR}
 .endfor
 .endif
diff -ruN /usr/ports/net/tintin++-devel/files/patch-misc.c /usr/ports/sunpoet/tintin++-devel/files/patch-misc.c
--- /usr/ports/net/tintin++-devel/files/patch-misc.c	1970-01-01 08:00:00.000000000 +0800
+++ /usr/ports/sunpoet/tintin++-devel/files/patch-misc.c	2008-04-07 18:10:45.000000000 +0800
@@ -0,0 +1,11 @@
+--- misc.c.orig	2008-04-04 06:38:59.000000000 +0800
++++ misc.c	2008-04-07 17:48:56.000000000 +0800
+@@ -290,7 +290,7 @@
+ #ifdef BIG5
+ 			if (left[cnt] & 0x80 && left[cnt+1] != 0)
+ 			{
+-				sprintf(temp, "%c%c", left[cnt], left[++cnt]));
++				sprintf(temp, "%c%c", left[cnt], left[++cnt]);
+ 			}
+ 			else
+ 			{

	
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->clsung 
Responsible-Changed-By: clsung 
Responsible-Changed-When: Tue Apr 8 01:32:17 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122541 
State-Changed-From-To: open->closed 
State-Changed-By: clsung 
State-Changed-When: Wed Apr 9 08:59:59 UTC 2008 
State-Changed-Why:  
Committed. Thank You. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122541 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/122541: commit references a PR
Date: Wed,  9 Apr 2008 08:59:55 +0000 (UTC)

 clsung      2008-04-09 08:59:47 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/tintin++-devel   Makefile distinfo 
   Added files:
     net/tintin++-devel/files patch-misc.c 
   Log:
   1. fix build with Big5 enabled (chinese/tintin++)
   2. take maintainership
   - the distfile is re-rolled (but no log in Changes :-/)
   - bump PORTREVISION
   
   PR:             ports/122541
   Submitted by:   maintainer (Sunpoet Po-Chuan Hsieh)
   
   Revision  Changes    Path
   1.38      +4 -3      ports/net/tintin++-devel/Makefile
   1.20      +3 -3      ports/net/tintin++-devel/distinfo
   1.1       +11 -0     ports/net/tintin++-devel/files/patch-misc.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
