From pgollucci@piccollo.p6m7g8.net  Thu Apr  3 01:02:38 2008
Return-Path: <pgollucci@piccollo.p6m7g8.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D762B106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Apr 2008 01:02:38 +0000 (UTC)
	(envelope-from pgollucci@piccollo.p6m7g8.net)
Received: from piccollo.p6m7g8.net (piccollo.p6m7g8.net [70.88.236.19])
	by mx1.freebsd.org (Postfix) with ESMTP id 913008FC19
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Apr 2008 01:02:38 +0000 (UTC)
	(envelope-from pgollucci@piccollo.p6m7g8.net)
Received: from piccollo.p6m7g8.net (localhost.p6m7g8.net [127.0.0.1])
	by piccollo.p6m7g8.net (8.14.2/8.14.2) with ESMTP id m3312a3a012389
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO);
	Wed, 2 Apr 2008 21:02:36 -0400 (EDT)
	(envelope-from pgollucci@piccollo.p6m7g8.net)
Received: (from root@localhost)
	by piccollo.p6m7g8.net (8.14.2/8.14.2/Submit) id m3312aAL012388;
	Wed, 2 Apr 2008 21:02:36 -0400 (EDT)
	(envelope-from pgollucci)
Message-Id: <200804030102.m3312aAL012388@piccollo.p6m7g8.net>
Date: Wed, 2 Apr 2008 21:02:36 -0400 (EDT)
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: scheidell@secnap.net
Subject: [PATCH] mail/p5-Mail-SpamAssassin: [SUMMARIZE CHANGES]
X-Send-Pr-Version: 3.113
X-GNATS-Notify: scheidell@secnap.net

>Number:         122396
>Category:       ports
>Synopsis:       [PATCH] mail/p5-Mail-SpamAssassin: [SUMMARIZE CHANGES]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    araujo
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 03 01:10:01 UTC 2008
>Closed-Date:    Tue Apr 15 10:41:02 UTC 2008
>Last-Modified:  Tue Apr 15 10:41:02 UTC 2008
>Originator:     Philip M. Gollucci
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
Riderway Inc.
>Environment:
System: FreeBSD piccollo.p6m7g8.net 8.0-CURRENT FreeBSD 8.0-CURRENT #1: Sun Mar  2 09:48:59 EST
>Description:

Add /g to MASTER_SITE regexes, noticed by flz@

Port maintainer (scheidell@secnap.net) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- p5-Mail-SpamAssassin-3.2.4_3.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/mail/p5-Mail-SpamAssassin/Makefile,v
retrieving revision 1.115
diff -u -u -r1.115 Makefile
--- Makefile	28 Mar 2008 19:03:13 -0000	1.115
+++ Makefile	2 Apr 2008 19:58:50 -0000
@@ -9,7 +9,7 @@
 PORTVERSION=	3.2.4
 PORTREVISION=	3
 CATEGORIES=	mail perl5
-MASTER_SITES=	${MASTER_SITE_APACHE:S/$/:apache/} ${MASTER_SITE_PERL_CPAN:S/$/:cpan/}
+MASTER_SITES=	${MASTER_SITE_APACHE:S/$/:apache/g} ${MASTER_SITE_PERL_CPAN:S/$/:cpan/g}
 MASTER_SITE_SUBDIR=	spamassassin/source/:apache Mail/:cpan
 PKGNAMEPREFIX=	p5-
 DISTFILES=	${DISTNAME}${EXTRACT_SUFX}:apache,cpan
--- p5-Mail-SpamAssassin-3.2.4_3.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->araujo 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Apr 3 01:10:07 UTC 2008 
Responsible-Changed-Why:  
araujo@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122396 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Apr 3 01:10:10 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122396 

From: Michael Scheidell <scheidell@secnap.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/122396: [PATCH] mail/p5-Mail-SpamAssassin: [SUMMARIZE CHANGES]
Date: Thu, 03 Apr 2008 15:04:07 -0400

 This is a multi-part message in MIME format.
 --------------020507000209040909030400
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Edwin Groothuis wrote:
 >
 > Maintainer of mail/p5-Mail-SpamAssassin,
 >
 > Please note that PR ports/122396 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/122396
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
 Ed: I am not sure, 100% of why this is needed, now do I know if it will 
 break something
 
 I do see some makefiles in ports with a /g after them, and I don't know 
 if this is being requested because a user had a problem, since there is 
 no documentation on WHY the change is requested, or what happens if you 
 don't do it.
 
 I personally have never had anyone report a problem, and 300 systems I 
 maintain in the field have never reported a problem.
 
 If you know 100% for sure they won't break something, apply it.  If not, 
 since there has never been even one report of a problem, don't apply it.
 
 -MASTER_SITES=  ${MASTER_SITE_APACHE:S/$/:apache/} 
 ${MASTER_SITE_PERL_CPAN:S/$/:cpan/}
 +MASTER_SITES=  ${MASTER_SITE_APACHE:S/$/:apache/g} 
 ${MASTER_SITE_PERL_CPAN:S/$/:cpan/g}
 
 
 -- 
 Michael Scheidell, CTO
 Main: 561-999-5000, Office: 561-939-7259
  > *| *SECNAP Network Security Corporation
 Winner 2008 Technosium hot company award.
 www.technosium.com/hotcompanies/ <http://www.technosium.com/hotcompanies/>
 
 
 _________________________________________________________________________
 This email has been scanned and certified safe by SpammerTrap(tm). 
 For Information please see http://www.spammertrap.com
 _________________________________________________________________________
 
 --------------020507000209040909030400
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
 <head>
   <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
 </head>
 <body bgcolor="#ffffff" text="#000000">
 Edwin Groothuis wrote:
 <blockquote cite="mid:20080403011009.4ED7B106566B@hub.freebsd.org"
  type="cite">
   <meta http-equiv="Content-Type" content="text/html; ">
   <meta name="Generator"
  content="MS Exchange Server version 6.5.7652.24">
   <title>Re: ports/122396: [PATCH] mail/p5-Mail-SpamAssassin:
 [SUMMARIZE CHANGES]</title>
 <!-- Converted from text/plain format -->
   <p><tt><font size="2">Maintainer of mail/p5-Mail-SpamAssassin,<br>
   <br>
 Please note that PR ports/122396 has just been submitted.<br>
   <br>
 If it contains a patch for an upgrade, an enhancement or a bug fix<br>
 you agree on, reply to this email stating that you approve the patch<br>
 and a committer will take care of it.<br>
   <br>
 The full text of the PR can be found at:<br>
 &nbsp;&nbsp;&nbsp; <a moz-do-not-send="true"
  href="http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/122396">http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/122396</a><br>
   <br>
 --<br>
 Edwin Groothuis via the GNATS Auto Assign Tool<br>
 <a class="moz-txt-link-abbreviated" href="mailto:edwin@FreeBSD.org">edwin@FreeBSD.org</a><br>
   <br>
   </font></tt>
   </p>
 </blockquote>
 Ed: I am not sure, 100% of why this is needed, now do I know if it will
 break something<br>
 <br>
 I do see some makefiles in ports with a /g after them, and I don't know
 if this is being requested because a user had a problem, since there is
 no documentation on WHY the change is requested, or what happens if you
 don't do it. <br>
 <br>
 I personally have never had anyone report a problem, and 300 systems I
 maintain in the field have never reported a problem.<br>
 <br>
 If you know 100% for sure they won't break something, apply it.&nbsp; If
 not, since there has never been even one report of a problem, don't
 apply it.<br>
 <br>
 <tt><font size="2">-MASTER_SITES=&nbsp; ${MASTER_SITE_APACHE:S/$/:apache/}
 ${MASTER_SITE_PERL_CPAN:S/$/:cpan/}<br>
 +MASTER_SITES=&nbsp; ${MASTER_SITE_APACHE:S/$/:apache/g}
 ${MASTER_SITE_PERL_CPAN:S/$/:cpan/g}<br>
 <br>
 </font></tt><br>
 <div class="moz-signature">-- <br>
 Michael Scheidell, CTO<br>
 Main: 561-999-5000, Office: 561-939-7259<br>
 <font color="#999999">&gt;</font><font color="#cc0000"> <b>| </b></font>SECNAP
 Network Security Corporation<br>
 Winner 2008 Technosium <font color="#cc0000">hot company</font> award.<br>
 <a href="http://www.technosium.com/hotcompanies/">www.technosium.com/hotcompanies/</a><br>
 <br>
 </div>
 
 <br>
 <div id="disclaimer.secnap.com"> <hr>
 This email has been scanned and certified safe by SpammerTrap&#8482;.
 <br>For Information please see 
 <a href=http://www.spammertrap.com>www.spammertrap.com</a>
 <hr> </div>
 <br>
 </body>
 </html>
 
 --------------020507000209040909030400--
State-Changed-From-To: feedback->open 
State-Changed-By: araujo 
State-Changed-When: Tue Apr 8 04:22:10 UTC 2008 
State-Changed-Why:  
I'm waiting a major UPDATE, maintainer is not sure 100% and this seems a 
minor update. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122396 

From: "Philip M. Gollucci" <pgollucci@riderway.com>
To: bug-followup@FreeBSD.org, pgollucci@p6m7g8.com
Cc:  
Subject: Re: ports/122396: [PATCH] mail/p5-Mail-SpamAssassin: [SUMMARIZE CHANGES]
Date: Mon, 14 Apr 2008 23:56:17 -0400

 Maintainer is correct, both flz@ and I are wrong:
 
 Please close PR, that'll teach me to listen to a portmgr@.
 
 for proof,
 make -V MASTER_SITES
 
 
 S/old_string/new_string/[g]:
 Modify the first occurrence of old_string in each word of the
 variable's value, replacing it with new_string.  If a `g' is
 appended to the last slash of the pattern, all occurrences in
 each word are replaced.  If old_string begins with a caret
 (`^'), old_string is anchored at the beginning of each word.
 If old_string ends with a dollar sign (`$'), it is anchored
 at the end of each word.  Inside new_string, an ampersand
 (`&') is replaced by old_string.  Any character may be used
 as a delimiter for the parts of the modifier string.  The
 anchoring, ampersand, and delimiter characters may be escaped
 with a backslash (`\').
 
 Variable expansion occurs in the normal fashion inside both
 old_string and new_string with the single exception that a
 backslash is used to prevent the expansion of a dollar sign
 (`$'), not a preceding dollar sign as is usual.
 
 
State-Changed-From-To: open->closed 
State-Changed-By: araujo 
State-Changed-When: Tue Apr 15 10:41:01 UTC 2008 
State-Changed-Why:  
Submitter request it. Closed! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122396 
>Unformatted:
