From nobody@FreeBSD.org  Fri Mar 28 03:50:30 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B24BA1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Mar 2008 03:50:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 9CBC58FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Mar 2008 03:50:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m2S3oDWg024967
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 28 Mar 2008 03:50:13 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m2S3oD7s024966;
	Fri, 28 Mar 2008 03:50:13 GMT
	(envelope-from nobody)
Message-Id: <200803280350.m2S3oD7s024966@www.freebsd.org>
Date: Fri, 28 Mar 2008 03:50:13 GMT
From: Hiroto Kagotani <hiroto.kagotani@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: www/moodle: enabling mimeTeX functionality
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: jmrueda@diatel.upm.es

>Number:         122178
>Category:       ports
>Synopsis:       www/moodle: enabling mimeTeX functionality
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 28 04:00:01 UTC 2008
>Closed-Date:    Thu Apr 03 20:19:45 UTC 2008
>Last-Modified:  Thu Apr  3 20:20:02 UTC 2008
>Originator:     Hiroto Kagotani
>Release:        7.0-RELEASE
>Organization:
Okayama Univ.
>Environment:
FreeBSD myhost.mydomain 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 10:35:36 UTC 2008     root@driscoll.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
moodle has TeX filter functionality with built-in mimetex.freebsd binary, but the binary requires an old library based on FreeBSD 5.x and is not executable in the current installation.  moodle should depend on the latest www/mimetex port for any version of FreeBSD.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ru moodle.orig/Makefile moodle/Makefile
--- moodle.orig/Makefile	2008-03-08 03:48:58.000000000 +0900
+++ moodle/Makefile	2008-03-28 12:03:32.000000000 +0900
@@ -22,7 +22,8 @@
 		MSSQL   "Add support for a MS SQL Server" Off \
 		ZLIB    "Add zip/unzip functionality" On \
 		NETWORK "Add Moodle Network functionality" Off \
-		LDAP    "Add LDAP authentication functionality" Off
+		LDAP    "Add LDAP authentication functionality" Off \
+		MIMETEX "Add mimeTeX filter functionality" On
 
 .include <bsd.port.pre.mk>
 
@@ -64,6 +65,10 @@
 USE_PHP+=	ldap
 .endif
 
+.if !defined(WITHOUT_MIMETEX)
+RUN_DEPENDS+=	${PREFIX}/www/cgi-bin/mimetex.cgi:${PORTSDIR}/www/mimetex
+.endif
+
 NO_BUILD=	yes
 PLIST=		${WRKDIR}/plist
 SUB_FILES=	pkg-message
@@ -92,6 +97,9 @@
 		>> ${TMPPLIST}
 	${CHMOD} 755 ${PREFIX}/${MOODLEDATADIR}
 	@${ECHO_CMD} '@exec ${CHMOD} 755 ${PREFIX}/${MOODLEDATADIR}' >> ${TMPPLIST}
+.if !defined(WITHOUT_MIMETEX)
+	${LN} -sf ${PREFIX}/www/cgi-bin/mimetex.cgi ${PREFIX}/${MOODLEDIR}/filter/tex/mimetex.freebsd
+.endif
 
 post-install:
 	@${CAT} ${PKGMESSAGE}


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Mar 28 04:00:06 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122178 
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: beech 
Responsible-Changed-When: Fri Mar 28 04:02:25 UTC 2008 
Responsible-Changed-Why:  
I'll take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122178 

From: =?ISO-8859-1?Q?Javier_Mart=EDn_Rueda?= <jmrueda@diatel.upm.es>
To: bug-followup@FreeBSD.org, hiroto.kagotani@gmail.com
Cc:  
Subject: Re: ports/122178: www/moodle: enabling mimeTeX functionality
Date: Thu, 03 Apr 2008 10:19:42 +0200

 This is a multi-part message in MIME format.
 --------------010306030802060202020702
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 The patch is OK. I tested the mimetex functionality and works fine. 
 Thank you for the patch.
 
 However, I think it's better not to enable it by default, because I 
 think many users won't use that functionality and it's better not to 
 install additional software unless you really need it.
 
 Therefore, I propose to change the option from On to Off. I enclose a 
 new patch with just that change.
 
 With this change, I see no problem to update the port.
 
 
 --------------010306030802060202020702
 Content-Type: text/plain;
  name="parche.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="parche.txt"
 
 
 diff -ru moodle.orig/Makefile moodle/Makefile
 --- moodle.orig/Makefile	2008-03-08 03:48:58.000000000 +0900
 +++ moodle/Makefile	2008-03-28 12:03:32.000000000 +0900
 @@ -22,7 +22,8 @@
  		MSSQL   "Add support for a MS SQL Server" Off \
  		ZLIB    "Add zip/unzip functionality" On \
  		NETWORK "Add Moodle Network functionality" Off \
 -		LDAP    "Add LDAP authentication functionality" Off
 +		LDAP    "Add LDAP authentication functionality" Off \
 +		MIMETEX "Add mimeTeX filter functionality" Off
  
  .include <bsd.port.pre.mk>
  
 @@ -64,6 +65,10 @@
  USE_PHP+=	ldap
  .endif
  
 +.if !defined(WITHOUT_MIMETEX)
 +RUN_DEPENDS+=	${PREFIX}/www/cgi-bin/mimetex.cgi:${PORTSDIR}/www/mimetex
 +.endif
 +
  NO_BUILD=	yes
  PLIST=		${WRKDIR}/plist
  SUB_FILES=	pkg-message
 @@ -92,6 +97,9 @@
  		>> ${TMPPLIST}
  	${CHMOD} 755 ${PREFIX}/${MOODLEDATADIR}
  	@${ECHO_CMD} '@exec ${CHMOD} 755 ${PREFIX}/${MOODLEDATADIR}' >> ${TMPPLIST}
 +.if !defined(WITHOUT_MIMETEX)
 +	${LN} -sf ${PREFIX}/www/cgi-bin/mimetex.cgi ${PREFIX}/${MOODLEDIR}/filter/tex/mimetex.freebsd
 +.endif
  
  post-install:
  	@${CAT} ${PKGMESSAGE}
 
 
 
 --------------010306030802060202020702--
State-Changed-From-To: feedback->closed 
State-Changed-By: beech 
State-Changed-When: Thu Apr 3 20:19:32 UTC 2008 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122178 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/122178: commit references a PR
Date: Thu,  3 Apr 2008 20:19:10 +0000 (UTC)

 beech       2008-04-03 20:19:01 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/moodle           Makefile 
   Log:
   - Enable mimeTeX functionality
   
   PR:             ports/122178
   Submitted by:   Hiroto Kagotani <hiroto.kagotani@gmail.com>
   Approved by:    Javier Martn Rueda <jmrueda@diatel.upm.es> (maintainer)
   
   Revision  Changes    Path
   1.15      +9 -1      ports/www/moodle/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
