From nobody@FreeBSD.org  Thu Mar  6 20:37:41 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4332C1065673
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Mar 2008 20:37:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 329848FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Mar 2008 20:37:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m26KYbN3011601
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 6 Mar 2008 20:34:37 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m26KYb74011600;
	Thu, 6 Mar 2008 20:34:37 GMT
	(envelope-from nobody)
Message-Id: <200803062034.m26KYb74011600@www.freebsd.org>
Date: Thu, 6 Mar 2008 20:34:37 GMT
From: bf <bf2006a@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH]archivers/szip: respect CFLAGS
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         121441
>Category:       ports
>Synopsis:       [PATCH]archivers/szip: respect CFLAGS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    garga
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 06 20:40:00 UTC 2008
>Closed-Date:    Sun Mar 09 14:12:41 UTC 2008
>Last-Modified:  Sun Mar  9 14:20:03 UTC 2008
>Originator:     bf
>Release:        7-STABLE i386
>Organization:
-
>Environment:
>Description:
source makefile redefines CFLAGS
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN szip.orig/Makefile szip/Makefile
--- szip.orig/Makefile	2006-07-23 10:22:12.000000000 -0400
+++ szip/Makefile	2008-03-06 15:26:18.821159466 -0500
@@ -24,6 +24,7 @@
 
 post-patch:
 	@${REINPLACE_CMD} -e 's,more logfile,cat logfile,' \
+		-e 's,%%CFLAGS%%,${CFLAGS},' \
 		${WRKSRC}/makefile
 
 do-build:
diff -ruN szip.orig/files/patch-makefile szip/files/patch-makefile
--- szip.orig/files/patch-makefile	1969-12-31 19:00:00.000000000 -0500
+++ szip/files/patch-makefile	2008-03-06 15:25:12.501362955 -0500
@@ -0,0 +1,14 @@
+--- makefile.orig	2008-03-06 15:18:24.541994376 -0500
++++ makefile	2008-03-06 15:19:36.138089132 -0500
+@@ -1,4 +1,3 @@
+-CFLAGS = -O6 -Wall -fomit-frame-pointer -funroll-loops
+ NAME = szip_112b_$(shell uname)_$(shell uname -m).tar
+ %.exe : %
+ 
+@@ -22,4 +21,4 @@
+ 	tar -cf $(NAME) szip readme.txt techinfo.txt history.txt
+ 	gzip $(NAME)
+ clean:
+-	-rm *.o szip check logfile
+\ No newline at end of file
++	-rm *.o szip check logfile


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->garga 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Mar 6 20:40:08 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121441 

From: bf <bf2006a@yahoo.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/121441: [PATCH]archivers/szip: respect CFLAGS
Date: Thu, 6 Mar 2008 14:47:07 -0800 (PST)

 Sorry, forgot to yank a line from the Makefile in my
 patch.  No need for:
 
 +                -e 's,%%CFLAGS%%,${CFLAGS},' \
 
 in the REINPLACE_CMD.
 
 bf
 
 
       ____________________________________________________________________________________
 Never miss a thing.  Make Yahoo your home page. 
 http://www.yahoo.com/r/hs

From: bf <bf2006a@yahoo.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/121441: [PATCH]archivers/szip: respect CFLAGS
Date: Thu, 6 Mar 2008 15:36:26 -0800 (PST)

 --0-561166483-1204846586=:63845
 Content-Type: text/plain; charset=iso-8859-1
 Content-Transfer-Encoding: 8bit
 Content-Id: 
 Content-Disposition: inline
 
 Sigh.  This comes of trying to do several things at
 once.  Neither the first patch nor my earlier
 follow-up got it right: when making my comment, I
 forgot that the default do-build target had been
 redefined in the port Makefile.  So, use the attached
 patch instead.  Sorry about the mix-up.
 
 bf
 
 
 
 
       ____________________________________________________________________________________
 Be a better friend, newshound, and 
 know-it-all with Yahoo! Mobile.  Try it now.  http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ 
 
 --0-561166483-1204846586=:63845
 Content-Type: text/plain; name="szip.txt"
 Content-Description: 1188030949-szip.txt
 Content-Disposition: inline; filename="szip.txt"
 
 diff -ruN szip.orig/Makefile szip/Makefile
 --- szip.orig/Makefile	2006-07-23 10:22:12.000000000 -0400
 +++ szip/Makefile	2008-03-06 18:26:29.062928235 -0500
 @@ -24,6 +24,7 @@
  
  post-patch:
  	@${REINPLACE_CMD} -e 's,more logfile,cat logfile,' \
 +		-e 's,%%CFLAGS%%,${CFLAGS},' \
  		${WRKSRC}/makefile
  
  do-build:
 diff -ruN szip.orig/files/patch-makefile szip/files/patch-makefile
 --- szip.orig/files/patch-makefile	1969-12-31 19:00:00.000000000 -0500
 +++ szip/files/patch-makefile	2008-03-06 18:26:29.062928235 -0500
 @@ -0,0 +1,15 @@
 +--- makefile.orig	2008-03-06 18:19:00.829257196 -0500
 ++++ makefile	2008-03-06 18:22:38.861735626 -0500
 +@@ -1,4 +1,4 @@
 +-CFLAGS = -O6 -Wall -fomit-frame-pointer -funroll-loops
 ++CFLAGS =	%%CFLAGS%%
 + NAME = szip_112b_$(shell uname)_$(shell uname -m).tar
 + %.exe : %
 + 
 +@@ -22,4 +22,4 @@
 + 	tar -cf $(NAME) szip readme.txt techinfo.txt history.txt
 + 	gzip $(NAME)
 + clean:
 +-	-rm *.o szip check logfile
 +\ No newline at end of file
 ++	-rm *.o szip check logfile
 
 --0-561166483-1204846586=:63845--
State-Changed-From-To: open->closed 
State-Changed-By: garga 
State-Changed-When: Sun Mar 9 14:12:40 UTC 2008 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121441 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/121441: commit references a PR
Date: Sun,  9 Mar 2008 14:12:31 +0000 (UTC)

 garga       2008-03-09 14:12:21 UTC
 
   FreeBSD ports repository
 
   Modified files:
     archivers/szip       Makefile 
   Log:
   - Respect CFLAGS
   - Bump PORTREVISION
   
   PR:             ports/121441 (based on)
   Submitted by:   bf <bf2006a@yahoo.com>
   
   Revision  Changes    Path
   1.15      +2 -1      ports/archivers/szip/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
