From lennox@cs.columbia.edu  Thu Mar  6 16:07:31 2008
Return-Path: <lennox@cs.columbia.edu>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7E509106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Mar 2008 16:07:31 +0000 (UTC)
	(envelope-from lennox@cs.columbia.edu)
Received: from cnr.cs.columbia.edu (cnr.cs.columbia.edu [128.59.19.133])
	by mx1.freebsd.org (Postfix) with ESMTP id 290D48FC1A
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Mar 2008 16:07:31 +0000 (UTC)
	(envelope-from lennox@cs.columbia.edu)
Received: from cnr.cs.columbia.edu (localhost [127.0.0.1])
	by cnr.cs.columbia.edu (8.13.6/8.13.6) with ESMTP id m26G7UDV076163
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 6 Mar 2008 11:07:30 -0500 (EST)
	(envelope-from lennox@cnr.cs.columbia.edu)
Received: (from lennox@localhost)
	by cnr.cs.columbia.edu (8.13.6/8.13.6/Submit) id m26G7TpK076161;
	Thu, 6 Mar 2008 11:07:29 -0500 (EST)
	(envelope-from lennox)
Message-Id: <200803061607.m26G7TpK076161@cnr.cs.columbia.edu>
Date: Thu, 6 Mar 2008 11:07:29 -0500 (EST)
From: Jonathan Lennox <lennox@cs.columbia.edu>
Reply-To: Jonathan Lennox <lennox@cs.columbia.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: devel/ccrtp doesn't build with security/libgcrypt 1.4.0 on FreeBSD 5.x
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         121431
>Category:       ports
>Synopsis:       devel/ccrtp doesn't build with security/libgcrypt 1.4.0 on FreeBSD 5.x
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    acm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 06 16:10:03 UTC 2008
>Closed-Date:    Sun Jun 01 16:49:54 UTC 2008
>Last-Modified:  Sun Jun 01 16:49:54 UTC 2008
>Originator:     Jonathan Lennox
>Release:        FreeBSD 5.5-RELEASE-p19 i386
>Organization:
Columbia University
>Environment:
System: FreeBSD cnr.cs.columbia.edu 5.5-RELEASE-p19 FreeBSD 5.5-RELEASE-p19 #26: Thu Feb 14 12:09:09 EST 2008 lennox@cnr.cs.columbia.edu:/usr/obj/usr/src/sys/CNR i386


	
>Description:

With version 1.4.0 of security/libgcrypt, the devel/ccrtp port doesn't build
on FreeBSD 5.x.

This appears to be due to devel/ccrtp building as C++ with the -pedantic
flag, while gcrypt.h has enumerator lists (gcry_ac_em_t and
gcry_ac_scheme_t) with trailing commas.  This causes a compiler error with
the FreeBSD 5.x g++.

/bin/sh ../libtool --tag=CXX   --mode=compile c++ -DHAVE_CONFIG_H -I.   -I/usr/local/include  -Wall -ansi -pedantic -O -pipe -march=athlon-xp -D_THREAD_SAFE -D_GNU_SOURCE -I/usr/local/include   -c -o gcrypthmac.lo `test -f 'ccrtp/crypto/gcrypt/gcrypthmac.cxx' || echo './'`ccrtp/crypto/gcrypt/gcrypthmac.cxx
 c++ -DHAVE_CONFIG_H -I. -I/usr/local/include -Wall -ansi -pedantic -O -pipe -march=athlon-xp -D_THREAD_SAFE -D_GNU_SOURCE -I/usr/local/include -c ccrtp/crypto/gcrypt/gcrypthmac.cxx  -fPIC -DPIC -o .libs/gcrypthmac.o
In file included from ccrtp/crypto/gcrypt/gcrypthmac.cxx:23:
/usr/local/include/gcrypt.h:1238: error: comma at end of enumerator list
/usr/local/include/gcrypt.h:1246: error: comma at end of enumerator list
gmake[3]: *** [gcrypthmac.lo] Error 1
gmake[3]: Leaving directory `/usr/ports/devel/ccrtp/work/ccrtp-1.6.0/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/devel/ccrtp/work/ccrtp-1.6.0/src'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/usr/ports/devel/ccrtp/work/ccrtp-1.6.0/src'
gmake: *** [all-recursive] Error 1
*** Error code 2

Stop in /usr/ports/devel/ccrtp.


This issue has been reported to the libgcrypt bug tracker.

>How-To-Repeat:

portupgrade security/libgcrypt
portinstall -f devel/ccrtp

>Fix:

The proper fix should probably be to the security/libgcrypt port, but adding
the following patch file to devel/ccrtp/files fixes the ccrtp build:

--- configure.orig	Thu Mar  6 10:40:11 2008
+++ configure	Thu Mar  6 10:40:20 2008
@@ -20904,7 +20904,7 @@ GNULIBS="-L$COMMON_LIBPATH $COMMON_LIBS 
 # OST_CC_ENDIAN - now in Common C++
 # Are we using the GNU compiler?
 if test $GCC = yes ; then
-	WARN_FLAGS="-Wall -ansi -pedantic"
+	WARN_FLAGS="-Wall -ansi"
 else
 	WARN_FLAGS=""
 fi



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->acm 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Mar 6 16:10:15 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121431 

From: "Jose Alonso Cardenas Marquez" <acardenas@bsd-peru.org>
To: bug-followup@FreeBSD.org, "Jonathan Lennox" <lennox@cs.columbia.edu>
Cc:  
Subject: Re: ports/121431: devel/ccrtp doesn't build with security/libgcrypt 1.4.0 on FreeBSD 5.x
Date: Mon, 19 May 2008 19:25:31 -0500

 Hi :)
 
 Could you test if it works with lastest version of security/libgcrypt?
 because a similar problem was reported with fbsd 7, but i can't
 reproduce the problem on 7-STABLE, 6-STABLE (i386, amd64).
 
 Greeting
 ACM
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Sun Jun 1 16:49:53 UTC 2008 
State-Changed-Why:  
FreeBSD 5 is now EOL. Please update to 6.4 or 7.0 Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121431 
>Unformatted:
