From gavin@ga9test2.york.ac.uk  Mon Mar  3 19:35:20 2008
Return-Path: <gavin@ga9test2.york.ac.uk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D29E61065671
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  3 Mar 2008 19:35:20 +0000 (UTC)
	(envelope-from gavin@ga9test2.york.ac.uk)
Received: from mail-gw0.york.ac.uk (mail-gw0.york.ac.uk [144.32.128.245])
	by mx1.freebsd.org (Postfix) with ESMTP id 90C898FC18
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  3 Mar 2008 19:35:20 +0000 (UTC)
	(envelope-from gavin@ga9test2.york.ac.uk)
Received: from mail-gw6.york.ac.uk (mail-gw6.york.ac.uk [144.32.129.26])
	by mail-gw0.york.ac.uk (8.13.6/8.13.6) with ESMTP id m23J4jxi007301
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 3 Mar 2008 19:04:45 GMT
Received: from ga9test2.york.ac.uk ([144.32.128.105])
	by mail-gw6.york.ac.uk with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.63)
	(envelope-from <gavin@ga9test2.york.ac.uk>)
	id 1JWFxt-00025D-FO
	for FreeBSD-gnats-submit@freebsd.org; Mon, 03 Mar 2008 19:04:45 +0000
Received: from ga9test2.york.ac.uk (localhost [127.0.0.1])
	by ga9test2.york.ac.uk (8.14.2/8.14.2) with ESMTP id m23J2nng048780
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 3 Mar 2008 19:02:49 GMT
	(envelope-from gavin@ga9test2.york.ac.uk)
Received: (from root@localhost)
	by ga9test2.york.ac.uk (8.14.2/8.14.2/Submit) id m23J2nKq048779;
	Mon, 3 Mar 2008 19:02:49 GMT
	(envelope-from gavin)
Message-Id: <200803031902.m23J2nKq048779@ga9test2.york.ac.uk>
Date: Mon, 3 Mar 2008 19:02:49 GMT
From: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
Reply-To: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Several ports have quotes around their COMMENTS
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         121329
>Category:       ports
>Synopsis:       Several ports have quotes around their COMMENTS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 03 19:40:03 UTC 2008
>Closed-Date:    Fri Mar 07 13:01:48 UTC 2008
>Last-Modified:  Fri Mar  7 13:10:02 UTC 2008
>Originator:     Gavin Atkinson
>Release:        FreeBSD 7.0-BETA3 amd64
>Organization:
>Environment:
System: FreeBSD ga9test2.york.ac.uk 7.0-BETA3 FreeBSD 7.0-BETA3 #0: Fri Nov 16 19:12:38 UTC 2007 root@myers.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64

>Description:
COMMENTs in port Makefiles shouldn't be quoted, but is in around 10 ports.  I've
also corrected a NO_CDROM in one of them, while there.

Note that only one of the ports in the patch is owned by myself, a few are
unmaintained and the rest have maintainers listed.  I haven't contacted the maintainers,
on the basis that this isn't a critical change or one that anyone is likely to
object to.
>How-To-Repeat:
	http://portsmon.freebsd.org/portoverview.py?category=x11&portname=chameleon
>Fix:

	

--- commentquotes.diff begins here ---
Index: ports/devel/sfslite-noopt/Makefile
===================================================================
RCS file: /usr/ncvs/ports/devel/sfslite-noopt/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile
--- ports/devel/sfslite-noopt/Makefile	29 Nov 2005 23:59:47 -0000	1.1
+++ ports/devel/sfslite-noopt/Makefile	3 Mar 2008 16:41:43 -0000
@@ -6,7 +6,7 @@
 #
 BUILD_MODE =     shared
 MASTERDIR=       ${.CURDIR}/../../devel/sfslite
-COMMENT=	"sfslite without optimization for debugging"
+COMMENT=	sfslite without optimization for debugging
 
 PKG_INSTALL=     ${MASTERDIR}/pkg-install
 
Index: ports/japanese/p5-WWW-2ch/Makefile
===================================================================
RCS file: /usr/ncvs/ports/japanese/p5-WWW-2ch/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- ports/japanese/p5-WWW-2ch/Makefile	8 Sep 2007 01:00:14 -0000	1.3
+++ ports/japanese/p5-WWW-2ch/Makefile	3 Mar 2008 16:51:08 -0000
@@ -13,7 +13,7 @@
 PKGNAMEPREFIX=	p5-
 
 MAINTAINER=	kaoru@kaisei.org
-COMMENT=	"Perl module for scraping of 2ch.net BBS"
+COMMENT=	Perl module for scraping of 2ch.net BBS
 
 RUN_DEPENDS=	${SITE_PERL}/LWP/UserAgent.pm:${PORTSDIR}/www/p5-libwww \
 	${SITE_PERL}/Class/Accessor/Fast.pm:${PORTSDIR}/devel/p5-Class-Accessor
Index: ports/math/p5-Bit-Vector-Minimal/Makefile
===================================================================
RCS file: /usr/ncvs/ports/math/p5-Bit-Vector-Minimal/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- ports/math/p5-Bit-Vector-Minimal/Makefile	8 Sep 2007 01:01:35 -0000	1.5
+++ ports/math/p5-Bit-Vector-Minimal/Makefile	3 Mar 2008 16:56:11 -0000
@@ -13,7 +13,7 @@
 PKGNAMEPREFIX=	p5-
 
 MAINTAINER=	perl@FreeBSD.org
-COMMENT=	"Object-oriented wrapper around Perl's vec()"
+COMMENT=	Object-oriented wrapper around Perl's vec()
 
 PERL_CONFIGURE=	yes
 
Index: ports/net-mgmt/scdp/Makefile
===================================================================
RCS file: /usr/ncvs/ports/net-mgmt/scdp/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- ports/net-mgmt/scdp/Makefile	31 Jan 2007 14:09:52 -0000	1.11
+++ ports/net-mgmt/scdp/Makefile	3 Mar 2008 17:03:57 -0000
@@ -13,7 +13,7 @@
 DISTNAME=	scdp-${PORTVERSION:S/.b/b/}
 
 MAINTAINER=	arved@FreeBSD.org
-COMMENT=	"Tool that sends CDP (CISCO Discovery Protocol) Packets"
+COMMENT=	Tool that sends CDP (CISCO Discovery Protocol) Packets
 
 BUILD_DEPENDS=	${LIBNET_CONFIG}:${PORTSDIR}/net/libnet10
 
Index: ports/print/epsonepl/Makefile
===================================================================
RCS file: /usr/ncvs/ports/print/epsonepl/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- ports/print/epsonepl/Makefile	19 May 2007 20:20:46 -0000	1.4
+++ ports/print/epsonepl/Makefile	3 Mar 2008 17:05:18 -0000
@@ -15,7 +15,7 @@
 EXTRACT_SUFX=	.tgz
 
 MAINTAINER=	ports@FreeBSD.org
-COMMENT=	"Printer filter for EPSON EPL-5700L etc"
+COMMENT=	Printer filter for EPSON EPL-5700L etc
 
 USE_GHOSTSCRIPT_RUN=	yes
 
Index: ports/security/mindterm-binary/Makefile
===================================================================
RCS file: /usr/ncvs/ports/security/mindterm-binary/Makefile,v
retrieving revision 1.9
diff -u -r1.9 Makefile
--- ports/security/mindterm-binary/Makefile	1 Oct 2005 06:09:00 -0000	1.9
+++ ports/security/mindterm-binary/Makefile	3 Mar 2008 17:07:12 -0000
@@ -14,12 +14,12 @@
 EXTRACT_ONLY=	${DISTNAME}${EXTRACT_SUFX}
 
 MAINTAINER=	ports@FreeBSD.org
-COMMENT=	"A full vt220 compatible Java SSH-1 client (not only for websites)"
+COMMENT=	A full vt220 compatible Java SSH-1 client (not only for websites)
 
 USE_ZIP=	yes
 NO_WRKSUBDIR=	yes
 NO_BUILD=	yes
-NO_CDROM=	"Do not sell for profit"
+NO_CDROM=	Do not sell for profit
 
 post-extract:
 	@${CP} ${DISTDIR}/mindterm-ssh.html ${WRKSRC}
Index: ports/security/steghide/Makefile
===================================================================
RCS file: /usr/ncvs/ports/security/steghide/Makefile,v
retrieving revision 1.28
diff -u -r1.28 Makefile
--- ports/security/steghide/Makefile	29 May 2007 15:45:19 -0000	1.28
+++ ports/security/steghide/Makefile	3 Mar 2008 17:08:13 -0000
@@ -14,7 +14,7 @@
 DISTNAME=	${PORTNAME}-${PORTVERSION:S/.b/b/}
 
 MAINTAINER=	arved@FreeBSD.org
-COMMENT=	"Steganography tool to hide data in binary files"
+COMMENT=	Steganography tool to hide data in binary files
 
 LIB_DEPENDS=	mcrypt.8:${PORTSDIR}/security/libmcrypt \
 		mhash.2:${PORTSDIR}/security/mhash
Index: ports/textproc/p5-XML-Filter-GenericChunk/Makefile
===================================================================
RCS file: /usr/ncvs/ports/textproc/p5-XML-Filter-GenericChunk/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- ports/textproc/p5-XML-Filter-GenericChunk/Makefile	24 Oct 2003 12:04:17 -0000	1.3
+++ ports/textproc/p5-XML-Filter-GenericChunk/Makefile	3 Mar 2008 17:11:53 -0000
@@ -14,7 +14,7 @@
 PKGNAMEPREFIX=	p5-
 
 MAINTAINER=	hansjoerg.pehofer@uibk.ac.at
-COMMENT=	"Base Class for SAX Filters parsing WellBallanced Chunks."
+COMMENT=	Base Class for SAX Filters parsing WellBallanced Chunks.
 
 BUILD_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/XML/LibXML.pm:${PORTSDIR}/textproc/p5-XML-LibXML \
 		${SITE_PERL}/XML/SAX.pm:${PORTSDIR}/textproc/p5-XML-SAX
Index: ports/textproc/p5-XML-Generator-PerlData/Makefile
===================================================================
RCS file: /usr/ncvs/ports/textproc/p5-XML-Generator-PerlData/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- ports/textproc/p5-XML-Generator-PerlData/Makefile	24 Oct 2003 12:04:19 -0000	1.3
+++ ports/textproc/p5-XML-Generator-PerlData/Makefile	3 Mar 2008 17:11:54 -0000
@@ -14,7 +14,7 @@
 PKGNAMEPREFIX=	p5-
 
 MAINTAINER=	hansjoerg.pehofer@uibk.ac.at
-COMMENT=	"Perl extension for generating SAX2 events from Perl data structures."
+COMMENT=	Perl extension for generating SAX2 events from Perl data structures.
 
 BUILD_DEPENDS=	${SITE_PERL}/XML/SAX.pm:${PORTSDIR}/textproc/p5-XML-SAX
 RUN_DEPENDS=	${BUILD_DEPENDS}
Index: ports/x11/chameleon/Makefile
===================================================================
RCS file: /usr/ncvs/ports/x11/chameleon/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- ports/x11/chameleon/Makefile	19 May 2007 20:25:57 -0000	1.7
+++ ports/x11/chameleon/Makefile	3 Mar 2008 17:16:35 -0000
@@ -17,7 +17,7 @@
 DISTNAME=	chameleon_${PORTVERSION}.orig
 
 MAINTAINER=	gavin.atkinson@ury.york.ac.uk
-COMMENT=	"Application for putting pictures or colors onto the root window"
+COMMENT=	Application for putting pictures or colors onto the root window
 
 LIB_DEPENDS=	Imlib.5:${PORTSDIR}/graphics/imlib
 
Index: ports/x11/gromit/Makefile
===================================================================
RCS file: /usr/ncvs/ports/x11/gromit/Makefile,v
retrieving revision 1.9
diff -u -r1.9 Makefile
--- ports/x11/gromit/Makefile	19 May 2007 20:26:36 -0000	1.9
+++ ports/x11/gromit/Makefile	3 Mar 2008 17:16:51 -0000
@@ -12,7 +12,7 @@
 MASTER_SITES=	http://www.home.unix-ag.org/simon/gromit/
 
 MAINTAINER=	sergei@FreeBSD.org
-COMMENT=	"GRaphics Over Miscellaneous Objects (Gromit)"
+COMMENT=	GRaphics Over Miscellaneous Objects (Gromit)
 
 USE_X_PREFIX=	yes
 USE_GNOME=	gtk20
--- commentquotes.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Fri Mar 7 13:01:47 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121329 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/121329: commit references a PR
Date: Fri,  7 Mar 2008 13:01:05 +0000 (UTC)

 miwi        2008-03-07 13:00:56 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/sfslite-noopt  Makefile 
     japanese/p5-WWW-2ch  Makefile 
     math/p5-Bit-Vector-Minimal Makefile 
     net-mgmt/scdp        Makefile 
     print/epsonepl       Makefile 
     security/mindterm-binary Makefile 
     security/steghide    Makefile 
     textproc/p5-XML-Filter-GenericChunk Makefile 
     x11/chameleon        Makefile 
     x11/gromit           Makefile 
   Log:
   - Remove unneeded quotes in COMMENTS
   
   PR:             121329
   Submitted by:   Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
   Approved by:    portmgr (erwin via irc)
   
   Revision  Changes    Path
   1.2       +1 -1      ports/devel/sfslite-noopt/Makefile
   1.4       +1 -1      ports/japanese/p5-WWW-2ch/Makefile
   1.6       +1 -1      ports/math/p5-Bit-Vector-Minimal/Makefile
   1.12      +1 -1      ports/net-mgmt/scdp/Makefile
   1.5       +1 -1      ports/print/epsonepl/Makefile
   1.10      +2 -2      ports/security/mindterm-binary/Makefile
   1.29      +1 -1      ports/security/steghide/Makefile
   1.4       +1 -1      ports/textproc/p5-XML-Filter-GenericChunk/Makefile
   1.8       +1 -1      ports/x11/chameleon/Makefile
   1.10      +1 -1      ports/x11/gromit/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
