From hmo@sep.oldach.net  Fri Feb 29 17:37:17 2008
Return-Path: <hmo@sep.oldach.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BF7D71065673
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 29 Feb 2008 17:37:17 +0000 (UTC)
	(envelope-from hmo@sep.oldach.net)
Received: from rigel.oldach.net (rigel.oldach.net [194.8.96.250])
	by mx1.freebsd.org (Postfix) with ESMTP id 478FC8FC42
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 29 Feb 2008 17:37:17 +0000 (UTC)
	(envelope-from hmo@sep.oldach.net)
Received: from sep.oldach.net (hmo.in-dsl.de [217.197.85.210])
	by rigel.oldach.net (8.14.2/8.14.2/hmo30jul04) with ESMTP id m1THbFvS014814
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Fri, 29 Feb 2008 18:37:15 +0100 (CET)
	(envelope-from hmo@sep.oldach.net)
Received: from sep.oldach.net (localhost [127.0.0.1])
	by sep.oldach.net (8.14.2/8.14.2/hmo26jun05) with ESMTP id m1THbEpO015742
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 29 Feb 2008 18:37:14 +0100 (CET)
	(envelope-from hmo@sep.oldach.net)
Received: (from hmo@localhost)
	by sep.oldach.net (8.14.2/8.14.2/Submit/hmo26jun05) id m1THbERd015741;
	Fri, 29 Feb 2008 18:37:14 +0100 (CET)
	(envelope-from hmo)
Message-Id: <200802291737.m1THbERd015741@sep.oldach.net>
Date: Fri, 29 Feb 2008 18:37:14 +0100 (CET)
From: Helge Oldach <ports-x11-xkeyboard-config-may07@oldach.net>
Reply-To: Helge Oldach <ports-x11-xkeyboard-config-may07@oldach.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: x11@freebsd.org
Subject: [patch] ports/x11/xkeyboard-config WITHOUT_NLS support
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         121230
>Category:       ports
>Synopsis:       [patch] ports/x11/xkeyboard-config WITHOUT_NLS support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-x11
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 29 17:40:00 UTC 2008
>Closed-Date:    Thu Mar 19 22:37:06 UTC 2009
>Last-Modified:  Thu Mar 19 22:40:00 UTC 2009
>Originator:     Helge Oldach
>Release:        FreeBSD 6.3-1132 i386
>Organization:
>Environment:

System: FreeBSD localhost 6.3-1132 FreeBSD 6.3-1132 #0: Fri Feb 15 19:26:49 CET 2008 toor@localhost:/usr/obj/usr/src/sys/HMO i386

>Description:

Please apply the trivial patch below, it will make xkeyboard-config
honor the standard WITHOUT_NLS knob.

>How-To-Repeat:
	
>Fix:

--- Makefile.ctm	Sun May 20 09:16:38 2007
+++ Makefile	Tue May 22 11:00:12 2007
@@ -22,13 +22,18 @@
 PREFIX=		${X11BASE}
 
 USE_BZIP2=	yes
-USE_ICONV=	yes
 USE_GMAKE=	yes
-USE_GETTEXT=	yes
 USE_PERL5_BUILD=yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS+=	--with-xkb-base=${PREFIX}/share/X11/xkb \
 			--with-xkb-rules-symlink=xorg
+
+.if defined(WITHOUT_NLS)
+CONFIGURE_ARGS+=        --disable-nls
+.else
+USE_ICONV=	yes
+USE_GETTEXT=	yes
+.endif
 
 post-install:
 	${MKDIR} /var/lib/xkb

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-x11 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Feb 29 17:40:14 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121230 
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Thu Mar 19 13:53:04 UTC 2009 
State-Changed-Why:  
This patch is ineffective: 

- port still installs gettext catalogues (.mo files) 
- gettext dependency is already inherited from the direct dependencies 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121230 
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Thu Mar 19 22:36:33 UTC 2009 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121230 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/121230: commit references a PR
Date: Thu, 19 Mar 2009 22:37:10 +0000 (UTC)

 pav         2009-03-19 22:36:53 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11/xkeyboard-config Makefile pkg-plist 
   Log:
   - Support WITHOUT_NLS
   
   PR:             ports/121230
   Submitted by:   Helge Oldach <ports-x11-xkeyboard-config-may07@oldach.net>
   
   Revision  Changes    Path
   1.12      +12 -2     ports/x11/xkeyboard-config/Makefile
   1.8       +30 -30    ports/x11/xkeyboard-config/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
