From nobody@FreeBSD.org  Mon Feb 18 16:54:50 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3E50116A418
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Feb 2008 16:54:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 3156013C457
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Feb 2008 16:54:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m1IGqMdD010845
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Feb 2008 16:52:22 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m1IGqMDn010844;
	Mon, 18 Feb 2008 16:52:22 GMT
	(envelope-from nobody)
Message-Id: <200802181652.m1IGqMDn010844@www.freebsd.org>
Date: Mon, 18 Feb 2008 16:52:22 GMT
From: Lars Stokholm <lars.stokholm@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: tor-devel doesn't log to /var/log/tor as it should
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: peter.thoenen@yahoo.com

>Number:         120811
>Category:       ports
>Synopsis:       [PATCH] security/tor-devel doesn't log to /var/log/tor as it should
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 18 17:00:03 UTC 2008
>Closed-Date:    Thu Mar 20 23:31:26 UTC 2008
>Last-Modified:  Thu Mar 20 23:40:00 UTC 2008
>Originator:     Lars Stokholm
>Release:        FreeBSD 7.0-RC2
>Organization:
>Environment:
FreeBSD stokholm 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #0: Sun Feb 17 01:06:34 CET 2008     root@stokholm:/usr/obj/usr/src/sys/STOKHOLM  i386
>Description:
tor-devel (possibly also tor) doesn't log to /var/log/tor as it's supposed to, because of a mistake made in the rc.d script.
>How-To-Repeat:

>Fix:
Patch attached.

Patch attached with submission follows:

--- /usr/local/etc/rc.d/tor_old	2008-02-18 17:46:08.000000000 +0100
+++ /usr/local/etc/rc.d/tor	2008-02-18 17:45:17.000000000 +0100
@@ -39,7 +39,7 @@
 required_dirs=${tor_datadir}
 pidfile=${tor_pidfile}
 command="/usr/local/bin/${name}"
-command_args="-f ${tor_conf} --PidFile ${tor_pidfile} --RunAsDaemon 1 --DataDirectory ${tor_datadir} --User ${tor_user} --Group ${tor_group} --Log \"notice file ${tor_logfile}\""
+command_args="-f ${tor_conf} --PidFile ${tor_pidfile} --RunAsDaemon 1 --DataDirectory ${tor_datadir} --User ${tor_user} --Group ${tor_group} --Log notice\ file\ ${tor_logfile}"
 extra_commands="log"
 log_cmd="${name}_log"
 


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Feb 18 20:06:50 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120811 

From: Peter Thoenen <peter.thoenen@yahoo.com>
To: bug-followup@FreeBSD.org
Cc: lars.stokholm@gmail.com
Subject: Re: ports/120811: [PATCH] security/tor-devel doesn't log to /var/log/tor
 as it should
Date: Wed, 19 Mar 2008 20:06:14 -0400

 Approved
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Thu Mar 20 00:55:03 UTC 2008 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120811 
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Thu Mar 20 07:54:44 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120811 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Thu Mar 20 23:31:25 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120811 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/120811: commit references a PR
Date: Thu, 20 Mar 2008 23:31:11 +0000 (UTC)

 miwi        2008-03-20 23:31:05 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/tor         Makefile 
     security/tor/files   tor.in 
     security/tor-devel   Makefile 
     security/tor-devel/files tor.in 
   Log:
   - Fix Log dir
   - Bump PORTREVISION
   
   PR:             120811
   Submitted by:   Lars Stokholm <lars.stokholm@gmail.com>
   Approved by:    maintainers
   
   Revision  Changes    Path
   1.58      +1 -0      ports/security/tor-devel/Makefile
   1.7       +2 -2      ports/security/tor-devel/files/tor.in
   1.36      +1 -0      ports/security/tor/Makefile
   1.4       +2 -2      ports/security/tor/files/tor.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
