From obrien@NUXI.org  Tue Feb  5 01:59:19 2008
Return-Path: <obrien@NUXI.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DBA7D16A420
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  5 Feb 2008 01:59:19 +0000 (UTC)
	(envelope-from obrien@NUXI.org)
Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85])
	by mx1.freebsd.org (Postfix) with ESMTP id C6DF013C458
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  5 Feb 2008 01:59:19 +0000 (UTC)
	(envelope-from obrien@NUXI.org)
Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1])
	by dragon.nuxi.org (8.14.1/8.14.1) with ESMTP id m151xJrh014799
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 4 Feb 2008 17:59:19 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.org)
Received: (from obrien@localhost)
	by dragon.nuxi.org (8.14.1/8.14.1/Submit) id m151xJ4d014798;
	Mon, 4 Feb 2008 17:59:19 -0800 (PST)
	(envelope-from obrien)
Message-Id: <200802050159.m151xJ4d014798@dragon.nuxi.org>
Date: Mon, 4 Feb 2008 17:59:19 -0800 (PST)
From: "David O'Brien" <obrien@freebsd.org>
Reply-To: "David O'Brien" <obrien@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: style.Makefile(5) nit
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         120276
>Category:       ports
>Synopsis:       bsd.port.mk - style.Makefile(5) nit
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 05 02:00:06 UTC 2008
>Closed-Date:    Tue Mar 11 23:45:24 UTC 2008
>Last-Modified:  Tue Mar 11 23:50:10 UTC 2008
>Originator:     David O'Brien
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD dragon.NUXI.org 8.0-CURRENT FreeBSD 8.0-CURRENT #576: Tue Jan 1 18:37:43 PST 2008 rootk@dragon:/SRC/fbsd/sys/i386/compile/DRAGON i386


	
>Description:

	bsd.port.mk has a usage of '@', where the FreeBSD standard is to
	spell '@' ${.TARGET}.
	
>How-To-Repeat:
	vi ports/Mk/bsd.port.mk
>Fix:

Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.589
diff -u -p -r1.589 bsd.port.mk
--- bsd.port.mk	17 Oct 2007 10:12:24 -0000	1.589
+++ bsd.port.mk	4 Feb 2008 19:34:47 -0000
@@ -5411,7 +5455,7 @@ ${.CURDIR}/README.html:
 					$${__softMAKEFLAGS} pretty-print-run-depends-list)"'|' \
 			-e 's|%%TOP%%|'"$$(${ECHO_CMD} ${CATEGORIES} | \
 							   ${SED} -e 's| .*||' -e 's|[^/]*|..|g')"'/..|' \
-		${TEMPLATES}/README.port >> $@
+		${TEMPLATES}/README.port >> ${.TARGET}
 
 # The following two targets require an up-to-date INDEX in ${PORTSDIR}
 
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Feb 5 12:12:52 UTC 2008 
Responsible-Changed-Why:  
bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120276 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Tue Mar 11 23:43:10 UTC 2008 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120276 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/120276: commit references a PR
Date: Tue, 11 Mar 2008 23:45:12 +0000 (UTC)

 pav         2008-03-11 23:45:04 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.port.mk bsd.port.subdir.mk 
                          bsd.xorg.mk 
   Log:
   - Automatically append -fno-strict-aliasing to CFLAGS when -O2 or higher
     optimizations are enabled.
   
   PR:             ports/121363
   Submitted by:   obrien
   
   - Change USE_XPM variable to use USE_XORG framework, and lose implied USE_XLIB
   
   PR:             ports/113799
   Submitted by:   des (based on)
   Patch by:       pav
   
   - Teach USE_LDCONFIG to do the right thing when used with USE_LINUX_PREFIX
   
   PR:             ports/118212
   Original patch: vd
   Patch by:       pav
   
   - Allow tab as well as space in param.h for OSVERSION determination
   
   PR:             ports/117507
   Submitted by:   erwin
   
   - Reverse the condition so EXTRACT_PRESERVE_OWNERSHIP now work as advertised
   
   PR:             ports/117916
   Submitted by:   tobez
   
   - Assorted comment fixes
   
   PR:             ports/118054
   Submitted by:   linimon
   
   - Style nit ($@ -> ${.TARGET})
   
   PR:             ports/120276
   Submitted by:   obrien
   
   Revision  Changes    Path
   1.591     +38 -14    ports/Mk/bsd.port.mk
   1.73      +3 -3      ports/Mk/bsd.port.subdir.mk
   1.5       +2 -8      ports/Mk/bsd.xorg.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
