From amdmi3@amdmi3.ru  Tue Feb  5 01:25:07 2008
Return-Path: <amdmi3@amdmi3.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DE6FC16A418
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  5 Feb 2008 01:25:07 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from cp65.agava.net (cp65.agava.net [89.108.66.215])
	by mx1.freebsd.org (Postfix) with ESMTP id 9893F13C45B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  5 Feb 2008 01:25:07 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by cp65.agava.net with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.63 (FreeBSD))
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1JMCbD-000E6W-Vb
	for FreeBSD-gnats-submit@freebsd.org; Tue, 05 Feb 2008 04:27:47 +0300
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id 35EA27E45
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  5 Feb 2008 04:25:50 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
	id 11DE917031; Tue,  5 Feb 2008 04:25:08 +0300 (MSK)
Message-Id: <20080205012508.11DE917031@hades.panopticon>
Date: Tue,  5 Feb 2008 04:25:08 +0300 (MSK)
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
Reply-To: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] games/pathological: won't start
X-Send-Pr-Version: 3.113
X-GNATS-Notify: janos.mohacsi@bsd.hu

>Number:         120275
>Category:       ports
>Synopsis:       [PATCH] games/pathological: won't start
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 05 01:30:03 UTC 2008
>Closed-Date:    Wed Feb 20 13:21:03 UTC 2008
>Last-Modified:  Wed Feb 20 13:30:01 UTC 2008
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 7.0-RC1 i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 7.0-RC1 FreeBSD 7.0-RC1 #0: Sat Jan 5 03:26:52 MSK 2008 root@hades.panopticon:/usr/obj/usr/src/sys/HADES i386


>Description:
pathological won't start:

% pathological 
  File "/usr/local/share/pathological/pathological.py", line 1850
SyntaxError: Non-ASCII character '\xa9' in file /usr/local/share/pathological/pathological.py on line 1850, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details
%

most probably, it became broken with newer python (2.4 or 2.5).

The patch attached fixes the problem (also sent to upstream).

While here, make use of SF macro and correct redundancy in COMMENT.

>How-To-Repeat:
>Fix:

--- pathological.patch begins here ---
diff -ruN pathological.orig/Makefile pathological/Makefile
--- pathological.orig/Makefile	2008-02-05 04:09:20.000000000 +0300
+++ pathological/Makefile	2008-02-05 04:11:42.000000000 +0300
@@ -7,13 +7,12 @@
 
 PORTNAME=	pathological
 PORTVERSION=	1.1.3
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	games
-MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
-MASTER_SITE_SUBDIR=	${PORTNAME}
+MASTER_SITES=	SF
 
 MAINTAINER=	janos.mohacsi@bsd.hu
-COMMENT=	Pathological is an enriched clone of the game "Logical"
+COMMENT=	Enriched clone of the game "Logical"
 
 RUN_DEPENDS=	${PYTHON_SITELIBDIR}/pygame/__init__.py:${PORTSDIR}/devel/py-game
 
diff -ruN pathological.orig/files/patch-pathological.py pathological/files/patch-pathological.py
--- pathological.orig/files/patch-pathological.py	1970-01-01 03:00:00.000000000 +0300
+++ pathological/files/patch-pathological.py	2008-02-05 04:10:05.000000000 +0300
@@ -0,0 +1,11 @@
+--- pathological.py.orig	2003-07-17 18:12:30.000000000 +0400
++++ pathological.py	2008-02-05 04:09:49.000000000 +0300
+@@ -1847,7 +1847,7 @@
+ 	scroller_font_height = 28
+ 	scroller_rect = (10,550,780,scroller_font_height)
+ 	scroller_text = \
+-		"   Copyright  2003  John-Paul Gignac.   "+ \
++		"   Copyright (C) 2003  John-Paul Gignac.   "+ \
+ 		"   Soundtrack by Matthias Le Bidan.   "+ \
+ 		"   Board designs contributed by Mike Brenneman and Kim Gignac.   "+ \
+ 		"   To contribute your own board designs, see the website:  "+ \
--- pathological.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Feb 5 01:30:10 UTC 2008 
Responsible-Changed-Why:  
miwi@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120275 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Feb 5 01:30:14 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120275 

From: Mohacsi Janos <mohacsi@niif.hu>
To: bug-followup@FreeBSD.ORG
Cc: janos.mohacsi@bsd.hu
Subject: Re: ports/120275: [PATCH] games/pathological: won't start
Date: Tue, 19 Feb 2008 22:35:00 +0100 (CET)

 Approved.
 Best Regards,
 
 Janos Mohacsi
 Network Engineer, Research Associate, Head of Network Planning and Projects
 NIIF/HUNGARNET, HUNGARY
 Key 70EF9882: DEC2 C685 1ED4 C95A 145F  4300 6F64 7B00 70EF 9882
 
 On Tue, 5 Feb 2008, Edwin Groothuis wrote:
 
 > Maintainer of games/pathological,
 >
 > Please note that PR ports/120275 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/120275
 >
 > -- 
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
State-Changed-From-To: feedback->closed 
State-Changed-By: miwi 
State-Changed-When: Wed Feb 20 13:21:02 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120275 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/120275: commit references a PR
Date: Wed, 20 Feb 2008 13:21:01 +0000 (UTC)

 miwi        2008-02-20 13:20:55 UTC
 
   FreeBSD ports repository
 
   Modified files:
     games/pathological   Makefile 
   Added files:
     games/pathological/files patch-pathological.py 
   Log:
   - Fix start crash
   - Use SF macro
   
   PR:             120275
   Submitted by:   Dmitry Marakasov <amdmi3@amdmi3.ru>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.5       +3 -4      ports/games/pathological/Makefile
   1.1       +11 -0     ports/games/pathological/files/patch-pathological.py (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
