From rafan@svm.csie.ntu.edu.tw  Sun Jan 27 10:32:35 2008
Return-Path: <rafan@svm.csie.ntu.edu.tw>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 55A9816A418;
	Sun, 27 Jan 2008 10:32:35 +0000 (UTC)
	(envelope-from rafan@svm.csie.ntu.edu.tw)
Received: from svm.csie.ntu.edu.tw (svm.csie.ntu.edu.tw [140.112.90.75])
	by mx1.freebsd.org (Postfix) with ESMTP id 0046413C45A;
	Sun, 27 Jan 2008 10:32:34 +0000 (UTC)
	(envelope-from rafan@svm.csie.ntu.edu.tw)
Received: from svm.csie.ntu.edu.tw (localhost [127.0.0.1])
	by svm.csie.ntu.edu.tw (8.14.1/8.14.1) with ESMTP id m0RAA8sR013268;
	Sun, 27 Jan 2008 18:10:08 +0800 (CST)
	(envelope-from rafan@svm.csie.ntu.edu.tw)
Received: (from rafan@localhost)
	by svm.csie.ntu.edu.tw (8.14.1/8.14.1/Submit) id m0RAA8th041534;
	Sun, 27 Jan 2008 18:10:08 +0800 (CST)
	(envelope-from rafan)
Message-Id: <200801271010.m0RAA8th041534@svm.csie.ntu.edu.tw>
Date: Sun, 27 Jan 2008 18:10:08 +0800 (CST)
From: Rong-En Fan <rafan@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: cjh@freebsd.org
Subject: [PATCH] print/magicfilter: Use sysutils/file if it exists
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         120033
>Category:       ports
>Synopsis:       [PATCH] print/magicfilter: Use sysutils/file if it exists
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    cjh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 27 10:40:01 UTC 2008
>Closed-Date:    Mon Feb 04 11:42:01 UTC 2008
>Last-Modified:  Mon Feb  4 11:50:01 UTC 2008
>Originator:     Rong-En Fan
>Release:        FreeBSD 6.3-PRERELEASE amd64
>Organization:
NTU CSIE
>Environment:
>Description:
In ports/96495, I make this port depends on sysutils/file unconditionally
as at that time our libmagic in base is too old. However, the situation
changes now, our libmagic in 6.x to 8.x are new enough. And, with
unknown reason that with new X11BASE=LOCALBASE environment, magicfilter
can not correctly recognize file format when linking to sysutils/file.
So I think it's better to make magicfilter uses sysutils/file only if
it's installed.

Port maintainer (cjh@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- magicfilter-2.3.h_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/print/magicfilter/Makefile,v
retrieving revision 1.18
diff -u -u -r1.18 Makefile
--- Makefile	24 Sep 2007 08:39:23 -0000	1.18
+++ Makefile	27 Jan 2008 10:06:04 -0000
@@ -7,17 +7,13 @@
 
 PORTNAME=	magicfilter
 PORTVERSION=	2.3.h
-PORTREVISION=	1
-PORREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	print
 MASTER_SITES=	http://www.pell.portland.or.us/~orc/Code/magicfilter/
 
 MAINTAINER=	cjh@FreeBSD.org
 COMMENT=	Customizable, extensible automatic printer filter
 
-BUILD_DEPENDS=	${LOCALBASE}/lib/libmagic.so:${PORTSDIR}/sysutils/file
-RUN_DEPENDS=	${BUILD_DEPENDS}
-
 USE_GHOSTSCRIPT=	yes
 
 GNU_CONFIGURE=	yes
@@ -30,4 +26,11 @@
 MAN5=		magicfilter.5
 MAN8=		magicfilter.8
 
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+.if exists(${LOCALBASE}/lib/libmagic.so)
+BUILD_DEPENDS+=	${LOCALBASE}/lib/libmagic.so:${PORTSDIR}/sysutils/file
+RUN_DEPENDS+=	${BUILD_DEPENDS}
+.endif
+
+.include <bsd.port.post.mk>
--- magicfilter-2.3.h_2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->cjh 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Jan 27 10:40:07 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120033 
State-Changed-From-To: open->closed 
State-Changed-By: cjh 
State-Changed-When: Mon Feb 4 11:41:44 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120033 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/120033: commit references a PR
Date: Mon,  4 Feb 2008 11:40:07 +0000 (UTC)

 cjh         2008-02-04 11:39:58 UTC
 
   FreeBSD ports repository
 
   Modified files:
     print/magicfilter    Makefile 
   Log:
   depends on sysutils/file only if it's installed.
   
   PR:             ports/120033
   Submitted by:   rafan
   
   Revision  Changes    Path
   1.19      +9 -6      ports/print/magicfilter/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
