From sec@42.org  Mon Jan 21 22:26:54 2008
Return-Path: <sec@42.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CDE7916A468
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 Jan 2008 22:26:54 +0000 (UTC)
	(envelope-from sec@42.org)
Received: from ice.42.org (v6.42.org [IPv6:2001:608:9::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 76E2F13C465
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 Jan 2008 22:26:54 +0000 (UTC)
	(envelope-from sec@42.org)
Received: by ice.42.org (Postfix, from userid 1000)
	id 3BA7FB83F; Mon, 21 Jan 2008 23:26:52 +0100 (CET)
Message-Id: <20080121222652.3BA7FB83F@ice.42.org>
Date: Mon, 21 Jan 2008 23:26:52 +0100 (CET)
From: Stefan `Sec` Zehl <sec@42.org>
Reply-To: Stefan `Sec` Zehl <sec@42.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Juergen Lock <nox@jelal.kn-bremen.de>
Subject: qemu port fails to build on freebsd-6
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         119875
>Category:       ports
>Synopsis:       emulators/qemu port fails to build on freebsd-6
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    nox
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 21 22:30:07 UTC 2008
>Closed-Date:    Sat Jan 26 00:42:13 UTC 2008
>Last-Modified:  Sat Jan 26 00:42:13 UTC 2008
>Originator:     Stefan `Sec` Zehl
>Release:        FreeBSD 6.3-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD ice 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #40: Sat Nov 24 17:10:45 CET 2007 root@:/export/obj/export/src/sys/ICE i386


	
>Description:

portupgrade fails to upgrade the qemu port for me. It fails with:

cc -O2 -fno-strict-aliasing -pipe -Wall -O2 -g -fno-strict-aliasing -I. -I/export/ports/emulators/qemu/work/qemu-0.9.1 -MMD -MP -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/export/ports/emulators/qemu/work/qemu-0.9.1/slirp    -c -o usb-bsd.o usb-bsd.c
usb-bsd.c: In function `usb_host_handle_control':
usb-bsd.c:177: error: `USBD_SHORT_XFER_OK' undeclared (first use in this function)
usb-bsd.c:177: error: (Each undeclared identifier is reported only once
usb-bsd.c:177: error: for each function it appears in.)
usb-bsd.c: In function `usb_info_device':
usb-bsd.c:574: warning: implicit declaration of function `term_printf'
gmake: *** [usb-bsd.o] Error 1
*** Error code 2


>How-To-Repeat:

portupgrade -R qemu\* 

>Fix:

the define USBD_SHORT_XFER_OK is found in <dev/usb2/usb.h> instead of the
included <dev/usb/usb.h> although I have no idea why there are two
different usb subdirectories %)

	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->nox 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jan 21 23:25:48 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119875 
State-Changed-From-To: open->feedback 
State-Changed-By: nox 
State-Changed-When: Wed Jan 23 23:28:05 UTC 2008 
State-Changed-Why:  
Hmm.  If you check http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/usb/usb.h 
you'll see that USBD_SHORT_XFER_OK was added in 1.13, way before 
6.3-PRERELEASE.  Are you using hps' usb stack maybe? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119875 

From: Stefan `Sec` Zehl <sec@42.org>
To: FreeBSD-gnats-submit@FreeBSD.org, Juergen Lock <nox@jelal.kn-bremen.de>,
	nox@FreeBSD.org
Cc:  
Subject: Re: ports/119875: qemu port fails to build on freebsd-6
Date: Fri, 25 Jan 2008 00:13:02 +0100

 On Tue, Jan 22, 2008 at 03:05 +0100, Juergen Lock wrote:
 > Hmm, can't reproduce.
 
 Oh. Strange.
 
 | ice:~>l /usr/include/dev/usb/usb.h
 | -r--r--r--  1 root  wheel  22174 Jan 18 20:24 /usr/include/dev/usb/usb.h
 | ice:~>l /usr/include/dev/usb2/usb.h
 | -r--r--r--  1 root  wheel  22331 Oct  5  2006 /usr/include/dev/usb2/usb.h
 | ice:~>grep USBD_SHORT_XFER_OK /usr/include/dev/*/usb.h
 | /usr/include/dev/usb2/usb.h:#define USBD_SHORT_XFER_OK       0x0004 /* allow short reads */
 
 Looks like something is amiss on my system then.
 
 >  Are you using hps' usb stack maybe?  Other than that I'm out of
 >  ideas...
 
 I don't know what "hps' usb stack" is, but I have installed the i4b
 patches on my system, perhaps they are the cause of this. I will look
 into that, you can probably close this report then.
 
 Thanks,
     Sec
 --
 (Learn Lisp.  (Really.  (I'm serious.  (Trust me. (It rocks all
 over.)))))
 -- Matt Curtin <cmcurtin@interhack.net> on freebsd-chat
State-Changed-From-To: feedback->closed 
State-Changed-By: nox 
State-Changed-When: Sat Jan 26 00:42:11 UTC 2008 
State-Changed-Why:  
Originator confirms he is not running the original code. (iirc hps' usb 
stack started out as part of his i4b patches.) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119875 
>Unformatted:
