From nobody@FreeBSD.org  Thu Jan 17 20:42:46 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2855116A46B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 17 Jan 2008 20:42:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 2CD0313C46B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 17 Jan 2008 20:42:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m0HKfOpC027235
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 17 Jan 2008 20:41:24 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m0HKfOrs027234;
	Thu, 17 Jan 2008 20:41:24 GMT
	(envelope-from nobody)
Message-Id: <200801172041.m0HKfOrs027234@www.freebsd.org>
Date: Thu, 17 Jan 2008 20:41:24 GMT
From: Felippe de Meirelles Motta <lippemail@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [UPDATE] x11-fm/gprename
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: carpetsmoker@xs4all.nl

>Number:         119758
>Category:       ports
>Synopsis:       [UPDATE] x11-fm/gprename
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    araujo
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 17 20:50:01 UTC 2008
>Closed-Date:    Sat Jan 26 13:26:43 UTC 2008
>Last-Modified:  Sat Jan 26 13:30:01 UTC 2008
>Originator:     Felippe de Meirelles Motta
>Release:        FreeBSD 7.0-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD 7.0-PRERELEASE #0: Thu Jan 10 01:55:37 BRST 2008
    lippe@shire.freebsd.org:/usr/obj/usr/src/sys/GENERIC

>Description:
- Updated to 2.5 version;
- Use SF macro;
- Now install all requirements: Glib Perl, Perl Gettext, Libintl Perl and Gtk2 Perl;
- Updated pkg-plist;
- Some minor changes in Makefile that were unnecessary.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/x11-fm/gprename/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- Makefile	31 Jul 2007 11:24:19 -0000	1.13
+++ Makefile	17 Jan 2008 20:21:17 -0000
@@ -7,16 +7,18 @@
 #
 
 PORTNAME=	gprename
-PORTVERSION=	2.4
+PORTVERSION=	2.5
 PORTEPOCH=	1
 CATEGORIES=	x11-fm
-MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
-MASTER_SITE_SUBDIR=	${PORTNAME}
+MASTER_SITES=	SF
 
 MAINTAINER=	carpetsmoker@xs4all.nl
 COMMENT=	Perl script for renaming multiple files
 
-RUN_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Gtk2.pm:${PORTSDIR}/x11-toolkits/p5-Gtk2
+RUN_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Gtk2.pm:${PORTSDIR}/x11-toolkits/p5-Gtk2 \
+		${SITE_PERL}/${PERL_ARCH}/Glib.pm:${PORTSDIR}/devel/p5-Glib2 \
+		${SITE_PERL}/${PERL_ARCH}/Locale/gettext.pm:${PORTSDIR}/devel/p5-Locale-gettext \
+		p5-Locale-libintl>=0:${PORTSDIR}/devel/p5-Locale-libintl
 
 USE_BZIP2=	yes
 USE_PERL5_RUN=	yes
@@ -27,17 +29,12 @@
 MANCOMPRESSED=	no
 
 post-patch:
-	@${REINPLACE_CMD} 's|/usr/|${PREFIX}/|' \
-		${WRKSRC}/bin/gprename
-	@${REINPLACE_CMD} -e 's|/usr/local|${PREFIX}|; \
-		s|$$(CURDIR)|$$(.CURDIR)|; \
-		s|share/man|man|;' \
-		${WRKSRC}/Makefile
+	@${REINPLACE_CMD} -e 's|share/man|man|g' ${WRKSRC}/Makefile
 
 post-install:
 .if !defined(NOPORTDOCS)
 	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/README ${WRKSRC}/COPYING ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /home/ncvs/ports/x11-fm/gprename/distinfo,v
retrieving revision 1.9
diff -u -r1.9 distinfo
--- distinfo	31 Jul 2007 11:24:19 -0000	1.9
+++ distinfo	17 Jan 2008 20:21:17 -0000
@@ -1,3 +1,3 @@
-MD5 (gprename-2.4.tar.bz2) = fc8abed7a5bb141d20a123b448dc53a3
-SHA256 (gprename-2.4.tar.bz2) = 43c9ee724fc5b5ff4eff121e6e54f42c6f2892f6158a9ce2ccb8fc7995ab01ca
-SIZE (gprename-2.4.tar.bz2) = 47859
+MD5 (gprename-2.5.tar.bz2) = f3906c70ed3a24f4ade75c5787ecd969
+SHA256 (gprename-2.5.tar.bz2) = 54747ef7a099ee1bacab3cc2bfbe0866ae05118cda5c7f621077ac0d277783ab
+SIZE (gprename-2.5.tar.bz2) = 50278
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/x11-fm/gprename/pkg-plist,v
retrieving revision 1.2
diff -u -r1.2 pkg-plist
--- pkg-plist	31 Jul 2007 11:24:19 -0000	1.2
+++ pkg-plist	17 Jan 2008 20:21:17 -0000
@@ -3,6 +3,7 @@
 share/pixmaps/gprename/gprename.png
 share/pixmaps/gprename/gprename_debian_menu_icon.xpm
 share/pixmaps/gprename/gprename_nautilus-action.png
+share/locale/ca/LC_MESSAGES/gprename.mo
 share/locale/de/LC_MESSAGES/gprename.mo
 share/locale/es/LC_MESSAGES/gprename.mo
 share/locale/fr/LC_MESSAGES/gprename.mo


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jan 17 20:50:05 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119758 

From: Martin Tournoij <carpetsmoker@xs4all.nl>
To: bug-followup@FreeBSD.org, lippemail@gmail.com
Cc:  
Subject: Re: ports/119758: [UPDATE] x11-fm/gprename
Date: Thu, 17 Jan 2008 23:10:04 +0100

 --pf9I7BMVVzbSWLtt
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Thank you for the PR Felippe.
 A new patch is attached in this email:
 
 - Replacing /usr/local with PREFIX is needed for people who have a
 	different prefix.
 
 - CURDIR works for GNU make, but BSD make uses .CURDIR and doesn't
 	know about CURDIR (Your default make is GNU make..?).
 
 - p5-Locale-gettext isn't needed, and p5-Glib is already a dependency
 	(Through Gtk2, and probably others).
 
 - PREFIX/bin/perl should be used whenever possible, /usr/bin/perl is a
 	leftover from when perl was included in FreeBSD base and it will
 	probably be removed at some point in the future.
 
 Regards,
 Martin Tournoij
 
 --pf9I7BMVVzbSWLtt
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="gprename.diff"
 
 diff -urN --exclude CVS --exclude '*.test' /ports/x11-fm/gprename/Makefile ./Makefile
 --- /ports/x11-fm/gprename/Makefile	2007-07-31 13:24:19.000000000 +0200
 +++ ./Makefile	2008-01-17 23:03:03.000000000 +0100
 @@ -2,21 +2,21 @@
  # Date created:				2004-03-15
  # Whom:					trevor
  #
 -# $Carpetsmoker: ports/x11-fm/gprename/Makefile,v 1.6 2007/07/20 07:31:57 carpetsmoker Exp $
 +# $Carpetsmoker: ports/x11-fm/gprename/Makefile,v 1.8 2007/11/18 11:10:39 carpetsmoker Exp $
  # $FreeBSD: ports/x11-fm/gprename/Makefile,v 1.13 2007/07/31 11:24:19 arved Exp $
  #
  
  PORTNAME=	gprename
 -PORTVERSION=	2.4
 +PORTVERSION=	2.5
  PORTEPOCH=	1
  CATEGORIES=	x11-fm
 -MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 -MASTER_SITE_SUBDIR=	${PORTNAME}
 +MASTER_SITES=	SOURCEFORGE
  
  MAINTAINER=	carpetsmoker@xs4all.nl
  COMMENT=	Perl script for renaming multiple files
  
 -RUN_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Gtk2.pm:${PORTSDIR}/x11-toolkits/p5-Gtk2
 +RUN_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Gtk2.pm:${PORTSDIR}/x11-toolkits/p5-Gtk2 \
 +		${SITE_PERL}/${PERL_ARCH}/Locale/gettext.pm:${PORTSDIR}/devel/p5-Locale-gettext
  
  USE_BZIP2=	yes
  USE_PERL5_RUN=	yes
 @@ -37,7 +37,7 @@
  post-install:
  .if !defined(NOPORTDOCS)
  	@${MKDIR} ${DOCSDIR}
 -	${INSTALL_DATA} ${WRKSRC}/README ${WRKSRC}/COPYING ${DOCSDIR}
 +	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
  .endif
  
  .include <bsd.port.mk>
 diff -urN --exclude CVS --exclude '*.test' /ports/x11-fm/gprename/distinfo ./distinfo
 --- /ports/x11-fm/gprename/distinfo	2007-07-31 13:24:19.000000000 +0200
 +++ ./distinfo	2007-11-14 08:08:30.000000000 +0100
 @@ -1,3 +1,3 @@
 -MD5 (gprename-2.4.tar.bz2) = fc8abed7a5bb141d20a123b448dc53a3
 -SHA256 (gprename-2.4.tar.bz2) = 43c9ee724fc5b5ff4eff121e6e54f42c6f2892f6158a9ce2ccb8fc7995ab01ca
 -SIZE (gprename-2.4.tar.bz2) = 47859
 +MD5 (gprename-2.5.tar.bz2) = f3906c70ed3a24f4ade75c5787ecd969
 +SHA256 (gprename-2.5.tar.bz2) = 54747ef7a099ee1bacab3cc2bfbe0866ae05118cda5c7f621077ac0d277783ab
 +SIZE (gprename-2.5.tar.bz2) = 50278
 diff -urN --exclude CVS --exclude '*.test' /ports/x11-fm/gprename/pkg-plist ./pkg-plist
 --- /ports/x11-fm/gprename/pkg-plist	2007-07-31 13:24:19.000000000 +0200
 +++ ./pkg-plist	2008-01-17 23:03:35.000000000 +0100
 @@ -3,6 +3,7 @@
  share/pixmaps/gprename/gprename.png
  share/pixmaps/gprename/gprename_debian_menu_icon.xpm
  share/pixmaps/gprename/gprename_nautilus-action.png
 +share/locale/ca/LC_MESSAGES/gprename.mo
  share/locale/de/LC_MESSAGES/gprename.mo
  share/locale/es/LC_MESSAGES/gprename.mo
  share/locale/fr/LC_MESSAGES/gprename.mo
 
 --pf9I7BMVVzbSWLtt--
Responsible-Changed-From-To: freebsd-ports-bugs->araujo 
Responsible-Changed-By: araujo 
Responsible-Changed-When: Fri Jan 18 00:12:50 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119758 

From: Marcelo Araujo <araujobsdport@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: ports/119758: [UPDATE] x11-fm/gprename
Date: Sat, 19 Jan 2008 23:07:56 -0200

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig66697A8EDB0B360DD5168019
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Hey all,
 
 What you think in using WITH_NLS to control the internationalization file=
 s?
 Could you please think about that?
 
 Thanks about the work!
 
 
 
 Best Regards,
 
 --=20
 Marcelo Araujo            (__)
 araujo@FreeBSD.org     \\\'',)
 http://www.FreeBSD.org   \/  \ ^
 Power To Server.         .\. /_)
 
 
 
 --------------enig66697A8EDB0B360DD5168019
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.7 (FreeBSD)
 
 iD8DBQFHkp7sovxJd1Pkz6gRAk8SAJ0Xo8HP/zBerx7g44THHVTcJrCr5wCaAh30
 rfJV112ncYjYcCKpBqKdPKg=
 =9yjV
 -----END PGP SIGNATURE-----
 
 --------------enig66697A8EDB0B360DD5168019--

From: Felippe de Meirelles Motta <lippemail@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/119758: [UPDATE] x11-fm/gprename
Date: Thu, 24 Jan 2008 19:51:29 -0200

 Hello araujo@,
 
 I see that this software use Makefile only for install all files, not 
 use an configure with make options to disable any feature.
 
 My cheers! :)
State-Changed-From-To: feedback->closed 
State-Changed-By: araujo 
State-Changed-When: Sat Jan 26 13:26:42 UTC 2008 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119758 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/119758: commit references a PR
Date: Sat, 26 Jan 2008 13:26:19 +0000 (UTC)

 araujo      2008-01-26 13:26:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11-fm/gprename      Makefile distinfo pkg-plist 
   Log:
   - Update to 2.5.
   - Use SF macro.
   
   PR:             ports/119758
   Submitted by:   Felippe de Meirelles Motta <lippemail@gmail.com>
   Reworked by:    Martin Tournoij <carpetsmoker@xs4all.nl> (maintainer)
   Approved by:    stas (mentor, implicit)
   
   Revision  Changes    Path
   1.14      +5 -6      ports/x11-fm/gprename/Makefile
   1.10      +3 -3      ports/x11-fm/gprename/distinfo
   1.3       +1 -0      ports/x11-fm/gprename/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
