From rucci@smurfbsd.warganizer.com  Mon Jan  7 02:49:41 2008
Return-Path: <rucci@smurfbsd.warganizer.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3CCA716A417;
	Mon,  7 Jan 2008 02:49:41 +0000 (UTC)
	(envelope-from rucci@smurfbsd.warganizer.com)
Received: from mta4.srv.hcvlny.cv.net (mta4.srv.hcvlny.cv.net [167.206.4.199])
	by mx1.freebsd.org (Postfix) with ESMTP id 1450C13C447;
	Mon,  7 Jan 2008 02:49:40 +0000 (UTC)
	(envelope-from rucci@smurfbsd.warganizer.com)
Received: from smurfbsd.warganizer.com
 (ool-182dc652.dyn.optonline.net [24.45.198.82]) by mta4.srv.hcvlny.cv.net
 (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007))
 with ESMTP id <0JU90005A5434J80@mta4.srv.hcvlny.cv.net>; Sun,
 06 Jan 2008 21:19:16 -0500 (EST)
Received: from smurfbsd.warganizer.com (localhost [127.0.0.1])
	by smurfbsd.warganizer.com (8.14.2/8.14.2) with ESMTP id m06LN2qN039252; Sun,
 06 Jan 2008 21:23:02 +0000 (GMT)
Received: (from rucci@localhost)	by smurfbsd.warganizer.com
 (8.14.2/8.14.2/Submit) id m06LN2wh039251; Sun,
 06 Jan 2008 21:23:02 +0000 (envelope-from rucci)
Message-Id: <200801062123.m06LN2wh039251@smurfbsd.warganizer.com>
Date: Sun, 06 Jan 2008 21:23:02 +0000 (GMT)
From: Daniel Rucci <rucci@smurfbsd.warganizer.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: freebsd-eclipse@freebsd.org
Subject: [PATCH] java/eclipse-devel: eclipse.desktop should point to
 eclipse-devel
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         119403
>Category:       ports
>Synopsis:       [PATCH] java/eclipse-devel: eclipse.desktop should point to eclipse-devel
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glewis
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 07 02:50:01 UTC 2008
>Closed-Date:    Wed Jan 16 16:26:31 UTC 2008
>Last-Modified:  Wed Jan 16 16:30:01 UTC 2008
>Originator:     Daniel Rucci
>Release:        FreeBSD 7.0-BETA4 i386
>Organization:
>Environment:
System: FreeBSD smurfbsd.warganizer.com 7.0-BETA4 FreeBSD 7.0-BETA4 #10: Sat Dec 15 22:43:38 UTC 2007
>Description:
  - eclipse.desktop should be eclipse-devel, the current short cut would point to java/eclipse rather then this port.
  - I made the Makefile port(1) friendly (It didn't like PORTNAME=eclipse ). 
  - removed whitespace from distfile because portlint(1) didn't like this.

Port maintainer (freebsd-eclipse@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
Install java/eclipse-devel & Use the shortcut 
>Fix:

--- eclipse-devel-3.3.1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/java/eclipse-devel/Makefile /usr/home/rucci/myports/java/eclipse-devel/Makefile
--- /usr/ports/java/eclipse-devel/Makefile	2007-10-25 15:32:29.000000000 +0000
+++ /usr/home/rucci/myports/java/eclipse-devel/Makefile	2008-01-06 21:18:07.000000000 +0000
@@ -5,12 +5,12 @@
 # $FreeBSD: ports/java/eclipse-devel/Makefile,v 1.13 2007/10/25 15:32:29 glewis Exp $
 #
 
-PORTNAME=	eclipse
+PORTNAME=	eclipse-devel
 PORTVERSION=	3.3.1
 CATEGORIES=	java devel
 MASTER_SITES=	${MASTER_SITE_ECLIPSE}
 MASTER_SITE_SUBDIR=	R-${PORTVERSION}-200709211145
-DISTNAME=	${PORTNAME}-sourceBuild-srcIncluded-${PORTVERSION}
+DISTNAME=	eclipse-sourceBuild-srcIncluded-${PORTVERSION}
 DIST_SUBDIR=	eclipse
 
 MAINTAINER=	freebsd-eclipse@FreeBSD.org
@@ -20,8 +20,7 @@
 		zip:${PORTSDIR}/archivers/zip
 BUILD_DEPENDS+=	${EXTRACT_DEPENDS}
 
-ECLIPSE_SUFX=	-devel
-ECLIPSE=	${PORTNAME}${ECLIPSE_SUFX}
+ECLIPSE=	${PORTNAME}
 
 ONLY_FOR_ARCHS=	i386 amd64
 USE_GMAKE=	yes
diff -ruN --exclude=CVS /usr/ports/java/eclipse-devel/distinfo /usr/home/rucci/myports/java/eclipse-devel/distinfo
--- /usr/ports/java/eclipse-devel/distinfo	2007-10-24 07:05:48.000000000 +0000
+++ /usr/home/rucci/myports/java/eclipse-devel/distinfo	2008-01-06 21:15:03.000000000 +0000
@@ -1,6 +1,3 @@
 MD5 (eclipse/eclipse-sourceBuild-srcIncluded-3.3.1.zip) = 764b585d9a05cd518650e31c32899a29
 SHA256 (eclipse/eclipse-sourceBuild-srcIncluded-3.3.1.zip) = 6dfc8565e94fe06b4187ca58c2bb2c6441753b062d7570fd973a0b9fa5bebbb9
 SIZE (eclipse/eclipse-sourceBuild-srcIncluded-3.3.1.zip) = 94348582
-
-
-
diff -ruN --exclude=CVS /usr/ports/java/eclipse-devel/files/eclipse.desktop /usr/home/rucci/myports/java/eclipse-devel/files/eclipse.desktop
--- /usr/ports/java/eclipse-devel/files/eclipse.desktop	2007-10-13 03:28:15.000000000 +0000
+++ /usr/home/rucci/myports/java/eclipse-devel/files/eclipse.desktop	2008-01-06 21:14:48.000000000 +0000
@@ -1,7 +1,7 @@
 [Desktop Entry]
 Comment=Eclipse IDE
 Name=Eclipse
-Exec=%%PREFIX%%/bin/eclipse
+Exec=%%PREFIX%%/bin/eclipse-devel
 Encoding=UTF-8
 Terminal=false
 Type=Application
--- eclipse-devel-3.3.1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-eclipse 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jan 7 02:50:09 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119403 
Responsible-Changed-From-To: freebsd-eclipse->glewis 
Responsible-Changed-By: glewis 
Responsible-Changed-When: Wed Jan 16 04:26:16 UTC 2008 
Responsible-Changed-Why:  
I'll take this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119403 
State-Changed-From-To: open->closed 
State-Changed-By: glewis 
State-Changed-When: Wed Jan 16 16:26:30 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119403 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/119403: commit references a PR
Date: Wed, 16 Jan 2008 16:26:18 +0000 (UTC)

 glewis      2008-01-16 16:26:13 UTC
 
   FreeBSD ports repository
 
   Modified files:
     java/eclipse-devel   Makefile distinfo 
     java/eclipse-devel/files eclipse.desktop eclipse.in 
   Log:
   . Make eclipse-devel.desktop point to eclipse-devel as it should rather
     than eclipse. [1]
   . Use a more consistent naming convention as per other -devel ports. [1]
   . Remove trailing blank lines in distinfo to make portlint(1) happier. [1]
   . Force eclipse-devel to use one of the jdk* ports rather than the
     diablo-jdk15 port on FreeBSD 7.x and higher as mixing the native
     7.x libraries of eclipse and the native 6.x libraries of diablo-jdk
     is a recipe for trouble. [2]
   
   PR:             119403 [1], 118115 [2]
   Submitted by:   Daniel Rucci <rucci@smurfbsd.warganizer.com> [1]
   
   Revision  Changes    Path
   1.14      +17 -4     ports/java/eclipse-devel/Makefile
   1.6       +0 -3      ports/java/eclipse-devel/distinfo
   1.2       +1 -1      ports/java/eclipse-devel/files/eclipse.desktop
   1.4       +2 -2      ports/java/eclipse-devel/files/eclipse.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
