From ed@hoeg.nl  Fri Dec 28 13:58:07 2007
Return-Path: <ed@hoeg.nl>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3B57C16A418
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 28 Dec 2007 13:58:07 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:610:652::211])
	by mx1.freebsd.org (Postfix) with ESMTP id CD8A113C44B
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 28 Dec 2007 13:58:06 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 47E131CCD9; Fri, 28 Dec 2007 14:56:02 +0100 (CET)
Message-Id: <20071228135602.47E131CCD9@palm.hoeg.nl>
Date: Fri, 28 Dec 2007 14:56:02 +0100 (CET)
From: Ed Schouten <ed@fxq.nl>
Reply-To: Ed Schouten <ed@fxq.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [Patch] emulators/prodosemu: don't include sgtty
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         119101
>Category:       ports
>Synopsis:       [Patch] emulators/prodosemu: don't include sgtty
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 28 14:00:05 UTC 2007
>Closed-Date:    Thu Jan 03 21:05:32 UTC 2008
>Last-Modified:  Thu Jan  3 21:10:09 UTC 2008
>Originator:     Ed Schouten
>Release:        FreeBSD 6.3-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD palm.hoeg.nl 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #0: Wed Dec 19 16:07:46 CET 2007 ed@palm.hoeg.nl:/usr/obj/usr/src/sys/PALM i386
>Description:
The prodosemu port includes the sgtty header file, but doesn't do
anything with it. This is bad habit, especially because the sgtty.h is a
deprecated header file, which describes an interface that's only present
when COMPAT_43TTY is present in the kernel.

There's no real harm in this case, but say, we want to remove this
header file, it will cause compilation to fail.
>How-To-Repeat:
>Fix:
This patch patches up the existing patch-ab in the files dir:

--- emulators/prodosemu/files/patch-ab	2000-08-23 10:43:36.000000000 +0200
+++ emulators/prodosemu/files/patch-ab	2007-12-28 14:53:48.000000000 +0100
@@ -1,12 +1,18 @@
 --- apple.h.orig	Tue Jan  9 13:00:03 1996
 +++ apple.h	Tue Aug 15 20:34:22 2000
-@@ -18,8 +18,7 @@
+@@ -17,15 +17,6 @@
+ #include <ctype.h>
  #endif
  
- #ifndef CBREAK
+-#ifndef CBREAK
 -/*#include <sgtty.h>*/
 -#include <bsd/sgtty.h>
-+#include <sgtty.h>
+-#endif
+-
+-#ifndef TIOCGETP
+-#include <sys/ioctl.h>
+-#endif
+-
+ #ifndef O_NDELAY
+ #include <fcntl.h>
  #endif
- 
- #ifndef TIOCGETP
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Fri Dec 28 14:49:41 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119101 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Thu Jan 3 21:05:31 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119101 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/119101: commit references a PR
Date: Thu,  3 Jan 2008 21:03:45 +0000 (UTC)

 miwi        2008-01-03 21:03:39 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/prodosemu/files patch-ab 
   Log:
   The prodosemu port includes the sgtty header file, but doesn't do
   anything with it. This is bad habit, especially because the sgtty.h is a
   deprecated header file, which describes an interface that's only present
   when COMPAT_43TTY is present in the kernel.
   
   There's no real harm in this case, but say, we want to remove this
   header file, it will cause compilation to fail.
   
   PR:             119101
   Submitted by:   Ed Schouten <ed@fxq.nl>
   
   Revision  Changes    Path
   1.3       +11 -5     ports/emulators/prodosemu/files/patch-ab
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
